* [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD
@ 2013-03-13 10:52 Vikas Sajjan
2013-04-02 5:17 ` Vikas Sajjan
0 siblings, 1 reply; 3+ messages in thread
From: Vikas Sajjan @ 2013-03-13 10:52 UTC (permalink / raw)
To: dri-devel
Cc: linux-media, kgene.kim, joshi, inki.dae, linaro-kernel, jy0922.shim
Replaces the "platform_get_resource() for IORESOURCE_IRQ" with
platform_get_resource_byname().
Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order: "fifo",
"vsync", and "lcd_sys".
But The FIMD driver expects the "vsync" interrupt to be mentioned as the
1st parameter in the FIMD DT node. So to meet this expectation of the
driver, the FIMD DT node was forced to be made by keeping "vsync" as the
1st paramter.
For example in exynos4, the FIMD DT node has interrupt numbers
mentioned as <11, 1> <11, 0> <11, 2> keeping "vsync" as the 1st paramter.
This patch fixes the above mentioned "hack" of re-ordering of the
FIMD interrupt numbers by getting interrupt resource of FIMD by using
platform_get_resource_byname().
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 1ea173a..cd79d38 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev)
return -ENXIO;
}
- res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
+ res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync");
if (!res) {
dev_err(dev, "irq request failed.\n");
return -ENXIO;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD
2013-03-13 10:52 [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD Vikas Sajjan
@ 2013-04-02 5:17 ` Vikas Sajjan
2013-04-02 8:57 ` Inki Dae
0 siblings, 1 reply; 3+ messages in thread
From: Vikas Sajjan @ 2013-04-02 5:17 UTC (permalink / raw)
To: inki.dae
Cc: Sylwester Nawrocki, dri-devel, linux-media, kgene.kim, joshi,
jy0922.shim
Hi Mr. Inki Dae,
Can you please review this patch.?
On Wed, Mar 13, 2013 at 4:22 PM, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> Replaces the "platform_get_resource() for IORESOURCE_IRQ" with
> platform_get_resource_byname().
> Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order: "fifo",
> "vsync", and "lcd_sys".
> But The FIMD driver expects the "vsync" interrupt to be mentioned as the
> 1st parameter in the FIMD DT node. So to meet this expectation of the
> driver, the FIMD DT node was forced to be made by keeping "vsync" as the
> 1st paramter.
> For example in exynos4, the FIMD DT node has interrupt numbers
> mentioned as <11, 1> <11, 0> <11, 2> keeping "vsync" as the 1st paramter.
>
> This patch fixes the above mentioned "hack" of re-ordering of the
> FIMD interrupt numbers by getting interrupt resource of FIMD by using
> platform_get_resource_byname().
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 1ea173a..cd79d38 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync");
> if (!res) {
> dev_err(dev, "irq request failed.\n");
> return -ENXIO;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD
2013-04-02 5:17 ` Vikas Sajjan
@ 2013-04-02 8:57 ` Inki Dae
0 siblings, 0 replies; 3+ messages in thread
From: Inki Dae @ 2013-04-02 8:57 UTC (permalink / raw)
To: Vikas Sajjan
Cc: Sylwester Nawrocki, Kukjin Kim, sunil joshi, DRI mailing list,
linux-media
[-- Attachment #1.1: Type: text/plain, Size: 2228 bytes --]
Applied. :)
Thanks,
Inki Dae
2013/4/2 Vikas Sajjan <sajjan.linux@gmail.com>
> Hi Mr. Inki Dae,
>
> Can you please review this patch.?
>
> On Wed, Mar 13, 2013 at 4:22 PM, Vikas Sajjan <vikas.sajjan@linaro.org>
> wrote:
> > Replaces the "platform_get_resource() for IORESOURCE_IRQ" with
> > platform_get_resource_byname().
> > Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order:
> "fifo",
> > "vsync", and "lcd_sys".
> > But The FIMD driver expects the "vsync" interrupt to be mentioned as the
> > 1st parameter in the FIMD DT node. So to meet this expectation of the
> > driver, the FIMD DT node was forced to be made by keeping "vsync" as the
> > 1st paramter.
> > For example in exynos4, the FIMD DT node has interrupt numbers
> > mentioned as <11, 1> <11, 0> <11, 2> keeping "vsync" as the 1st paramter.
> >
> > This patch fixes the above mentioned "hack" of re-ordering of the
> > FIMD interrupt numbers by getting interrupt resource of FIMD by using
> > platform_get_resource_byname().
> >
> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> > ---
> > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > index 1ea173a..cd79d38 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > @@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev)
> > return -ENXIO;
> > }
> >
> > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> > + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
> "vsync");
> > if (!res) {
> > dev_err(dev, "irq request failed.\n");
> > return -ENXIO;
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
[-- Attachment #1.2: Type: text/html, Size: 3488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-02 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-13 10:52 [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD Vikas Sajjan
2013-04-02 5:17 ` Vikas Sajjan
2013-04-02 8:57 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.