All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@google.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-arm-kernel@lists.infradead.org,
	"the arch/x86 maintainers" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kostya Serebryany <kcc@google.com>
Subject: Re: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage
Date: Fri, 12 Jan 2018 17:49:57 +0100	[thread overview]
Message-ID: <CAAeHK+y=1YedHu=+1pjau=2cYh822vGuNLK_6Q4gYh9eGZBeMg@mail.gmail.com> (raw)
In-Reply-To: <c8f1d954-64fe-1e9c-d8ba-94e880de2501@virtuozzo.com>

On Thu, Jan 11, 2018 at 10:59 PM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
>
>
> On 01/11/2018 06:29 PM, Andrey Konovalov wrote:
>
>> diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h
>> index e266f80e45b7..811643fe7640 100644
>> --- a/arch/arm64/include/asm/kasan.h
>> +++ b/arch/arm64/include/asm/kasan.h
>> @@ -27,7 +27,8 @@
>>   * should satisfy the following equation:
>>   *      KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61)
>
> Care to update comments as well?

Sure, done in v2.

>
>>   */
>> -#define KASAN_SHADOW_OFFSET     (KASAN_SHADOW_END - (1ULL << (64 - 3)))
>> +#define KASAN_SHADOW_OFFSET     (KASAN_SHADOW_END - (1ULL << \
>> +                                     (64 - KASAN_SHADOW_SCALE_SHIFT)))
>>
>>  void kasan_init(void);
>>  void kasan_copy_shadow(pgd_t *pgdir);

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@google.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-arm-kernel@lists.infradead.org,
	the arch/x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kostya Serebryany <kcc@google.com>
Subject: Re: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage
Date: Fri, 12 Jan 2018 17:49:57 +0100	[thread overview]
Message-ID: <CAAeHK+y=1YedHu=+1pjau=2cYh822vGuNLK_6Q4gYh9eGZBeMg@mail.gmail.com> (raw)
In-Reply-To: <c8f1d954-64fe-1e9c-d8ba-94e880de2501@virtuozzo.com>

On Thu, Jan 11, 2018 at 10:59 PM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
>
>
> On 01/11/2018 06:29 PM, Andrey Konovalov wrote:
>
>> diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h
>> index e266f80e45b7..811643fe7640 100644
>> --- a/arch/arm64/include/asm/kasan.h
>> +++ b/arch/arm64/include/asm/kasan.h
>> @@ -27,7 +27,8 @@
>>   * should satisfy the following equation:
>>   *      KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61)
>
> Care to update comments as well?

Sure, done in v2.

>
>>   */
>> -#define KASAN_SHADOW_OFFSET     (KASAN_SHADOW_END - (1ULL << (64 - 3)))
>> +#define KASAN_SHADOW_OFFSET     (KASAN_SHADOW_END - (1ULL << \
>> +                                     (64 - KASAN_SHADOW_SCALE_SHIFT)))
>>
>>  void kasan_init(void);
>>  void kasan_copy_shadow(pgd_t *pgdir);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: andreyknvl@google.com (Andrey Konovalov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage
Date: Fri, 12 Jan 2018 17:49:57 +0100	[thread overview]
Message-ID: <CAAeHK+y=1YedHu=+1pjau=2cYh822vGuNLK_6Q4gYh9eGZBeMg@mail.gmail.com> (raw)
In-Reply-To: <c8f1d954-64fe-1e9c-d8ba-94e880de2501@virtuozzo.com>

On Thu, Jan 11, 2018 at 10:59 PM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
>
>
> On 01/11/2018 06:29 PM, Andrey Konovalov wrote:
>
>> diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h
>> index e266f80e45b7..811643fe7640 100644
>> --- a/arch/arm64/include/asm/kasan.h
>> +++ b/arch/arm64/include/asm/kasan.h
>> @@ -27,7 +27,8 @@
>>   * should satisfy the following equation:
>>   *      KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61)
>
> Care to update comments as well?

Sure, done in v2.

>
>>   */
>> -#define KASAN_SHADOW_OFFSET     (KASAN_SHADOW_END - (1ULL << (64 - 3)))
>> +#define KASAN_SHADOW_OFFSET     (KASAN_SHADOW_END - (1ULL << \
>> +                                     (64 - KASAN_SHADOW_SCALE_SHIFT)))
>>
>>  void kasan_init(void);
>>  void kasan_copy_shadow(pgd_t *pgdir);

  reply	other threads:[~2018-01-12 16:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 15:29 [PATCH 0/2] kasan: a few cleanups Andrey Konovalov
2018-01-11 15:29 ` Andrey Konovalov
2018-01-11 15:29 ` Andrey Konovalov
2018-01-11 15:29 ` [PATCH 1/2] kasan: fix prototype author email address Andrey Konovalov
2018-01-11 15:29   ` Andrey Konovalov
2018-01-11 15:29   ` Andrey Konovalov
2018-01-11 15:29 ` [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage Andrey Konovalov
2018-01-11 15:29   ` Andrey Konovalov
2018-01-11 15:29   ` Andrey Konovalov
2018-01-11 17:33   ` Will Deacon
2018-01-11 17:33     ` Will Deacon
2018-01-11 17:33     ` Will Deacon
2018-01-11 21:59   ` Andrey Ryabinin
2018-01-11 21:59     ` Andrey Ryabinin
2018-01-11 21:59     ` Andrey Ryabinin
2018-01-12 16:49     ` Andrey Konovalov [this message]
2018-01-12 16:49       ` Andrey Konovalov
2018-01-12 16:49       ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeHK+y=1YedHu=+1pjau=2cYh822vGuNLK_6Q4gYh9eGZBeMg@mail.gmail.com' \
    --to=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=hpa@zytor.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kcc@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.