From: Anup Patel <anup@brainfault.org> To: Zong Li <zong.li@sifive.com> Cc: Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, linux-riscv <linux-riscv@lists.infradead.org>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH 1/6] dt-bindings: riscv: Add YAML documentation for PMU Date: Mon, 29 Jun 2020 10:07:57 +0530 [thread overview] Message-ID: <CAAhSdy3BUfPCS+LUWp9GKdnf960N-UkxtUtRArgkVd-1cGZxhQ@mail.gmail.com> (raw) In-Reply-To: <CANXhq0pV87oSzyAt80ySoXGRXp26bCnahPW0r27J+wjj5yc=nw@mail.gmail.com> On Mon, Jun 29, 2020 at 9:58 AM Zong Li <zong.li@sifive.com> wrote: > > On Mon, Jun 29, 2020 at 12:09 PM Anup Patel <anup@brainfault.org> wrote: > > > > On Mon, Jun 29, 2020 at 8:49 AM Zong Li <zong.li@sifive.com> wrote: > > > > > > Add device tree bindings for performance monitor unit. And it passes the > > > dt_binding_check verification. > > > > > > Signed-off-by: Zong Li <zong.li@sifive.com> > > > --- > > > .../devicetree/bindings/riscv/pmu.yaml | 59 +++++++++++++++++++ > > > 1 file changed, 59 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/riscv/pmu.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/pmu.yaml b/Documentation/devicetree/bindings/riscv/pmu.yaml > > > new file mode 100644 > > > index 000000000000..f55ccbc6c685 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/riscv/pmu.yaml > > > @@ -0,0 +1,59 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/riscv/pmu.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: RISC-V Performance Monitor Units > > > + > > > +maintainers: > > > + - Zong Li <zong.li@sifive.com> > > > + - Paul Walmsley <paul.walmsley@sifive.com> > > > + - Palmer Dabbelt <palmer@dabbelt.com> > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - const: riscv,pmu > > > + > > > + riscv,width-base-cntr: > > > + description: The width of cycle and instret CSRs. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + > > > + riscv,width-event-cntr: > > > + description: The width of hpmcounter CSRs. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > The terms "base" and "event" is confusing because > > we only have counters with no interrupt associated with it. > > > > The RISC-V spec defines 3 counters and rest are all > > implementation specific counters. > > As I know, there are 2 counters of spec definition: cycle and instret. > What is the 3rd counter you mentioned? TIME is a counter CSR. > > > > > I suggest using the terms "spec counters" and "impl counters" > > instead of "base counters" and "event counters". > > OK, they are good to me. Let me change it. > > > > > > Further, "riscv,width" properties are redundant because > > RISC-V spec clearly tells that counters are 64bit for both > > RV32 and RV64. > > > > > + > > > + riscv,n-event-cntr: > > > + description: The number of hpmcounter CSRs. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + > > > + riscv,hw-event-map: > > > + description: The mapping of generic hardware events. Default is no mapping. > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + > > > + riscv,hw-cache-event-map: > > > + description: The mapping of generic hardware cache events. > > > + Default is no mapping. > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + > > > +required: > > > + - compatible > > > + - riscv,width-base-cntr > > > + - riscv,width-event-cntr > > > + - riscv,n-event-cntr > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + pmu { > > > + compatible = "riscv,pmu"; > > > + riscv,width-base-cntr = <64>; > > > + riscv,width-event-cntr = <40>; > > > + riscv,n-event-cntr = <2>; > > > + riscv,hw-event-map = <0x0 0x0 0x1 0x1 0x3 0x0202 0x4 0x4000>; > > > + riscv,hw-cache-event-map = <0x010201 0x0102 0x010204 0x0802>; > > > + }; > > > + > > > +... > > > -- > > > 2.27.0 > > > > > > > Regards, > > Anup
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <anup@brainfault.org> To: Zong Li <zong.li@sifive.com> Cc: linux-riscv <linux-riscv@lists.infradead.org>, Palmer Dabbelt <palmer@dabbelt.com>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com> Subject: Re: [RFC PATCH 1/6] dt-bindings: riscv: Add YAML documentation for PMU Date: Mon, 29 Jun 2020 10:07:57 +0530 [thread overview] Message-ID: <CAAhSdy3BUfPCS+LUWp9GKdnf960N-UkxtUtRArgkVd-1cGZxhQ@mail.gmail.com> (raw) In-Reply-To: <CANXhq0pV87oSzyAt80ySoXGRXp26bCnahPW0r27J+wjj5yc=nw@mail.gmail.com> On Mon, Jun 29, 2020 at 9:58 AM Zong Li <zong.li@sifive.com> wrote: > > On Mon, Jun 29, 2020 at 12:09 PM Anup Patel <anup@brainfault.org> wrote: > > > > On Mon, Jun 29, 2020 at 8:49 AM Zong Li <zong.li@sifive.com> wrote: > > > > > > Add device tree bindings for performance monitor unit. And it passes the > > > dt_binding_check verification. > > > > > > Signed-off-by: Zong Li <zong.li@sifive.com> > > > --- > > > .../devicetree/bindings/riscv/pmu.yaml | 59 +++++++++++++++++++ > > > 1 file changed, 59 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/riscv/pmu.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/pmu.yaml b/Documentation/devicetree/bindings/riscv/pmu.yaml > > > new file mode 100644 > > > index 000000000000..f55ccbc6c685 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/riscv/pmu.yaml > > > @@ -0,0 +1,59 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/riscv/pmu.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: RISC-V Performance Monitor Units > > > + > > > +maintainers: > > > + - Zong Li <zong.li@sifive.com> > > > + - Paul Walmsley <paul.walmsley@sifive.com> > > > + - Palmer Dabbelt <palmer@dabbelt.com> > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - const: riscv,pmu > > > + > > > + riscv,width-base-cntr: > > > + description: The width of cycle and instret CSRs. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + > > > + riscv,width-event-cntr: > > > + description: The width of hpmcounter CSRs. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > The terms "base" and "event" is confusing because > > we only have counters with no interrupt associated with it. > > > > The RISC-V spec defines 3 counters and rest are all > > implementation specific counters. > > As I know, there are 2 counters of spec definition: cycle and instret. > What is the 3rd counter you mentioned? TIME is a counter CSR. > > > > > I suggest using the terms "spec counters" and "impl counters" > > instead of "base counters" and "event counters". > > OK, they are good to me. Let me change it. > > > > > > Further, "riscv,width" properties are redundant because > > RISC-V spec clearly tells that counters are 64bit for both > > RV32 and RV64. > > > > > + > > > + riscv,n-event-cntr: > > > + description: The number of hpmcounter CSRs. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + > > > + riscv,hw-event-map: > > > + description: The mapping of generic hardware events. Default is no mapping. > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + > > > + riscv,hw-cache-event-map: > > > + description: The mapping of generic hardware cache events. > > > + Default is no mapping. > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + > > > +required: > > > + - compatible > > > + - riscv,width-base-cntr > > > + - riscv,width-event-cntr > > > + - riscv,n-event-cntr > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + pmu { > > > + compatible = "riscv,pmu"; > > > + riscv,width-base-cntr = <64>; > > > + riscv,width-event-cntr = <40>; > > > + riscv,n-event-cntr = <2>; > > > + riscv,hw-event-map = <0x0 0x0 0x1 0x1 0x3 0x0202 0x4 0x4000>; > > > + riscv,hw-cache-event-map = <0x010201 0x0102 0x010204 0x0802>; > > > + }; > > > + > > > +... > > > -- > > > 2.27.0 > > > > > > > Regards, > > Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-06-29 20:42 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 3:19 [RFC PATCH 0/6] Support raw event and DT for perf on RISC-V Zong Li 2020-06-29 3:19 ` Zong Li 2020-06-29 3:19 ` [RFC PATCH 1/6] dt-bindings: riscv: Add YAML documentation for PMU Zong Li 2020-06-29 3:19 ` Zong Li 2020-06-29 4:09 ` Anup Patel 2020-06-29 4:09 ` Anup Patel 2020-06-29 4:28 ` Zong Li 2020-06-29 4:28 ` Zong Li 2020-06-29 4:37 ` Anup Patel [this message] 2020-06-29 4:37 ` Anup Patel 2020-06-29 6:35 ` Zong Li 2020-06-29 6:35 ` Zong Li 2020-06-29 8:31 ` Anup Patel 2020-06-29 8:31 ` Anup Patel 2020-07-01 3:22 ` Zong Li 2020-07-01 3:22 ` Zong Li 2020-06-29 3:19 ` [RFC PATCH 2/6] riscv: dts: sifive: Add DT support " Zong Li 2020-06-29 3:19 ` Zong Li 2020-06-29 3:19 ` [RFC PATCH 3/6] riscv: add definition of hpmcounter CSRs Zong Li 2020-06-29 3:19 ` Zong Li 2020-06-29 3:19 ` [RFC PATCH 4/6] riscv: perf: Add raw event support Zong Li 2020-06-29 3:19 ` Zong Li 2020-06-29 4:17 ` Anup Patel 2020-06-29 4:17 ` Anup Patel 2020-06-29 4:35 ` Zong Li 2020-06-29 4:35 ` Zong Li 2020-06-29 4:40 ` Anup Patel 2020-06-29 4:40 ` Anup Patel 2020-06-29 3:19 ` [RFC PATCH 5/6] riscv: perf: introduce DT mechanism Zong Li 2020-06-29 3:19 ` Zong Li 2020-06-29 4:36 ` Anup Patel 2020-06-29 4:36 ` Anup Patel 2020-06-29 6:26 ` Zong Li 2020-06-29 6:26 ` Zong Li 2020-06-29 11:42 ` kernel test robot 2020-06-29 3:19 ` [RFC PATCH 6/6] riscv: remove PMU menu of Kconfig Zong Li 2020-06-29 3:19 ` Zong Li 2020-06-29 4:52 ` [RFC PATCH 0/6] Support raw event and DT for perf on RISC-V Anup Patel 2020-06-29 4:52 ` Anup Patel 2020-06-29 5:52 ` Zong Li 2020-06-29 5:52 ` Zong Li 2020-06-29 8:27 ` Anup Patel 2020-06-29 8:27 ` Anup Patel 2020-06-29 12:53 ` Zong Li 2020-06-29 12:53 ` Zong Li 2020-06-29 13:23 ` Anup Patel 2020-06-29 13:23 ` Anup Patel 2020-06-30 6:37 ` Zong Li 2020-06-30 6:37 ` Zong Li 2020-06-30 7:39 ` Anup Patel 2020-06-30 7:39 ` Anup Patel 2020-06-30 8:04 ` Zong Li 2020-06-30 8:04 ` Zong Li 2020-06-30 10:18 ` Anup Patel 2020-06-30 10:18 ` Anup Patel 2020-06-30 11:38 ` Anup Patel 2020-06-30 11:38 ` Anup Patel 2020-06-30 18:57 ` Atish Patra 2020-06-30 18:57 ` Atish Patra 2020-07-01 2:14 ` Zong Li 2020-07-01 2:14 ` Zong Li 2020-07-01 11:43 ` Anup Patel 2020-07-01 11:43 ` Anup Patel 2020-07-01 2:11 ` Zong Li 2020-07-01 2:11 ` Zong Li 2020-07-01 1:55 ` Zong Li 2020-07-01 1:55 ` Zong Li 2020-07-01 0:51 ` Alan Kao 2020-07-01 0:51 ` Alan Kao 2020-07-01 1:02 ` Atish Patra 2020-07-01 1:02 ` Atish Patra 2020-07-01 2:45 ` Alan Kao 2020-07-01 2:45 ` Alan Kao 2020-07-01 3:15 ` Zong Li 2020-07-01 3:15 ` Zong Li 2020-07-01 4:13 ` Anup Patel 2020-07-01 4:13 ` Anup Patel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAhSdy3BUfPCS+LUWp9GKdnf960N-UkxtUtRArgkVd-1cGZxhQ@mail.gmail.com \ --to=anup@brainfault.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=zong.li@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.