[PATCH] gator: Add new package

[PATCH] gator: Add new package

[Clément Péron]

To communicate with the target device, Streamline requires the
gator daemon, gatord, to be running on the device.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---

Changes since v1:
 - Bump to 7.6.0
 - Add upstream-status and signoff patch
 - Add Kernel config requirement to summary
 - Add Homepage
 - Add all Licenses and checksums

 .../gator/0001-gator-don-t-strip-debug.patch  | 29 ++++++++++++++++++
 .../recipes-devtools/gator/gator_7.6.0.bb     | 30 +++++++++++++++++++
 2 files changed, 59 insertions(+)
 create mode 100644 meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
 create mode 100644 meta-arm/recipes-devtools/gator/gator_7.6.0.bb

diff --git a/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
new file mode 100644
index 000000000000..dc30809b58f8
--- /dev/null
+++ b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
@@ -0,0 +1,29 @@
+From 5b51a78186f0ea7474902d8ed8f2c96d8be91c33 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <peron.clem@gmail.com>
+Date: Fri, 16 Apr 2021 15:27:16 +0200
+Subject: [PATCH] gator: don't strip debug
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Upstream-Status: Submitted [https://github.com/ARM-software/gator/pull/26]
+Signed-off-by: Clément Péron <peron.clem@gmail.com>
+---
+ daemon/Makefile | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/daemon/Makefile b/daemon/Makefile
+index ba5f29cfeb10..6807948310f9 100644
+--- a/daemon/Makefile
++++ b/daemon/Makefile
+@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
+ 	CXXFLAGS += -fno-sized-deallocation
+ endif
+ 
+-# -s strips the binary of debug info
+-LDFLAGS     += -s
+ LDLIBS      += -lrt -lm -pthread
+ TARGET      := $(OBJ_DIR)gatord
+ ESCAPE_EXE  := $(OBJ_DIR)escape/escape
+-- 
+2.25.1
diff --git a/meta-arm/recipes-devtools/gator/gator_7.6.0.bb b/meta-arm/recipes-devtools/gator/gator_7.6.0.bb
new file mode 100644
index 000000000000..75f144b209aa
--- /dev/null
+++ b/meta-arm/recipes-devtools/gator/gator_7.6.0.bb
@@ -0,0 +1,30 @@
+SUMMARY = "DS-5 Streamine Gator daemon"
+DESCRIPTION = "Target-side daemon gathering data for ARM Streamline \
+Performance Analyzer. Note that Gator uses the Linux Perf API for \
+most of its data collection. Check that your Kernel follow the \
+configuration requirement specified here: \
+https://github.com/ARM-software/gator#kernel-configuration"
+HOMEPAGE = "https://github.com/ARM-software/gator"
+
+LICENSE = "GPLv2 & LGPLv2.1+ & Apache-2.0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+		    file://libsensors/COPYING.LGPL;md5=4fbd65380cdd255951079008b364516c \
+		    file://mxml/LICENSE;md5=86d3f3a95c324c9479bd8986968f4327 \
+		    file://k/perf_event.h;endline=14;md5=e548bf30a60b2ed11ef2dcf7bfdac230 \
+		   "
+
+SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
+SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
+	   file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
+          "
+
+S = "${WORKDIR}/git/daemon"
+
+EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
+		 'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
+		 'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
+
+do_install() {
+        install -d ${D}${sbindir}
+        install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
+}
-- 
2.25.1

Re: [meta-arm] [PATCH] gator: Add new package

[Ross Burton]

On Sat, 1 May 2021 at 19:53, Clément Péron <peron.clem@gmail.com> wrote:
> +SUMMARY = "DS-5 Streamine Gator daemon"

Typo in "Streamline"

> +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline \
> +Performance Analyzer. Note that Gator uses the Linux Perf API for \
> +most of its data collection. Check that your Kernel follow the \
> +configuration requirement specified here: \
> +https://github.com/ARM-software/gator#kernel-configuration"

Far too verbose a DESCRIPTION, the first sentence is sufficient. You
can put the kernel configuration in a comment in the recipe.

>SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
>. file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
>. "

There's a mix of spaces and tabs on the line with the patch, just spaces please.

> EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \

Also pass V=1 so the build log is verbose.

I'm guessing this doesn't work on x86-64 hosts?  If so add
COMPATIBLE_HOST = "aarch64.*-linux" to make that explicit (as
otherwise a world build with meta-arm present will try to build it).

As this is just the daemon, should the recipe be gator-daemon? Or do
you plan to add the rest of the tools in the future?

Ross

Re: [meta-arm] [PATCH] gator: Add new package

[Ross Burton]

Good news: that patch is now merged upstream.

Do you plan on sending a revised gator recipe?

Ross

On Mon, 10 May 2021 at 18:14, Ross Burton <ross@burtonini.com> wrote:
>
> On Sat, 1 May 2021 at 19:53, Clément Péron <peron.clem@gmail.com> wrote:
> > +SUMMARY = "DS-5 Streamine Gator daemon"
>
> Typo in "Streamline"
>
> > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline \
> > +Performance Analyzer. Note that Gator uses the Linux Perf API for \
> > +most of its data collection. Check that your Kernel follow the \
> > +configuration requirement specified here: \
> > +https://github.com/ARM-software/gator#kernel-configuration"
>
> Far too verbose a DESCRIPTION, the first sentence is sufficient. You
> can put the kernel configuration in a comment in the recipe.
>
> >SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
> >. file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> >. "
>
> There's a mix of spaces and tabs on the line with the patch, just spaces please.
>
> > EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
>
> Also pass V=1 so the build log is verbose.
>
> I'm guessing this doesn't work on x86-64 hosts?  If so add
> COMPATIBLE_HOST = "aarch64.*-linux" to make that explicit (as
> otherwise a world build with meta-arm present will try to build it).
>
> As this is just the daemon, should the recipe be gator-daemon? Or do
> you plan to add the rest of the tools in the future?
>
> Ross

Re: [meta-arm] [PATCH] gator: Add new package

[Clément Péron]

Hi Ross,

I will send a v2.

On Tue, 8 Jun 2021 at 16:05, Ross Burton <ross@burtonini.com> wrote:
>
> Good news: that patch is now merged upstream.
>
> Do you plan on sending a revised gator recipe?
>
> Ross
>
> On Mon, 10 May 2021 at 18:14, Ross Burton <ross@burtonini.com> wrote:
> >
> > On Sat, 1 May 2021 at 19:53, Clément Péron <peron.clem@gmail.com> wrote:
> > > +SUMMARY = "DS-5 Streamine Gator daemon"
> >
> > Typo in "Streamline"
> >
> > > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline \
> > > +Performance Analyzer. Note that Gator uses the Linux Perf API for \
> > > +most of its data collection. Check that your Kernel follow the \
> > > +configuration requirement specified here: \
> > > +https://github.com/ARM-software/gator#kernel-configuration"
> >
> > Far too verbose a DESCRIPTION, the first sentence is sufficient. You
> > can put the kernel configuration in a comment in the recipe.
> >
> > >SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
> > >. file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> > >. "
> >
> > There's a mix of spaces and tabs on the line with the patch, just spaces please.
> >
> > > EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> >
> > Also pass V=1 so the build log is verbose.
> >
> > I'm guessing this doesn't work on x86-64 hosts?  If so add
> > COMPATIBLE_HOST = "aarch64.*-linux" to make that explicit (as
> > otherwise a world build with meta-arm present will try to build it).
> >
> > As this is just the daemon, should the recipe be gator-daemon? Or do
> > you plan to add the rest of the tools in the future?

I don't plan for the moment to add the rest of the tools but maybe someone will.
For the package name up to you, what do you prefer?

Clement

> >
> > Ross

Re: [meta-arm] [PATCH] gator: Add new package

[Ross Burton]

On Wed, 9 Jun 2021 at 09:18, Clément Péron <peron.clem@gmail.com> wrote:
> I don't plan for the moment to add the rest of the tools but maybe someone will.
> For the package name up to you, what do you prefer?

Maybe use gator-daemon so that if the rest of the suite is built in
the future we don't need to rename anything.

Ross