* [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: linux-arm-kernel
HW and driver support the GPIO as interrupt-controller. Document that in
the DT binding.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
Documentation/devicetree/bindings/gpio/gpio-zynq.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt b/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
index db4c6a663c03..7b542657f259 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
@@ -12,6 +12,13 @@ Required properties:
- interrupts : Interrupt specifier (see interrupt bindings for
details)
- interrupt-parent : Must be core interrupt controller
+- interrupt-controller : Marks the device node as an interrupt controller.
+- #interrupt-cells : Should be 2. The first cell is the GPIO number.
+ The second cell bits[3:0] is used to specify trigger type and level flags:
+ 1 = low-to-high edge triggered.
+ 2 = high-to-low edge triggered.
+ 4 = active high level-sensitive.
+ 8 = active low level-sensitive.
- reg : Address and length of the register set for the device
Example:
@@ -22,5 +29,7 @@ Example:
gpio-controller;
interrupt-parent = <&intc>;
interrupts = <0 20 4>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
reg = <0xe000a000 0x1000>;
};
--
2.6.2.3.ga463a5b
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Linus Walleij
Cc: Russell King, Catalin Marinas, Will Deacon, linux-kernel,
linux-arm-kernel, devicetree, Soren Brinkmann
HW and driver support the GPIO as interrupt-controller. Document that in
the DT binding.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
Documentation/devicetree/bindings/gpio/gpio-zynq.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt b/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
index db4c6a663c03..7b542657f259 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
@@ -12,6 +12,13 @@ Required properties:
- interrupts : Interrupt specifier (see interrupt bindings for
details)
- interrupt-parent : Must be core interrupt controller
+- interrupt-controller : Marks the device node as an interrupt controller.
+- #interrupt-cells : Should be 2. The first cell is the GPIO number.
+ The second cell bits[3:0] is used to specify trigger type and level flags:
+ 1 = low-to-high edge triggered.
+ 2 = high-to-low edge triggered.
+ 4 = active high level-sensitive.
+ 8 = active low level-sensitive.
- reg : Address and length of the register set for the device
Example:
@@ -22,5 +29,7 @@ Example:
gpio-controller;
interrupt-parent = <&intc>;
interrupts = <0 20 4>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
reg = <0xe000a000 0x1000>;
};
--
2.6.2.3.ga463a5b
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Linus Walleij
Cc: Russell King, Catalin Marinas, Will Deacon, linux-kernel,
linux-arm-kernel, devicetree, Soren Brinkmann
GPIO can be used as interrupt-controller. Add the missing properties to
the GPIO node.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
arch/arm/boot/dts/zynq-7000.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index 1a5220e05109..fe1a5d0cf03b 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -101,6 +101,8 @@
#gpio-cells = <2>;
clocks = <&clkc 42>;
gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <2>;
interrupt-parent = <&intc>;
interrupts = <0 20 4>;
reg = <0xe000a000 0x1000>;
--
2.6.2.3.ga463a5b
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: linux-arm-kernel
GPIO can be used as interrupt-controller. Add the missing properties to
the GPIO node.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
arch/arm/boot/dts/zynq-7000.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index 1a5220e05109..fe1a5d0cf03b 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -101,6 +101,8 @@
#gpio-cells = <2>;
clocks = <&clkc 42>;
gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <2>;
interrupt-parent = <&intc>;
interrupts = <0 20 4>;
reg = <0xe000a000 0x1000>;
--
2.6.2.3.ga463a5b
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Linus Walleij
Cc: Russell King, Catalin Marinas, Will Deacon,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Soren Brinkmann
GPIO can be used as interrupt-controller. Add the missing properties to
the GPIO node.
Signed-off-by: Soren Brinkmann <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
---
arch/arm/boot/dts/zynq-7000.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index 1a5220e05109..fe1a5d0cf03b 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -101,6 +101,8 @@
#gpio-cells = <2>;
clocks = <&clkc 42>;
gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <2>;
interrupt-parent = <&intc>;
interrupts = <0 20 4>;
reg = <0xe000a000 0x1000>;
--
2.6.2.3.ga463a5b
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
2015-10-23 16:25 ` Soren Brinkmann
@ 2015-10-23 16:53 ` Moritz Fischer
-1 siblings, 0 replies; 23+ messages in thread
From: Moritz Fischer @ 2015-10-23 16:53 UTC (permalink / raw)
To: Soren Brinkmann
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Linus Walleij, Russell King, Catalin Marinas,
Will Deacon, linux-kernel, linux-arm-kernel, devicetree
On Fri, Oct 23, 2015 at 9:25 AM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> arch/arm/boot/dts/zynq-7000.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 1a5220e05109..fe1a5d0cf03b 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -101,6 +101,8 @@
> #gpio-cells = <2>;
> clocks = <&clkc 42>;
> gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> interrupt-parent = <&intc>;
> interrupts = <0 20 4>;
> reg = <0xe000a000 0x1000>;
> --
> 2.6.2.3.ga463a5b
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-23 16:53 ` Moritz Fischer
0 siblings, 0 replies; 23+ messages in thread
From: Moritz Fischer @ 2015-10-23 16:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 23, 2015 at 9:25 AM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> arch/arm/boot/dts/zynq-7000.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 1a5220e05109..fe1a5d0cf03b 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -101,6 +101,8 @@
> #gpio-cells = <2>;
> clocks = <&clkc 42>;
> gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> interrupt-parent = <&intc>;
> interrupts = <0 20 4>;
> reg = <0xe000a000 0x1000>;
> --
> 2.6.2.3.ga463a5b
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
2015-10-23 16:25 ` Soren Brinkmann
(?)
@ 2015-10-27 16:04 ` Linus Walleij
-1 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-10-27 16:04 UTC (permalink / raw)
To: Soren Brinkmann
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Russell King, Catalin Marinas, Will Deacon,
linux-kernel, linux-arm-kernel, devicetree
On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-27 16:04 ` Linus Walleij
0 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-10-27 16:04 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-27 16:04 ` Linus Walleij
0 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-10-27 16:04 UTC (permalink / raw)
To: Soren Brinkmann
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Russell King, Catalin Marinas, Will Deacon,
linux-kernel, linux-arm-kernel, devicetree
On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
2015-10-27 16:04 ` Linus Walleij
(?)
@ 2015-10-29 7:53 ` Michal Simek
-1 siblings, 0 replies; 23+ messages in thread
From: Michal Simek @ 2015-10-29 7:53 UTC (permalink / raw)
To: Linus Walleij, Soren Brinkmann
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Russell King, Catalin Marinas, Will Deacon,
linux-kernel, linux-arm-kernel, devicetree
On 10/27/2015 05:04 PM, Linus Walleij wrote:
> On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
>
>> GPIO can be used as interrupt-controller. Add the missing properties to
>> the GPIO node.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied to zynq/dt.
Thanks,
Michal
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-29 7:53 ` Michal Simek
0 siblings, 0 replies; 23+ messages in thread
From: Michal Simek @ 2015-10-29 7:53 UTC (permalink / raw)
To: linux-arm-kernel
On 10/27/2015 05:04 PM, Linus Walleij wrote:
> On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
>
>> GPIO can be used as interrupt-controller. Add the missing properties to
>> the GPIO node.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied to zynq/dt.
Thanks,
Michal
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO
@ 2015-10-29 7:53 ` Michal Simek
0 siblings, 0 replies; 23+ messages in thread
From: Michal Simek @ 2015-10-29 7:53 UTC (permalink / raw)
To: Linus Walleij, Soren Brinkmann
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Russell King, Catalin Marinas, Will Deacon,
linux-kernel, linux-arm-kernel, devicetree
On 10/27/2015 05:04 PM, Linus Walleij wrote:
> On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
>
>> GPIO can be used as interrupt-controller. Add the missing properties to
>> the GPIO node.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied to zynq/dt.
Thanks,
Michal
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 3/3] ARM64: zynqmp: DT: Add interrupt-controller property to GPIO
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Linus Walleij
Cc: Russell King, Catalin Marinas, Will Deacon, linux-kernel,
linux-arm-kernel, devicetree, Soren Brinkmann
GPIO can be used as interrupt-controller. Add the missing properties to
the GPIO node.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 857eda5c7217..200fb588d0f5 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -133,6 +133,8 @@
clocks = <&misc_clk>;
interrupt-parent = <&gic>;
interrupts = <0 16 4>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
reg = <0x0 0xff0a0000 0x1000>;
};
--
2.6.2.3.ga463a5b
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 3/3] ARM64: zynqmp: DT: Add interrupt-controller property to GPIO
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: linux-arm-kernel
GPIO can be used as interrupt-controller. Add the missing properties to
the GPIO node.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 857eda5c7217..200fb588d0f5 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -133,6 +133,8 @@
clocks = <&misc_clk>;
interrupt-parent = <&gic>;
interrupts = <0 16 4>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
reg = <0x0 0xff0a0000 0x1000>;
};
--
2.6.2.3.ga463a5b
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 3/3] ARM64: zynqmp: DT: Add interrupt-controller property to GPIO
@ 2015-10-23 16:25 ` Soren Brinkmann
0 siblings, 0 replies; 23+ messages in thread
From: Soren Brinkmann @ 2015-10-23 16:25 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Linus Walleij
Cc: Russell King, Catalin Marinas, Will Deacon,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Soren Brinkmann
GPIO can be used as interrupt-controller. Add the missing properties to
the GPIO node.
Signed-off-by: Soren Brinkmann <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 857eda5c7217..200fb588d0f5 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -133,6 +133,8 @@
clocks = <&misc_clk>;
interrupt-parent = <&gic>;
interrupts = <0 16 4>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
reg = <0x0 0xff0a0000 0x1000>;
};
--
2.6.2.3.ga463a5b
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 3/3] ARM64: zynqmp: DT: Add interrupt-controller property to GPIO
2015-10-23 16:25 ` Soren Brinkmann
(?)
@ 2015-10-29 16:37 ` Michal Simek
-1 siblings, 0 replies; 23+ messages in thread
From: Michal Simek @ 2015-10-29 16:37 UTC (permalink / raw)
To: Soren Brinkmann, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Michal Simek, Linus Walleij
Cc: Russell King, Catalin Marinas, Will Deacon, linux-kernel,
linux-arm-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
On 10/23/2015 06:25 PM, Soren Brinkmann wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 857eda5c7217..200fb588d0f5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -133,6 +133,8 @@
> clocks = <&misc_clk>;
> interrupt-parent = <&gic>;
> interrupts = <0 16 4>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> reg = <0x0 0xff0a0000 0x1000>;
> };
>
>
Applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 3/3] ARM64: zynqmp: DT: Add interrupt-controller property to GPIO
@ 2015-10-29 16:37 ` Michal Simek
0 siblings, 0 replies; 23+ messages in thread
From: Michal Simek @ 2015-10-29 16:37 UTC (permalink / raw)
To: linux-arm-kernel
On 10/23/2015 06:25 PM, Soren Brinkmann wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 857eda5c7217..200fb588d0f5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -133,6 +133,8 @@
> clocks = <&misc_clk>;
> interrupt-parent = <&gic>;
> interrupts = <0 16 4>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> reg = <0x0 0xff0a0000 0x1000>;
> };
>
>
Applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151029/0e94b497/attachment.sig>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 3/3] ARM64: zynqmp: DT: Add interrupt-controller property to GPIO
@ 2015-10-29 16:37 ` Michal Simek
0 siblings, 0 replies; 23+ messages in thread
From: Michal Simek @ 2015-10-29 16:37 UTC (permalink / raw)
To: Soren Brinkmann, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Michal Simek, Linus Walleij
Cc: devicetree, Russell King, Catalin Marinas, Will Deacon,
linux-kernel, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1115 bytes --]
On 10/23/2015 06:25 PM, Soren Brinkmann wrote:
> GPIO can be used as interrupt-controller. Add the missing properties to
> the GPIO node.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 857eda5c7217..200fb588d0f5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -133,6 +133,8 @@
> clocks = <&misc_clk>;
> interrupt-parent = <&gic>;
> interrupts = <0 16 4>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> reg = <0x0 0xff0a0000 0x1000>;
> };
>
>
Applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller
2015-10-23 16:25 ` Soren Brinkmann
(?)
@ 2015-10-27 16:03 ` Linus Walleij
-1 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-10-27 16:03 UTC (permalink / raw)
To: Soren Brinkmann
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Russell King, Catalin Marinas, Will Deacon,
linux-kernel, linux-arm-kernel, devicetree
On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> HW and driver support the GPIO as interrupt-controller. Document that in
> the DT binding.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Patch subject augmented and applied.
> +- interrupt-controller : Marks the device node as an interrupt controller.
> +- #interrupt-cells : Should be 2. The first cell is the GPIO number.
> + The second cell bits[3:0] is used to specify trigger type and level flags:
> + 1 = low-to-high edge triggered.
> + 2 = high-to-low edge triggered.
> + 4 = active high level-sensitive.
> + 8 = active low level-sensitive.
If these can be or:ed together, e.g 3 = both edges, that needs to be
documented. If they can't the current patch is fine I guess.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller
@ 2015-10-27 16:03 ` Linus Walleij
0 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-10-27 16:03 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> HW and driver support the GPIO as interrupt-controller. Document that in
> the DT binding.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Patch subject augmented and applied.
> +- interrupt-controller : Marks the device node as an interrupt controller.
> +- #interrupt-cells : Should be 2. The first cell is the GPIO number.
> + The second cell bits[3:0] is used to specify trigger type and level flags:
> + 1 = low-to-high edge triggered.
> + 2 = high-to-low edge triggered.
> + 4 = active high level-sensitive.
> + 8 = active low level-sensitive.
If these can be or:ed together, e.g 3 = both edges, that needs to be
documented. If they can't the current patch is fine I guess.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller
@ 2015-10-27 16:03 ` Linus Walleij
0 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-10-27 16:03 UTC (permalink / raw)
To: Soren Brinkmann
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Michal Simek, Russell King, Catalin Marinas, Will Deacon,
linux-kernel, linux-arm-kernel, devicetree
On Fri, Oct 23, 2015 at 6:25 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> HW and driver support the GPIO as interrupt-controller. Document that in
> the DT binding.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Patch subject augmented and applied.
> +- interrupt-controller : Marks the device node as an interrupt controller.
> +- #interrupt-cells : Should be 2. The first cell is the GPIO number.
> + The second cell bits[3:0] is used to specify trigger type and level flags:
> + 1 = low-to-high edge triggered.
> + 2 = high-to-low edge triggered.
> + 4 = active high level-sensitive.
> + 8 = active low level-sensitive.
If these can be or:ed together, e.g 3 = both edges, that needs to be
documented. If they can't the current patch is fine I guess.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 23+ messages in thread