* the messenger to send osd write ack|ondisk
@ 2011-09-03 2:28 huang jun
2011-09-06 16:37 ` Tommi Virtanen
0 siblings, 1 reply; 4+ messages in thread
From: huang jun @ 2011-09-03 2:28 UTC (permalink / raw)
To: ceph-devel
hi,all
i'm confused by the question:
ceph use client_messenger to send MOSDOpReply:ondisk
but use cluster_messenger to send MOSDOpReply:ack
are they have any difference?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: the messenger to send osd write ack|ondisk
2011-09-03 2:28 the messenger to send osd write ack|ondisk huang jun
@ 2011-09-06 16:37 ` Tommi Virtanen
0 siblings, 0 replies; 4+ messages in thread
From: Tommi Virtanen @ 2011-09-06 16:37 UTC (permalink / raw)
To: huang jun; +Cc: ceph-devel
On Fri, Sep 2, 2011 at 19:28, huang jun <hjwsm1989@gmail.com> wrote:
> hi,all
> i'm confused by the question:
> ceph use client_messenger to send MOSDOpReply:ondisk
> but use cluster_messenger to send MOSDOpReply:ack
> are they have any difference?
client_messenger talks to RADOS clients, cluster_messenger talks to other OSDs.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: the messenger to send osd write ack|ondisk
2011-09-07 4:00 Sage Weil
@ 2011-09-07 5:15 ` Sage Weil
0 siblings, 0 replies; 4+ messages in thread
From: Sage Weil @ 2011-09-07 5:15 UTC (permalink / raw)
To: huang jun; +Cc: ceph-devel
On Tue, 6 Sep 2011, Sage Weil wrote:
> Ah, nice catch. This fixes it:
>
> diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc
> index 73b42ac..48ee6bb 100644
> --- a/src/osd/ReplicatedPG.cc
> +++ b/src/osd/ReplicatedPG.cc
> @@ -2817,7 +2817,7 @@ void ReplicatedPG::eval_repop(RepGather *repop)
> reply = new MOSDOpReply(op, 0, osd->osdmap->get_epoch(), 0);
> reply->add_flags(CEPH_OSD_FLAG_ACK);
> dout(10) << " sending ack on " << *repop << " " << reply << dendl;
> - osd->cluster_messenger->send_message(reply, op->get_connection());
> + osd->client_messenger->send_message(reply, op->get_connection());
> repop->sent_ack = true;
> }
>
> Pushing to master.
Er, looks like Greg already pushed this fix on Sunday!
sage
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: the messenger to send osd write ack|ondisk
@ 2011-09-07 4:00 Sage Weil
2011-09-07 5:15 ` Sage Weil
0 siblings, 1 reply; 4+ messages in thread
From: Sage Weil @ 2011-09-07 4:00 UTC (permalink / raw)
To: huang jun; +Cc: ceph-devel
Ah, nice catch. This fixes it:
diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc
index 73b42ac..48ee6bb 100644
--- a/src/osd/ReplicatedPG.cc
+++ b/src/osd/ReplicatedPG.cc
@@ -2817,7 +2817,7 @@ void ReplicatedPG::eval_repop(RepGather *repop)
reply = new MOSDOpReply(op, 0, osd->osdmap->get_epoch(), 0);
reply->add_flags(CEPH_OSD_FLAG_ACK);
dout(10) << " sending ack on " << *repop << " " << reply << dendl;
- osd->cluster_messenger->send_message(reply, op->get_connection());
+ osd->client_messenger->send_message(reply, op->get_connection());
repop->sent_ack = true;
}
Pushing to master.
Thanks!
sage
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-07 5:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-03 2:28 the messenger to send osd write ack|ondisk huang jun
2011-09-06 16:37 ` Tommi Virtanen
2011-09-07 4:00 Sage Weil
2011-09-07 5:15 ` Sage Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.