* Checkpatch still worries about include/asm/ ?
@ 2021-03-18 16:47 ` Dwaipayan Ray
0 siblings, 0 replies; 6+ messages in thread
From: Dwaipayan Ray @ 2021-03-18 16:47 UTC (permalink / raw)
To: Lukas Bulwahn, Joe Perches, linux-kernel-mentees, linux-kernel
Hello,
include/asm/ got removed a long time back (probably v1.1.45).
Checkpatch still worries about that:
if ($realfile =~ m@^include/asm/@) {
ERROR("MODIFIED_INCLUDE_ASM",
"do not modify files in include/asm, change architecture specific
files in include/asm-<architecture>\n" . "$here$rawline\n");
}
Can we remove this check?
Thanks,
Dwaipayan.
^ permalink raw reply [flat|nested] 6+ messages in thread* Checkpatch still worries about include/asm/ ?
@ 2021-03-18 16:47 ` Dwaipayan Ray
0 siblings, 0 replies; 6+ messages in thread
From: Dwaipayan Ray @ 2021-03-18 16:47 UTC (permalink / raw)
To: Lukas Bulwahn, Joe Perches, linux-kernel-mentees, linux-kernel
Hello,
include/asm/ got removed a long time back (probably v1.1.45).
Checkpatch still worries about that:
if ($realfile =~ m@^include/asm/@) {
ERROR("MODIFIED_INCLUDE_ASM",
"do not modify files in include/asm, change architecture specific
files in include/asm-<architecture>\n" . "$here$rawline\n");
}
Can we remove this check?
Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Checkpatch still worries about include/asm/ ?
2021-03-18 16:47 ` Dwaipayan Ray
@ 2021-03-18 17:03 ` Lukas Bulwahn
-1 siblings, 0 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2021-03-18 17:03 UTC (permalink / raw)
To: Dwaipayan Ray; +Cc: Joe Perches, linux-kernel-mentees, linux-kernel
On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
>
> Hello,
> include/asm/ got removed a long time back (probably v1.1.45).
> Checkpatch still worries about that:
>
> if ($realfile =~ m@^include/asm/@) {
> ERROR("MODIFIED_INCLUDE_ASM",
> "do not modify files in include/asm, change architecture specific
> files in include/asm-<architecture>\n" . "$here$rawline\n");
> }
>
> Can we remove this check?
>
Wow, v1.1.45... that must have been taking quite some digging in the
ancient dirt to find that out.
I agree, let us remove that rule.
Thanks for the documentation effort on checkpatch.pl and cleaning up
obsolete rules while documenting.
Lukas
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Checkpatch still worries about include/asm/ ?
@ 2021-03-18 17:03 ` Lukas Bulwahn
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2021-03-18 17:03 UTC (permalink / raw)
To: Dwaipayan Ray; +Cc: Joe Perches, linux-kernel-mentees, linux-kernel
On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
>
> Hello,
> include/asm/ got removed a long time back (probably v1.1.45).
> Checkpatch still worries about that:
>
> if ($realfile =~ m@^include/asm/@) {
> ERROR("MODIFIED_INCLUDE_ASM",
> "do not modify files in include/asm, change architecture specific
> files in include/asm-<architecture>\n" . "$here$rawline\n");
> }
>
> Can we remove this check?
>
Wow, v1.1.45... that must have been taking quite some digging in the
ancient dirt to find that out.
I agree, let us remove that rule.
Thanks for the documentation effort on checkpatch.pl and cleaning up
obsolete rules while documenting.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Checkpatch still worries about include/asm/ ?
2021-03-18 17:03 ` Lukas Bulwahn
@ 2021-03-18 17:18 ` Dwaipayan Ray
-1 siblings, 0 replies; 6+ messages in thread
From: Dwaipayan Ray @ 2021-03-18 17:18 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: Joe Perches, linux-kernel-mentees, linux-kernel
On Thu, Mar 18, 2021 at 10:33 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> >
> > Hello,
> > include/asm/ got removed a long time back (probably v1.1.45).
> > Checkpatch still worries about that:
> >
> > if ($realfile =~ m@^include/asm/@) {
> > ERROR("MODIFIED_INCLUDE_ASM",
> > "do not modify files in include/asm, change architecture specific
> > files in include/asm-<architecture>\n" . "$here$rawline\n");
> > }
> >
> > Can we remove this check?
> >
>
> Wow, v1.1.45... that must have been taking quite some digging in the
> ancient dirt to find that out.
>
I was actually helped by an user who send a patch in 2016 to remove it:
https://lore.kernel.org/lkml/1482260987-21457-1-git-send-email-pebolle@tiscali.nl/raw
Don't know why it wasnt removed back then.
But it's safe to say this check hasn't been used for decades :)
> I agree, let us remove that rule.
Sure will send the patch.
> Thanks for the documentation effort on checkpatch.pl and cleaning up
> obsolete rules while documenting.
>
It's my pleasure!
Thanks & Regards,
Dwaipayan.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Checkpatch still worries about include/asm/ ?
@ 2021-03-18 17:18 ` Dwaipayan Ray
0 siblings, 0 replies; 6+ messages in thread
From: Dwaipayan Ray @ 2021-03-18 17:18 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: Joe Perches, linux-kernel-mentees, linux-kernel
On Thu, Mar 18, 2021 at 10:33 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> >
> > Hello,
> > include/asm/ got removed a long time back (probably v1.1.45).
> > Checkpatch still worries about that:
> >
> > if ($realfile =~ m@^include/asm/@) {
> > ERROR("MODIFIED_INCLUDE_ASM",
> > "do not modify files in include/asm, change architecture specific
> > files in include/asm-<architecture>\n" . "$here$rawline\n");
> > }
> >
> > Can we remove this check?
> >
>
> Wow, v1.1.45... that must have been taking quite some digging in the
> ancient dirt to find that out.
>
I was actually helped by an user who send a patch in 2016 to remove it:
https://lore.kernel.org/lkml/1482260987-21457-1-git-send-email-pebolle@tiscali.nl/raw
Don't know why it wasnt removed back then.
But it's safe to say this check hasn't been used for decades :)
> I agree, let us remove that rule.
Sure will send the patch.
> Thanks for the documentation effort on checkpatch.pl and cleaning up
> obsolete rules while documenting.
>
It's my pleasure!
Thanks & Regards,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-18 17:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 16:47 Checkpatch still worries about include/asm/ ? Dwaipayan Ray
2021-03-18 16:47 ` Dwaipayan Ray
2021-03-18 17:03 ` Lukas Bulwahn
2021-03-18 17:03 ` Lukas Bulwahn
2021-03-18 17:18 ` Dwaipayan Ray
2021-03-18 17:18 ` Dwaipayan Ray
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.