From: Stephane Eranian <eranian@google.com> To: Peter Zijlstra <peterz@infradead.org> Cc: Michael Neuling <mikey@neuling.org>, Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>, "ak@linux.intel.com" <ak@linux.intel.com>, Michael Ellerman <michael@ellerman.id.au>, "benh@kernel.crashing.org" <benh@kernel.crashing.org>, Linux PPC dev <linuxppc-dev@ozlabs.org> Subject: Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL Date: Thu, 16 May 2013 17:36:11 +0200 [thread overview] Message-ID: <CABPqkBSCXJN7gLK_e_Q3YVVVFVGS78fo4j2z0+MmriqoXszH+w@mail.gmail.com> (raw) In-Reply-To: <20130516111634.GA15314@twins.programming.kicks-ass.net> On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra <peterz@infradead.org> wrote: > On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote: >> Peter, >> >> BTW PowerPC also has the ability to filter on conditional branches. Any >> chance we could add something like the follow to perf also? >> > > I don't see an immediate problem with that except that we on x86 need to > implement that in the software filter. Stephane do you see any > fundamental issue with that? > On X86, the LBR cannot filter on conditional in HW. Thus as Peter said, it would have to be done in SW. I did not add that because I think those branches are not necessarily useful for tools. >> >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h >> index fb104e5..891c769 100644 >> --- a/include/uapi/linux/perf_event.h >> +++ b/include/uapi/linux/perf_event.h >> @@ -157,8 +157,9 @@ enum perf_branch_sample_type { >> PERF_SAMPLE_BRANCH_ANY_CALL = 1U << 4, /* any call branch */ >> PERF_SAMPLE_BRANCH_ANY_RETURN = 1U << 5, /* any return branch */ >> PERF_SAMPLE_BRANCH_IND_CALL = 1U << 6, /* indirect calls */ >> + PERF_SAMPLE_BRANCH_CONDITIONAL = 1U << 7, /* conditional branches */ >> >> - PERF_SAMPLE_BRANCH_MAX = 1U << 7, /* non-ABI */ >> + PERF_SAMPLE_BRANCH_MAX = 1U << 8, /* non-ABI */ >> }; >> >> #define PERF_SAMPLE_BRANCH_PLM_ALL \ >> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c >> index cdf58ec..5b0b89d 100644 >> --- a/tools/perf/builtin-record.c >> +++ b/tools/perf/builtin-record.c >> @@ -676,6 +676,7 @@ static const struct branch_mode branch_modes[] = { >> BRANCH_OPT("any_call", PERF_SAMPLE_BRANCH_ANY_CALL), >> BRANCH_OPT("any_ret", PERF_SAMPLE_BRANCH_ANY_RETURN), >> BRANCH_OPT("ind_call", PERF_SAMPLE_BRANCH_IND_CALL), >> + BRANCH_OPT("cnd", PERF_SAMPLE_BRANCH_CONDITIONAL), >> BRANCH_END >> }; >>
WARNING: multiple messages have this Message-ID (diff)
From: Stephane Eranian <eranian@google.com> To: Peter Zijlstra <peterz@infradead.org> Cc: Michael Neuling <mikey@neuling.org>, "ak@linux.intel.com" <ak@linux.intel.com>, LKML <linux-kernel@vger.kernel.org>, Linux PPC dev <linuxppc-dev@ozlabs.org>, Ingo Molnar <mingo@kernel.org> Subject: Re: [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL Date: Thu, 16 May 2013 17:36:11 +0200 [thread overview] Message-ID: <CABPqkBSCXJN7gLK_e_Q3YVVVFVGS78fo4j2z0+MmriqoXszH+w@mail.gmail.com> (raw) In-Reply-To: <20130516111634.GA15314@twins.programming.kicks-ass.net> On Thu, May 16, 2013 at 1:16 PM, Peter Zijlstra <peterz@infradead.org> wrote: > On Thu, May 16, 2013 at 08:15:17PM +1000, Michael Neuling wrote: >> Peter, >> >> BTW PowerPC also has the ability to filter on conditional branches. Any >> chance we could add something like the follow to perf also? >> > > I don't see an immediate problem with that except that we on x86 need to > implement that in the software filter. Stephane do you see any > fundamental issue with that? > On X86, the LBR cannot filter on conditional in HW. Thus as Peter said, it would have to be done in SW. I did not add that because I think those branches are not necessarily useful for tools. >> >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h >> index fb104e5..891c769 100644 >> --- a/include/uapi/linux/perf_event.h >> +++ b/include/uapi/linux/perf_event.h >> @@ -157,8 +157,9 @@ enum perf_branch_sample_type { >> PERF_SAMPLE_BRANCH_ANY_CALL = 1U << 4, /* any call branch */ >> PERF_SAMPLE_BRANCH_ANY_RETURN = 1U << 5, /* any return branch */ >> PERF_SAMPLE_BRANCH_IND_CALL = 1U << 6, /* indirect calls */ >> + PERF_SAMPLE_BRANCH_CONDITIONAL = 1U << 7, /* conditional branches */ >> >> - PERF_SAMPLE_BRANCH_MAX = 1U << 7, /* non-ABI */ >> + PERF_SAMPLE_BRANCH_MAX = 1U << 8, /* non-ABI */ >> }; >> >> #define PERF_SAMPLE_BRANCH_PLM_ALL \ >> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c >> index cdf58ec..5b0b89d 100644 >> --- a/tools/perf/builtin-record.c >> +++ b/tools/perf/builtin-record.c >> @@ -676,6 +676,7 @@ static const struct branch_mode branch_modes[] = { >> BRANCH_OPT("any_call", PERF_SAMPLE_BRANCH_ANY_CALL), >> BRANCH_OPT("any_ret", PERF_SAMPLE_BRANCH_ANY_RETURN), >> BRANCH_OPT("ind_call", PERF_SAMPLE_BRANCH_IND_CALL), >> + BRANCH_OPT("cnd", PERF_SAMPLE_BRANCH_CONDITIONAL), >> BRANCH_END >> }; >>
next prev parent reply other threads:[~2013-05-16 15:36 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-03 12:11 [PATCH 0/3] Various perf patches Peter Zijlstra 2013-05-03 12:11 ` [PATCH 1/3] perf, x86: Blacklist all MEM_*_RETIRED events for IVB Peter Zijlstra 2013-05-03 14:35 ` Andi Kleen 2013-05-03 17:00 ` Peter Zijlstra 2013-05-15 14:20 ` Stephane Eranian 2013-05-15 16:51 ` Peter Zijlstra 2013-05-16 15:42 ` Stephane Eranian 2013-05-16 16:07 ` Andi Kleen 2013-05-16 16:26 ` Stephane Eranian 2013-05-04 8:20 ` [tip:perf/urgent] perf/x86: Blacklist all MEM_*_RETIRED events for Ivy Bridge tip-bot for Peter Zijlstra 2013-05-03 12:11 ` [PATCH 2/3] perf, x86, lbr: Fix LBR filter Peter Zijlstra 2013-05-03 14:34 ` Andi Kleen 2013-05-04 6:34 ` Ingo Molnar 2013-05-04 8:21 ` [tip:perf/urgent] perf/x86/intel/lbr: " tip-bot for Peter Zijlstra 2013-05-03 12:11 ` [PATCH 3/3] perf, x86, lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL Peter Zijlstra 2013-05-03 14:41 ` Andi Kleen 2013-05-04 8:22 ` [tip:perf/urgent] perf/x86/intel/lbr: " tip-bot for Peter Zijlstra 2013-05-04 11:19 ` Borislav Petkov 2013-05-05 9:05 ` Ingo Molnar 2013-05-06 8:07 ` Peter Zijlstra 2013-05-06 9:42 ` Ingo Molnar 2013-05-15 13:37 ` [PATCH 3/3] perf, x86, lbr: " Stephane Eranian 2013-05-15 14:30 ` Peter Zijlstra 2013-05-16 9:09 ` Peter Zijlstra 2013-05-16 9:17 ` Peter Zijlstra 2013-05-16 10:09 ` Michael Neuling 2013-05-16 10:09 ` Michael Neuling 2013-05-16 10:15 ` Michael Neuling 2013-05-16 10:15 ` Michael Neuling 2013-05-16 11:16 ` Peter Zijlstra 2013-05-16 11:16 ` Peter Zijlstra 2013-05-16 15:36 ` Stephane Eranian [this message] 2013-05-16 15:36 ` Stephane Eranian 2013-05-17 11:12 ` Peter Zijlstra 2013-05-17 11:12 ` Peter Zijlstra 2013-05-17 11:32 ` Michael Neuling 2013-05-17 11:32 ` Michael Neuling 2013-05-17 11:39 ` Peter Zijlstra 2013-05-17 11:39 ` Peter Zijlstra 2013-05-17 21:39 ` Stephane Eranian 2013-05-17 21:39 ` Stephane Eranian 2013-05-17 22:14 ` Michael Neuling 2013-05-17 22:14 ` Michael Neuling 2013-05-17 22:59 ` Stephane Eranian 2013-05-17 22:59 ` Stephane Eranian 2013-05-21 5:41 ` Michael Neuling 2013-05-21 5:41 ` Michael Neuling 2013-05-21 8:50 ` Peter Zijlstra 2013-05-21 8:50 ` Peter Zijlstra 2013-05-21 13:46 ` Stephane Eranian 2013-05-21 13:46 ` Stephane Eranian 2013-05-21 13:55 ` Stephane Eranian 2013-05-21 13:55 ` Stephane Eranian 2013-05-22 6:43 ` Anshuman Khandual 2013-05-22 12:23 ` Stephane Eranian 2013-05-22 14:51 ` Anshuman Khandual
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CABPqkBSCXJN7gLK_e_Q3YVVVFVGS78fo4j2z0+MmriqoXszH+w@mail.gmail.com \ --to=eranian@google.com \ --cc=ak@linux.intel.com \ --cc=benh@kernel.crashing.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=michael@ellerman.id.au \ --cc=mikey@neuling.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.