From: Jassi Brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> Cc: Vincent Yang <vincent.cw.yang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>, "andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" <andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>, "arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" <arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "arnd-r2nGTMty4D4@public.gmane.org" <arnd-r2nGTMty4D4@public.gmane.org>, "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, "jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" <jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Tetsuya Nuriya <nuriya.tetsuya-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>, "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>, "patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" <patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>, Vincent Yang <vincent.yang-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> Subject: Re: [PATCH v7 2/7] mailbox: arm_mhu: add driver for ARM MHU controller Date: Wed, 18 Mar 2015 18:49:48 +0530 [thread overview] Message-ID: <CABb+yY0qRSocL-ePosUzszAh4X6161ve8_qUq4VizbLWMAmMCQ@mail.gmail.com> (raw) In-Reply-To: <55095297.5060605-5wv7dgnIgG8@public.gmane.org> On Wed, Mar 18, 2015 at 3:55 PM, Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> wrote: > >> +static int mhu_send_data(struct mbox_chan *chan, void *data) >> +{ >> + struct mhu_link *mlink = chan->con_priv; >> + u32 *arg = data; > > Arnd doesn't like this and had suggestions in some other thread. > No, Arnd suggested doing it this way. And another platform's driver was made to do this way. >> + writel_relaxed(*arg, mlink->tx_reg + INTR_SET_OFS); >> + >> + return 0; >> +} >> + >> +static int mhu_startup(struct mbox_chan *chan) >> +{ >> + struct mhu_link *mlink = chan->con_priv; >> + u32 val; >> + int ret; >> + >> + val = readl_relaxed(mlink->tx_reg + INTR_STAT_OFS); >> + writel_relaxed(val, mlink->tx_reg + INTR_CLR_OFS); >> + >> + ret = request_irq(mlink->irq, mhu_rx_interrupt, >> + IRQF_SHARED, "mhu_link", chan); > > > Any reason we can't move this to probe and have {en,dis}able_irq here if > needed. I has seen it was too heavy to have these especially when > sending small packets. > I see you used to do memcpy in irq-handler https://git.linaro.org/landing-teams/working/arm/kernel.git/blob/HEAD:/drivers/mailbox/arm_mhu.c perhaps you were using your old driver? If you use this new driver, and send packets so often that request-release irq has effect, maybe should hold the mailbox reference for lifetime. I remember suggesting you that already and I remember you said that's how it was. -Jassi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 2/7] mailbox: arm_mhu: add driver for ARM MHU controller Date: Wed, 18 Mar 2015 18:49:48 +0530 [thread overview] Message-ID: <CABb+yY0qRSocL-ePosUzszAh4X6161ve8_qUq4VizbLWMAmMCQ@mail.gmail.com> (raw) In-Reply-To: <55095297.5060605@arm.com> On Wed, Mar 18, 2015 at 3:55 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > >> +static int mhu_send_data(struct mbox_chan *chan, void *data) >> +{ >> + struct mhu_link *mlink = chan->con_priv; >> + u32 *arg = data; > > Arnd doesn't like this and had suggestions in some other thread. > No, Arnd suggested doing it this way. And another platform's driver was made to do this way. >> + writel_relaxed(*arg, mlink->tx_reg + INTR_SET_OFS); >> + >> + return 0; >> +} >> + >> +static int mhu_startup(struct mbox_chan *chan) >> +{ >> + struct mhu_link *mlink = chan->con_priv; >> + u32 val; >> + int ret; >> + >> + val = readl_relaxed(mlink->tx_reg + INTR_STAT_OFS); >> + writel_relaxed(val, mlink->tx_reg + INTR_CLR_OFS); >> + >> + ret = request_irq(mlink->irq, mhu_rx_interrupt, >> + IRQF_SHARED, "mhu_link", chan); > > > Any reason we can't move this to probe and have {en,dis}able_irq here if > needed. I has seen it was too heavy to have these especially when > sending small packets. > I see you used to do memcpy in irq-handler https://git.linaro.org/landing-teams/working/arm/kernel.git/blob/HEAD:/drivers/mailbox/arm_mhu.c perhaps you were using your old driver? If you use this new driver, and send packets so often that request-release irq has effect, maybe should hold the mailbox reference for lifetime. I remember suggesting you that already and I remember you said that's how it was. -Jassi
next prev parent reply other threads:[~2015-03-18 13:19 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-04 10:52 [PATCH v7 0/7] Support for Fujitsu MB86S7X SoCs Vincent Yang 2015-03-04 10:52 ` Vincent Yang 2015-03-04 11:02 ` [PATCH v7 3/7] ARM: MB86S7X: Add MCPM support Vincent Yang [not found] ` <1425466367-30556-1-git-send-email-vincent.yang-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> 2015-03-04 10:58 ` [PATCH v7 1/7] ARM: Add platform support for Fujitsu MB86S7X SoCs Vincent Yang 2015-03-04 10:58 ` Vincent Yang 2015-03-04 11:01 ` [PATCH v7 2/7] mailbox: arm_mhu: add driver for ARM MHU controller Vincent Yang 2015-03-04 11:01 ` Vincent Yang [not found] ` <1425466884-30648-1-git-send-email-vincent.yang-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> 2015-03-18 9:57 ` Sudeep Holla 2015-03-18 9:57 ` Sudeep Holla [not found] ` <55094BEF.9060006-5wv7dgnIgG8@public.gmane.org> 2015-03-18 12:56 ` Jassi Brar 2015-03-18 12:56 ` Jassi Brar [not found] ` <CABb+yY2woK6qWbrgPGRBRXJqJdf=1HxE_-Am-SY1_Uf_dNgTew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-03-18 14:08 ` Sudeep Holla 2015-03-18 14:08 ` Sudeep Holla 2015-03-18 10:25 ` Sudeep Holla 2015-03-18 10:25 ` Sudeep Holla [not found] ` <55095297.5060605-5wv7dgnIgG8@public.gmane.org> 2015-03-18 13:19 ` Jassi Brar [this message] 2015-03-18 13:19 ` Jassi Brar [not found] ` <CABb+yY0qRSocL-ePosUzszAh4X6161ve8_qUq4VizbLWMAmMCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-03-18 14:23 ` Sudeep Holla 2015-03-18 14:23 ` Sudeep Holla 2015-03-26 11:43 ` Sudeep Holla 2015-03-26 11:43 ` Sudeep Holla [not found] ` <5513F0D9.5080807-5wv7dgnIgG8@public.gmane.org> 2015-03-26 11:49 ` Russell King - ARM Linux 2015-03-26 11:49 ` Russell King - ARM Linux [not found] ` <20150326114955.GE8656-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2015-03-26 11:58 ` Sudeep Holla 2015-03-26 11:58 ` Sudeep Holla 2015-03-04 11:04 ` [PATCH v7 4/7] clk: Add clock driver for mb86s7x Vincent Yang 2015-03-04 11:04 ` Vincent Yang [not found] ` <1425467043-30733-1-git-send-email-vincent.yang-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> 2015-04-10 20:52 ` Michael Turquette 2015-04-10 20:52 ` Michael Turquette 2015-03-04 11:05 ` [PATCH v7 5/7] dt: mb86s7x: add dt files for MB86S7x evbs Vincent Yang 2015-03-04 11:05 ` Vincent Yang 2015-03-04 11:07 ` [PATCH v7 6/7] of: add Fujitsu vendor prefix Vincent Yang 2015-03-04 11:07 ` Vincent Yang 2015-03-04 11:08 ` [PATCH v7 7/7] ARM: MB86S7x: Add configs Vincent Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CABb+yY0qRSocL-ePosUzszAh4X6161ve8_qUq4VizbLWMAmMCQ@mail.gmail.com \ --to=jassisinghbrar-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=Mark.Rutland-5wv7dgnIgG8@public.gmane.org \ --cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \ --cc=andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=arnd-r2nGTMty4D4@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \ --cc=jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \ --cc=nuriya.tetsuya-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \ --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \ --cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \ --cc=vincent.cw.yang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=vincent.yang-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.