All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Perier <romain.perier@gmail.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] rtc: msc313: Select by default on MSTARV7
Date: Mon, 3 Jan 2022 15:13:05 +0100	[thread overview]
Message-ID: <CABgxDoKMNcYzPH6mcO0yfJhpK2kRZR5BK=p5H1YvVqJGjbynDg@mail.gmail.com> (raw)
In-Reply-To: <20211230044027.2739732-1-daniel@0x0f.com>

Hi,

Le jeu. 30 déc. 2021 à 05:40, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> All of the ARCH_MSTARV7 chips have this RTC so it's more likey
> ARCH_MSTARV7 wants it than doesn't.
>
> At the same time fix up the indent on the depends on line that looks
> like it got converted from a tab to spaces at some point.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
>  drivers/rtc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 058e56a10ab8..9acd4ea267df 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC
>
>  config RTC_DRV_MSC313
>         tristate "MStar MSC313 RTC"
> -        depends on ARCH_MSTARV7 || COMPILE_TEST
> +       depends on ARCH_MSTARV7 || COMPILE_TEST
> +       default ARCH_MSTARV7

You still depend on ARCH_MSTARV7 so "default y" is enough. It
will only work if the dependencies are satisfied and, when it is the
case, the value can be overridden by the user.

Cheers,
Romain

WARNING: multiple messages have this Message-ID (diff)
From: Romain Perier <romain.perier@gmail.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 linux-rtc@vger.kernel.org,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] rtc: msc313: Select by default on MSTARV7
Date: Mon, 3 Jan 2022 15:13:05 +0100	[thread overview]
Message-ID: <CABgxDoKMNcYzPH6mcO0yfJhpK2kRZR5BK=p5H1YvVqJGjbynDg@mail.gmail.com> (raw)
In-Reply-To: <20211230044027.2739732-1-daniel@0x0f.com>

Hi,

Le jeu. 30 déc. 2021 à 05:40, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> All of the ARCH_MSTARV7 chips have this RTC so it's more likey
> ARCH_MSTARV7 wants it than doesn't.
>
> At the same time fix up the indent on the depends on line that looks
> like it got converted from a tab to spaces at some point.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
>  drivers/rtc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 058e56a10ab8..9acd4ea267df 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC
>
>  config RTC_DRV_MSC313
>         tristate "MStar MSC313 RTC"
> -        depends on ARCH_MSTARV7 || COMPILE_TEST
> +       depends on ARCH_MSTARV7 || COMPILE_TEST
> +       default ARCH_MSTARV7

You still depend on ARCH_MSTARV7 so "default y" is enough. It
will only work if the dependencies are satisfied and, when it is the
case, the value can be overridden by the user.

Cheers,
Romain

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-03 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30  4:40 [PATCH] rtc: msc313: Select by default on MSTARV7 Daniel Palmer
2021-12-30  4:40 ` Daniel Palmer
2022-01-03 14:13 ` Romain Perier [this message]
2022-01-03 14:13   ` Romain Perier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgxDoKMNcYzPH6mcO0yfJhpK2kRZR5BK=p5H1YvVqJGjbynDg@mail.gmail.com' \
    --to=romain.perier@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=daniel@0x0f.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.