* [PATCH] rtc: msc313: Select by default on MSTARV7
@ 2021-12-30 4:40 ` Daniel Palmer
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Palmer @ 2021-12-30 4:40 UTC (permalink / raw)
To: a.zummo, alexandre.belloni, linux-rtc
Cc: linux-kernel, linux-arm-kernel, romain.perier, Daniel Palmer
All of the ARCH_MSTARV7 chips have this RTC so it's more likey
ARCH_MSTARV7 wants it than doesn't.
At the same time fix up the indent on the depends on line that looks
like it got converted from a tab to spaces at some point.
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
drivers/rtc/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 058e56a10ab8..9acd4ea267df 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC
config RTC_DRV_MSC313
tristate "MStar MSC313 RTC"
- depends on ARCH_MSTARV7 || COMPILE_TEST
+ depends on ARCH_MSTARV7 || COMPILE_TEST
+ default ARCH_MSTARV7
help
If you say yes here you get support for the Mstar MSC313e On-Chip
Real Time Clock.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] rtc: msc313: Select by default on MSTARV7
@ 2021-12-30 4:40 ` Daniel Palmer
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Palmer @ 2021-12-30 4:40 UTC (permalink / raw)
To: a.zummo, alexandre.belloni, linux-rtc
Cc: linux-kernel, linux-arm-kernel, romain.perier, Daniel Palmer
All of the ARCH_MSTARV7 chips have this RTC so it's more likey
ARCH_MSTARV7 wants it than doesn't.
At the same time fix up the indent on the depends on line that looks
like it got converted from a tab to spaces at some point.
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
drivers/rtc/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 058e56a10ab8..9acd4ea267df 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC
config RTC_DRV_MSC313
tristate "MStar MSC313 RTC"
- depends on ARCH_MSTARV7 || COMPILE_TEST
+ depends on ARCH_MSTARV7 || COMPILE_TEST
+ default ARCH_MSTARV7
help
If you say yes here you get support for the Mstar MSC313e On-Chip
Real Time Clock.
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rtc: msc313: Select by default on MSTARV7
2021-12-30 4:40 ` Daniel Palmer
@ 2022-01-03 14:13 ` Romain Perier
-1 siblings, 0 replies; 4+ messages in thread
From: Romain Perier @ 2022-01-03 14:13 UTC (permalink / raw)
To: Daniel Palmer
Cc: Alessandro Zummo, Alexandre Belloni, linux-rtc,
Linux Kernel Mailing List, linux-arm-kernel
Hi,
Le jeu. 30 déc. 2021 à 05:40, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> All of the ARCH_MSTARV7 chips have this RTC so it's more likey
> ARCH_MSTARV7 wants it than doesn't.
>
> At the same time fix up the indent on the depends on line that looks
> like it got converted from a tab to spaces at some point.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
> drivers/rtc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 058e56a10ab8..9acd4ea267df 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC
>
> config RTC_DRV_MSC313
> tristate "MStar MSC313 RTC"
> - depends on ARCH_MSTARV7 || COMPILE_TEST
> + depends on ARCH_MSTARV7 || COMPILE_TEST
> + default ARCH_MSTARV7
You still depend on ARCH_MSTARV7 so "default y" is enough. It
will only work if the dependencies are satisfied and, when it is the
case, the value can be overridden by the user.
Cheers,
Romain
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtc: msc313: Select by default on MSTARV7
@ 2022-01-03 14:13 ` Romain Perier
0 siblings, 0 replies; 4+ messages in thread
From: Romain Perier @ 2022-01-03 14:13 UTC (permalink / raw)
To: Daniel Palmer
Cc: Alessandro Zummo, Alexandre Belloni, linux-rtc,
Linux Kernel Mailing List, linux-arm-kernel
Hi,
Le jeu. 30 déc. 2021 à 05:40, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> All of the ARCH_MSTARV7 chips have this RTC so it's more likey
> ARCH_MSTARV7 wants it than doesn't.
>
> At the same time fix up the indent on the depends on line that looks
> like it got converted from a tab to spaces at some point.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
> drivers/rtc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 058e56a10ab8..9acd4ea267df 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1924,7 +1924,8 @@ config RTC_DRV_WILCO_EC
>
> config RTC_DRV_MSC313
> tristate "MStar MSC313 RTC"
> - depends on ARCH_MSTARV7 || COMPILE_TEST
> + depends on ARCH_MSTARV7 || COMPILE_TEST
> + default ARCH_MSTARV7
You still depend on ARCH_MSTARV7 so "default y" is enough. It
will only work if the dependencies are satisfied and, when it is the
case, the value can be overridden by the user.
Cheers,
Romain
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-03 14:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 4:40 [PATCH] rtc: msc313: Select by default on MSTARV7 Daniel Palmer
2021-12-30 4:40 ` Daniel Palmer
2022-01-03 14:13 ` Romain Perier
2022-01-03 14:13 ` Romain Perier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.