All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Perier <romain.perier@gmail.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-rtc@vger.kernel.org, DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] ARM: dts: mstar: Add rtc device node
Date: Thu, 19 Aug 2021 18:22:29 +0200	[thread overview]
Message-ID: <CABgxDoL0sQH4MRBA-1hJtXkNaphnKu7fbW9C++vEQSX4F6Q1yQ@mail.gmail.com> (raw)
In-Reply-To: <CAFr9PXmqiu=toGf9DjoH8XMbPaiXaWLV=GsmR7OCkkqix5tRvw@mail.gmail.com>

Hi,

As I need to send a v3, I can fix it, no worries.

Cheers,
Romain

Le lun. 2 août 2021 à 12:40, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> Hi Romain,
>
> On Mon, 2 Aug 2021 at 01:09, Romain Perier <romain.perier@gmail.com> wrote:
> > +++ b/arch/arm/boot/dts/mstar-v7.dtsi
> > @@ -116,6 +116,13 @@ watchdog@6000 {
> >                                 clocks = <&xtal_div2>;
> >                         };
> >
> > +                       rtc@2400 {
>
> I think the rtc should be before the watchdog as the address is lower.
> I think maybe this got flipped around during cherry-picking.
> I can flip it around when I pull this into an mstar dts for 5.15
> branch so you don't need to fix it and send a v3 assuming everything
> else is ok.
>
> Thanks,
>
> Daniel

WARNING: multiple messages have this Message-ID (diff)
From: Romain Perier <romain.perier@gmail.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Rob Herring <robh+dt@kernel.org>,
	linux-rtc@vger.kernel.org,  DTML <devicetree@vger.kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] ARM: dts: mstar: Add rtc device node
Date: Thu, 19 Aug 2021 18:22:29 +0200	[thread overview]
Message-ID: <CABgxDoL0sQH4MRBA-1hJtXkNaphnKu7fbW9C++vEQSX4F6Q1yQ@mail.gmail.com> (raw)
In-Reply-To: <CAFr9PXmqiu=toGf9DjoH8XMbPaiXaWLV=GsmR7OCkkqix5tRvw@mail.gmail.com>

Hi,

As I need to send a v3, I can fix it, no worries.

Cheers,
Romain

Le lun. 2 août 2021 à 12:40, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> Hi Romain,
>
> On Mon, 2 Aug 2021 at 01:09, Romain Perier <romain.perier@gmail.com> wrote:
> > +++ b/arch/arm/boot/dts/mstar-v7.dtsi
> > @@ -116,6 +116,13 @@ watchdog@6000 {
> >                                 clocks = <&xtal_div2>;
> >                         };
> >
> > +                       rtc@2400 {
>
> I think the rtc should be before the watchdog as the address is lower.
> I think maybe this got flipped around during cherry-picking.
> I can flip it around when I pull this into an mstar dts for 5.15
> branch so you don't need to fix it and send a v3 assuming everything
> else is ok.
>
> Thanks,
>
> Daniel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-19 16:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 16:09 [PATCH v2 0/3] Add RTC for MStar SoCs Romain Perier
2021-08-01 16:09 ` Romain Perier
2021-08-01 16:09 ` [PATCH v2 1/3] dt-bindings: rtc: Add Mstar MSC313e RTC devicetree bindings documentation Romain Perier
2021-08-01 16:09   ` Romain Perier
2021-08-06 21:37   ` Rob Herring
2021-08-06 21:37     ` Rob Herring
2021-08-19 16:24     ` Romain Perier
2021-08-19 16:24       ` Romain Perier
2021-08-01 16:09 ` [PATCH v2 2/3] rtc: Add support for the MSTAR MSC313 RTC Romain Perier
2021-08-01 16:09   ` Romain Perier
2021-08-06 19:38   ` Alexandre Belloni
2021-08-06 19:38     ` Alexandre Belloni
2021-08-19 16:55     ` Romain Perier
2021-08-19 16:55       ` Romain Perier
2021-08-01 16:09 ` [PATCH v2 3/3] ARM: dts: mstar: Add rtc device node Romain Perier
2021-08-01 16:09   ` Romain Perier
2021-08-02 10:39   ` Daniel Palmer
2021-08-02 10:39     ` Daniel Palmer
2021-08-19 16:22     ` Romain Perier [this message]
2021-08-19 16:22       ` Romain Perier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABgxDoL0sQH4MRBA-1hJtXkNaphnKu7fbW9C++vEQSX4F6Q1yQ@mail.gmail.com \
    --to=romain.perier@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.