From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Romain Perier <romain.perier@gmail.com> Cc: Alessandro Zummo <a.zummo@towertech.it>, Daniel Palmer <daniel@0x0f.com>, Rob Herring <robh+dt@kernel.org>, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] rtc: Add support for the MSTAR MSC313 RTC Date: Fri, 6 Aug 2021 21:38:03 +0200 [thread overview] Message-ID: <YQ2Pm7nrEFmdS6Ky@piout.net> (raw) In-Reply-To: <20210801160921.233081-3-romain.perier@gmail.com> Hello, On 01/08/2021 18:09:20+0200, Romain Perier wrote: > +static int msc313_rtc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct msc313_rtc *priv; > + int ret; > + int irq; > + unsigned long rate; > + u16 reg; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(struct msc313_rtc), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->rtc_base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(priv->rtc_base)) > + return PTR_ERR(priv->rtc_base); > + > + irq = platform_get_irq(pdev, 0); > + if (irq < 0) > + return -EINVAL; > + > + priv->rtc_dev = devm_rtc_allocate_device(dev); > + if (IS_ERR(priv->rtc_dev)) > + return PTR_ERR(priv->rtc_dev); > + > + priv->rtc_dev->ops = &msc313_rtc_ops; > + priv->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_0000; I'm pretty sure this doesn't fit in this RTC registers, you should probably leave range_min to 0 (i.e. not set it at all). > + priv->rtc_dev->range_max = U32_MAX - 1; /* 2106-02-07 06:28:14 */ I guess this one should be U32_MAX > + > + ret = devm_request_irq(dev, irq, msc313_rtc_interrupt, IRQF_SHARED, > + dev_name(&pdev->dev), &pdev->dev); > + if (ret) { > + dev_err(dev, "Could not request IRQ\n"); > + return ret; > + } > + > + priv->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(priv->clk)) { > + dev_err(dev, "No input reference clock\n"); > + return PTR_ERR(priv->clk); > + } > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) { > + dev_err(dev, "Failed to enable the reference clock, %d\n", ret); > + return ret; > + } > + > + ret = devm_add_action_or_reset(dev, (void (*) (void *))clk_disable_unprepare, priv->clk); > + if (ret) > + return ret; > + > + rate = clk_get_rate(priv->clk); > + writew(rate & 0xFFFF, priv->rtc_base + REG_RTC_FREQ_CW_L); > + writew((rate >> 16) & 0xFFFF, priv->rtc_base + REG_RTC_FREQ_CW_H); > + > + reg = readw(priv->rtc_base + REG_RTC_CTRL); > + reg |= CNT_EN_BIT; > + writew(reg, priv->rtc_base + REG_RTC_CTRL); > + If on POR, CNT_EN_BIT is not set, then it would be nice to use that to know whether the RTC is properly set. You can then check CNT_EN_BIT in .read_time and return -EINVAL if it is not set. Then you can set the bit in .set_time. It is anyway useless to let the RTC running if it is not set. > + platform_set_drvdata(pdev, priv); > + > + return devm_rtc_register_device(priv->rtc_dev); > +} > + > +static const struct of_device_id msc313_rtc_of_match_table[] = { > + { .compatible = "mstar,msc313-rtc" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ms_rtc_of_match_table); > + > +static struct platform_driver msc313_rtc_driver = { > + .probe = msc313_rtc_probe, > + .driver = { > + .name = "msc313-rtc", > + .of_match_table = msc313_rtc_of_match_table, > + }, > +}; > + > +module_platform_driver(msc313_rtc_driver); > + > +MODULE_AUTHOR("Daniel Palmer <daniel@thingy.jp>"); > +MODULE_AUTHOR("Romain Perier <romain.perier@gmail.com>"); > +MODULE_DESCRIPTION("MStar RTC Driver"); > +MODULE_LICENSE("GPL v2"); > -- > 2.30.2 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Romain Perier <romain.perier@gmail.com> Cc: Alessandro Zummo <a.zummo@towertech.it>, Daniel Palmer <daniel@0x0f.com>, Rob Herring <robh+dt@kernel.org>, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] rtc: Add support for the MSTAR MSC313 RTC Date: Fri, 6 Aug 2021 21:38:03 +0200 [thread overview] Message-ID: <YQ2Pm7nrEFmdS6Ky@piout.net> (raw) In-Reply-To: <20210801160921.233081-3-romain.perier@gmail.com> Hello, On 01/08/2021 18:09:20+0200, Romain Perier wrote: > +static int msc313_rtc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct msc313_rtc *priv; > + int ret; > + int irq; > + unsigned long rate; > + u16 reg; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(struct msc313_rtc), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->rtc_base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(priv->rtc_base)) > + return PTR_ERR(priv->rtc_base); > + > + irq = platform_get_irq(pdev, 0); > + if (irq < 0) > + return -EINVAL; > + > + priv->rtc_dev = devm_rtc_allocate_device(dev); > + if (IS_ERR(priv->rtc_dev)) > + return PTR_ERR(priv->rtc_dev); > + > + priv->rtc_dev->ops = &msc313_rtc_ops; > + priv->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_0000; I'm pretty sure this doesn't fit in this RTC registers, you should probably leave range_min to 0 (i.e. not set it at all). > + priv->rtc_dev->range_max = U32_MAX - 1; /* 2106-02-07 06:28:14 */ I guess this one should be U32_MAX > + > + ret = devm_request_irq(dev, irq, msc313_rtc_interrupt, IRQF_SHARED, > + dev_name(&pdev->dev), &pdev->dev); > + if (ret) { > + dev_err(dev, "Could not request IRQ\n"); > + return ret; > + } > + > + priv->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(priv->clk)) { > + dev_err(dev, "No input reference clock\n"); > + return PTR_ERR(priv->clk); > + } > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) { > + dev_err(dev, "Failed to enable the reference clock, %d\n", ret); > + return ret; > + } > + > + ret = devm_add_action_or_reset(dev, (void (*) (void *))clk_disable_unprepare, priv->clk); > + if (ret) > + return ret; > + > + rate = clk_get_rate(priv->clk); > + writew(rate & 0xFFFF, priv->rtc_base + REG_RTC_FREQ_CW_L); > + writew((rate >> 16) & 0xFFFF, priv->rtc_base + REG_RTC_FREQ_CW_H); > + > + reg = readw(priv->rtc_base + REG_RTC_CTRL); > + reg |= CNT_EN_BIT; > + writew(reg, priv->rtc_base + REG_RTC_CTRL); > + If on POR, CNT_EN_BIT is not set, then it would be nice to use that to know whether the RTC is properly set. You can then check CNT_EN_BIT in .read_time and return -EINVAL if it is not set. Then you can set the bit in .set_time. It is anyway useless to let the RTC running if it is not set. > + platform_set_drvdata(pdev, priv); > + > + return devm_rtc_register_device(priv->rtc_dev); > +} > + > +static const struct of_device_id msc313_rtc_of_match_table[] = { > + { .compatible = "mstar,msc313-rtc" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ms_rtc_of_match_table); > + > +static struct platform_driver msc313_rtc_driver = { > + .probe = msc313_rtc_probe, > + .driver = { > + .name = "msc313-rtc", > + .of_match_table = msc313_rtc_of_match_table, > + }, > +}; > + > +module_platform_driver(msc313_rtc_driver); > + > +MODULE_AUTHOR("Daniel Palmer <daniel@thingy.jp>"); > +MODULE_AUTHOR("Romain Perier <romain.perier@gmail.com>"); > +MODULE_DESCRIPTION("MStar RTC Driver"); > +MODULE_LICENSE("GPL v2"); > -- > 2.30.2 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-06 19:38 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-01 16:09 [PATCH v2 0/3] Add RTC for MStar SoCs Romain Perier 2021-08-01 16:09 ` Romain Perier 2021-08-01 16:09 ` [PATCH v2 1/3] dt-bindings: rtc: Add Mstar MSC313e RTC devicetree bindings documentation Romain Perier 2021-08-01 16:09 ` Romain Perier 2021-08-06 21:37 ` Rob Herring 2021-08-06 21:37 ` Rob Herring 2021-08-19 16:24 ` Romain Perier 2021-08-19 16:24 ` Romain Perier 2021-08-01 16:09 ` [PATCH v2 2/3] rtc: Add support for the MSTAR MSC313 RTC Romain Perier 2021-08-01 16:09 ` Romain Perier 2021-08-06 19:38 ` Alexandre Belloni [this message] 2021-08-06 19:38 ` Alexandre Belloni 2021-08-19 16:55 ` Romain Perier 2021-08-19 16:55 ` Romain Perier 2021-08-01 16:09 ` [PATCH v2 3/3] ARM: dts: mstar: Add rtc device node Romain Perier 2021-08-01 16:09 ` Romain Perier 2021-08-02 10:39 ` Daniel Palmer 2021-08-02 10:39 ` Daniel Palmer 2021-08-19 16:22 ` Romain Perier 2021-08-19 16:22 ` Romain Perier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YQ2Pm7nrEFmdS6Ky@piout.net \ --to=alexandre.belloni@bootlin.com \ --cc=a.zummo@towertech.it \ --cc=daniel@0x0f.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=romain.perier@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.