* [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout
@ 2016-09-13 10:08 tang.junhui
2016-10-11 6:42 ` tang.junhui
0 siblings, 1 reply; 3+ messages in thread
From: tang.junhui @ 2016-09-13 10:08 UTC (permalink / raw)
To: christophe varoqui; +Cc: zhang.kai16, dm-devel, tang.junhui
From: "tang.junhui" <tang.junhui@zte.com.cn>
uxsock_timeout should be assigned by conf->uxsock_timeout
before using it in uxclnt() as a CLI client timeout value,
otherwise its default value is 0, and the CLI client timeout
value is 0 + 100(ms), so the CLI client will be timeout very
quickly.
Signed-off-by: tang.junhui <tang.junhui@zte.com.cn>
---
multipathd/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/multipathd/main.c b/multipathd/main.c
index 96ef01f..a08f1a5 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2549,6 +2549,7 @@ main (int argc, char *argv[])
exit(1);
if (verbosity)
conf->verbosity = verbosity;
+ uxsock_timeout = conf->uxsock_timeout;
uxclnt(optarg, uxsock_timeout + 100);
exit(0);
case 'B':
@@ -2573,6 +2574,7 @@ main (int argc, char *argv[])
exit(1);
if (verbosity)
conf->verbosity = verbosity;
+ uxsock_timeout = conf->uxsock_timeout;
memset(cmd, 0x0, CMDSIZE);
while (optind < argc) {
if (strchr(argv[optind], ' '))
--
2.8.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout
2016-09-13 10:08 [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout tang.junhui
@ 2016-10-11 6:42 ` tang.junhui
2016-10-11 6:45 ` Christophe Varoqui
0 siblings, 1 reply; 3+ messages in thread
From: tang.junhui @ 2016-10-11 6:42 UTC (permalink / raw)
To: christophe.varoqui; +Cc: bart.vanassche, dm-devel, tang.junhui, zhang.kai16
[-- Attachment #1.1: Type: text/plain, Size: 2172 bytes --]
Please have a review for this patch, any comment will be highly
appreciated.
发件人: tang.junhui@zte.com.cn
收件人: christophe varoqui <christophe.varoqui@free.fr>,
抄送: zhang.kai16@zte.com.cn, dm-devel@redhat.com, "tang.junhui"
<tang.junhui@zte.com.cn>
日期: 2016/09/13 18:17
主题: [dm-devel] [PATCH] multipathd: uxsock_timeout should be assigned
by conf->uxsock_timeout
发件人: dm-devel-bounces@redhat.com
From: "tang.junhui" <tang.junhui@zte.com.cn>
uxsock_timeout should be assigned by conf->uxsock_timeout
before using it in uxclnt() as a CLI client timeout value,
otherwise its default value is 0, and the CLI client timeout
value is 0 + 100(ms), so the CLI client will be timeout very
quickly.
Signed-off-by: tang.junhui <tang.junhui@zte.com.cn>
---
multipathd/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/multipathd/main.c b/multipathd/main.c
index 96ef01f..a08f1a5 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2549,6 +2549,7 @@ main (int argc, char *argv[])
exit(1);
if (verbosity)
conf->verbosity = verbosity;
+ uxsock_timeout =
conf->uxsock_timeout;
uxclnt(optarg,
uxsock_timeout + 100);
exit(0);
case 'B':
@@ -2573,6 +2574,7 @@ main (int argc, char *argv[])
exit(1);
if (verbosity)
conf->verbosity =
verbosity;
+ uxsock_timeout = conf->uxsock_timeout;
memset(cmd, 0x0, CMDSIZE);
while (optind < argc) {
if (strchr(argv[optind],
' '))
--
2.8.1.windows.1
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
[-- Attachment #1.2: Type: text/html, Size: 5229 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout
2016-10-11 6:42 ` tang.junhui
@ 2016-10-11 6:45 ` Christophe Varoqui
0 siblings, 0 replies; 3+ messages in thread
From: Christophe Varoqui @ 2016-10-11 6:45 UTC (permalink / raw)
To: tang.junhui; +Cc: Bart Van Assche, device-mapper development, zhang.kai16
[-- Attachment #1.1: Type: text/plain, Size: 2396 bytes --]
Good,
Merged.
On Tue, Oct 11, 2016 at 8:42 AM, <tang.junhui@zte.com.cn> wrote:
> Please have a review for this patch, any comment will be highly
> appreciated.
>
>
>
>
> 发件人: tang.junhui@zte.com.cn
> 收件人: christophe varoqui <christophe.varoqui@free.fr>,
> 抄送: zhang.kai16@zte.com.cn, dm-devel@redhat.com, "tang.junhui" <
> tang.junhui@zte.com.cn>
> 日期: 2016/09/13 18:17
> 主题: [dm-devel] [PATCH] multipathd: uxsock_timeout should be
> assigned by conf->uxsock_timeout
> 发件人: dm-devel-bounces@redhat.com
> ------------------------------
>
>
>
> From: "tang.junhui" <tang.junhui@zte.com.cn>
>
> uxsock_timeout should be assigned by conf->uxsock_timeout
> before using it in uxclnt() as a CLI client timeout value,
> otherwise its default value is 0, and the CLI client timeout
> value is 0 + 100(ms), so the CLI client will be timeout very
> quickly.
>
> Signed-off-by: tang.junhui <tang.junhui@zte.com.cn>
> ---
> multipathd/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 96ef01f..a08f1a5 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2549,6 +2549,7 @@ main (int argc, char *argv[])
>
> exit(1);
> if (verbosity)
>
> conf->verbosity = verbosity;
> + uxsock_timeout =
> conf->uxsock_timeout;
> uxclnt(optarg,
> uxsock_timeout + 100);
> exit(0);
> case 'B':
> @@ -2573,6 +2574,7 @@ main (int argc, char *argv[])
> exit(1);
> if (verbosity)
> conf->verbosity =
> verbosity;
> + uxsock_timeout = conf->uxsock_timeout;
> memset(cmd, 0x0, CMDSIZE);
> while (optind < argc) {
> if
> (strchr(argv[optind], ' '))
> --
> 2.8.1.windows.1
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>
>
[-- Attachment #1.2: Type: text/html, Size: 4861 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-11 6:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 10:08 [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout tang.junhui
2016-10-11 6:42 ` tang.junhui
2016-10-11 6:45 ` Christophe Varoqui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.