All of lore.kernel.org
 help / color / mirror / Atom feed
* Potential NULL pointer deference in net: sched
@ 2019-10-07 21:08 Yizhuo Zhai
  2019-10-07 21:20 ` Eric Dumazet
  0 siblings, 1 reply; 2+ messages in thread
From: Yizhuo Zhai @ 2019-10-07 21:08 UTC (permalink / raw)
  To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, netdev, linux-kernel,
	Zhiyun Qian, Chengyu Song

Hi All:

net/sched/sch_mq.c:
Inside function mq_dump_class(), mq_queue_get() could return NULL,
however, the return value of dev_queue is not checked  and get used.
This could potentially be unsafe.


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Potential NULL pointer deference in net: sched
  2019-10-07 21:08 Potential NULL pointer deference in net: sched Yizhuo Zhai
@ 2019-10-07 21:20 ` Eric Dumazet
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2019-10-07 21:20 UTC (permalink / raw)
  To: Yizhuo Zhai, Jamal Hadi Salim, Cong Wang, Jiri Pirko, netdev,
	linux-kernel, Zhiyun Qian, Chengyu Song



On 10/7/19 2:08 PM, Yizhuo Zhai wrote:
> Hi All:
> 
> net/sched/sch_mq.c:
> Inside function mq_dump_class(), mq_queue_get() could return NULL,
> however, the return value of dev_queue is not checked  and get used.
> This could potentially be unsafe.
> 
> 

Not really.

mq_dump_class() is called by a layer that made sure the @cl argument
was not complete garbage.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-07 21:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07 21:08 Potential NULL pointer deference in net: sched Yizhuo Zhai
2019-10-07 21:20 ` Eric Dumazet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.