From: Bryton Lee <brytonlee01@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: iamjoonsoo.kim@lge.com, penberg@kernel.org, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"vger.linux-kernel.cn" <kernel@vger.linux-kernel.cn>
Subject: Re: [PATCH] mm: move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME to file linux/slab.h
Date: Wed, 7 Jan 2015 15:32:30 +0800 [thread overview]
Message-ID: <CAC2pzGd_p37Pi53ZEQShMj9BAECPXZCsxQwm=kKLACwmSBB99w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1501062114240.5674@gentwo.org>
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
thanks for review my patch.
I want to move these macros to linux/slab.h cause I don't want perform
merge in slab level. for example. ss read /proc/slabinfo to finger out
how many requests pending in the TCP listern queue. it use slabe name
"tcp_timewait_sock_ops" search in /proc/slabinfo, although the name is
obsolete. so I committed other patch to iproute2, replaced
tcp_timewait_sock_ops by request_sock_TCP, but it still not work, because
slab request_sock_TCP merge into kmalloc-256.
how could I prevent this merge happen. I'm new to kernel, this is my first
time submit a kernel patch, thanks!
On Wed, Jan 7, 2015 at 11:16 AM, Christoph Lameter <cl@linux.com> wrote:
> On Wed, 7 Jan 2015, Bryton Lee wrote:
>
> > move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME from file
> mm/slab_common.c
> > to file linux/slab.h.
> > let other kernel code create slab can use these flags.
>
> This does not make sense. The fact that a slab has been merged is
> available from a field in the kmem_cache structure (aliases).
>
>
> These two macros are criteria for the slab allocators to perform merges.
> The merge decision is the slab allocators decision and not the decision of
> other kernel code.
>
>
>
--
Best Regards
Bryton.Lee
[-- Attachment #2: Type: text/html, Size: 1748 bytes --]
next prev parent reply other threads:[~2015-01-07 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 2:01 [PATCH] mm: move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME to file linux/slab.h Bryton Lee
2015-01-07 3:16 ` Christoph Lameter
2015-01-07 3:16 ` Christoph Lameter
2015-01-07 7:32 ` Bryton Lee [this message]
2015-01-21 22:44 ` David Rientjes
2015-01-21 22:44 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC2pzGd_p37Pi53ZEQShMj9BAECPXZCsxQwm=kKLACwmSBB99w@mail.gmail.com' \
--to=brytonlee01@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel@vger.linux-kernel.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.