From: Christoph Lameter <cl@linux.com>
To: Bryton Lee <brytonlee01@gmail.com>
Cc: iamjoonsoo.kim@lge.com, penberg@kernel.org, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"vger.linux-kernel.cn" <kernel@vger.linux-kernel.cn>
Subject: Re: [PATCH] mm: move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME to file linux/slab.h
Date: Tue, 6 Jan 2015 21:16:51 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.11.1501062114240.5674@gentwo.org> (raw)
In-Reply-To: <CAC2pzGe9Q+19LpyFPwr8+TZ02XfCqwrQzsEsJA8WWB6XhuJyeQ@mail.gmail.com>
On Wed, 7 Jan 2015, Bryton Lee wrote:
> move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME from file mm/slab_common.c
> to file linux/slab.h.
> let other kernel code create slab can use these flags.
This does not make sense. The fact that a slab has been merged is
available from a field in the kmem_cache structure (aliases).
These two macros are criteria for the slab allocators to perform merges.
The merge decision is the slab allocators decision and not the decision of
other kernel code.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com>
To: Bryton Lee <brytonlee01@gmail.com>
Cc: iamjoonsoo.kim@lge.com, penberg@kernel.org, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"vger.linux-kernel.cn" <kernel@vger.linux-kernel.cn>
Subject: Re: [PATCH] mm: move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME to file linux/slab.h
Date: Tue, 6 Jan 2015 21:16:51 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.11.1501062114240.5674@gentwo.org> (raw)
In-Reply-To: <CAC2pzGe9Q+19LpyFPwr8+TZ02XfCqwrQzsEsJA8WWB6XhuJyeQ@mail.gmail.com>
On Wed, 7 Jan 2015, Bryton Lee wrote:
> move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME from file mm/slab_common.c
> to file linux/slab.h.
> let other kernel code create slab can use these flags.
This does not make sense. The fact that a slab has been merged is
available from a field in the kmem_cache structure (aliases).
These two macros are criteria for the slab allocators to perform merges.
The merge decision is the slab allocators decision and not the decision of
other kernel code.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-07 3:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 2:01 [PATCH] mm: move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME to file linux/slab.h Bryton Lee
2015-01-07 3:16 ` Christoph Lameter [this message]
2015-01-07 3:16 ` Christoph Lameter
2015-01-07 7:32 ` Bryton Lee
2015-01-21 22:44 ` David Rientjes
2015-01-21 22:44 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1501062114240.5674@gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=brytonlee01@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel@vger.linux-kernel.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.