All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: "Heitke, Kenneth" <kenneth.heitke@intel.com>
Cc: linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org,
	Keith Busch <keith.busch@intel.com>,
	Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Eduardo Valentin <edubezval@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/2] nvme: add thermal zone infrastructure
Date: Sat, 18 May 2019 00:01:57 +0900	[thread overview]
Message-ID: <CAC5umygRTpq3GktaMKBdC8+-ghkJKCzFME+rm+V6vasrOAyOPw@mail.gmail.com> (raw)
In-Reply-To: <2bf1e2cf-b922-d947-c939-375aba75994d@intel.com>

2019年5月17日(金) 6:22 Heitke, Kenneth <kenneth.heitke@intel.com>:
>
>
>
> On 5/15/2019 9:17 AM, Akinobu Mita wrote:
> > The NVMe controller reports up to nine temperature values in the SMART /
> > Health log page (the composite temperature and temperature sensor 1 through
> > temperature sensor 8).
> > The temperature threshold feature (Feature Identifier 04h) configures the
> > asynchronous event request command to complete when the temperature is
> > crossed its correspoinding temperature threshold.
>
> s/correspoinding/corresponding/

OK.

> > +
> > +static void nvme_thermal_init(struct nvme_ctrl *ctrl)
> > +{
> > +     INIT_WORK(&ctrl->thermal_work, nvme_thermal_work);
> > +}
>
> Does this work queue need to be destroyed at some point?

This is work_struct, not workqueue.  So it can't be destroyed.
But I noticed that we should call flush_work for thermal_work at
unregistering thermal zone devices.

WARNING: multiple messages have this Message-ID (diff)
From: akinobu.mita@gmail.com (Akinobu Mita)
Subject: [PATCH 1/2] nvme: add thermal zone infrastructure
Date: Sat, 18 May 2019 00:01:57 +0900	[thread overview]
Message-ID: <CAC5umygRTpq3GktaMKBdC8+-ghkJKCzFME+rm+V6vasrOAyOPw@mail.gmail.com> (raw)
In-Reply-To: <2bf1e2cf-b922-d947-c939-375aba75994d@intel.com>

2019?5?17?(?) 6:22 Heitke, Kenneth <kenneth.heitke at intel.com>:
>
>
>
> On 5/15/2019 9:17 AM, Akinobu Mita wrote:
> > The NVMe controller reports up to nine temperature values in the SMART /
> > Health log page (the composite temperature and temperature sensor 1 through
> > temperature sensor 8).
> > The temperature threshold feature (Feature Identifier 04h) configures the
> > asynchronous event request command to complete when the temperature is
> > crossed its correspoinding temperature threshold.
>
> s/correspoinding/corresponding/

OK.

> > +
> > +static void nvme_thermal_init(struct nvme_ctrl *ctrl)
> > +{
> > +     INIT_WORK(&ctrl->thermal_work, nvme_thermal_work);
> > +}
>
> Does this work queue need to be destroyed at some point?

This is work_struct, not workqueue.  So it can't be destroyed.
But I noticed that we should call flush_work for thermal_work at
unregistering thermal zone devices.

  reply	other threads:[~2019-05-17 15:02 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 15:17 [PATCH 0/2] nvme: add thermal zone devices Akinobu Mita
2019-05-15 15:17 ` Akinobu Mita
2019-05-15 15:17 ` [PATCH 1/2] nvme: add thermal zone infrastructure Akinobu Mita
2019-05-15 15:17   ` Akinobu Mita
2019-05-15 19:15   ` Keith Busch
2019-05-15 19:15     ` Keith Busch
2019-05-16 15:22     ` Akinobu Mita
2019-05-16 15:22       ` Akinobu Mita
2019-05-16 15:26       ` Keith Busch
2019-05-16 15:26         ` Keith Busch
2019-05-16 14:23   ` Minwoo Im
2019-05-16 14:23     ` Minwoo Im
2019-05-16 14:32   ` Minwoo Im
2019-05-16 14:32     ` Minwoo Im
2019-05-16 16:17     ` Akinobu Mita
2019-05-16 16:17       ` Akinobu Mita
2019-05-16 16:48       ` Minwoo Im
2019-05-16 16:48         ` Minwoo Im
2019-05-16 14:35   ` Akinobu Mita
2019-05-16 14:35     ` Akinobu Mita
2019-05-16 21:22   ` Heitke, Kenneth
2019-05-16 21:22     ` Heitke, Kenneth
2019-05-17 15:01     ` Akinobu Mita [this message]
2019-05-17 15:01       ` Akinobu Mita
2019-05-17 15:09       ` Keith Busch
2019-05-17 15:09         ` Keith Busch
2019-05-17 15:36         ` Akinobu Mita
2019-05-17 15:36           ` Akinobu Mita
2019-05-16 21:25   ` Heitke, Kenneth
2019-05-16 21:25     ` Heitke, Kenneth
2019-05-17 15:03     ` Akinobu Mita
2019-05-17 15:03       ` Akinobu Mita
2019-05-16 23:44   ` Chaitanya Kulkarni
2019-05-16 23:44     ` Chaitanya Kulkarni
2019-05-17 15:35     ` Akinobu Mita
2019-05-17 15:35       ` Akinobu Mita
2019-05-15 15:17 ` [PATCH 2/2] nvme-pci: support thermal zone Akinobu Mita
2019-05-15 15:17   ` Akinobu Mita
2019-05-15 17:03   ` Keith Busch
2019-05-15 17:03     ` Keith Busch
2019-05-16 14:30     ` Akinobu Mita
2019-05-16 14:30       ` Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC5umygRTpq3GktaMKBdC8+-ghkJKCzFME+rm+V6vasrOAyOPw@mail.gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=axboe@fb.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=kenneth.heitke@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.