All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org
Cc: Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 1/2] nvme: add thermal zone infrastructure
Date: Thu, 16 May 2019 23:35:55 +0900	[thread overview]
Message-ID: <CAC5umygg7BPhyoKsBDPAoafXHmJnqE1gEarafJDRCrdUnw-3aA@mail.gmail.com> (raw)
In-Reply-To: <1557933437-4693-2-git-send-email-akinobu.mita@gmail.com>

2019年5月16日(木) 0:17 Akinobu Mita <akinobu.mita@gmail.com>:
>
> The NVMe controller reports up to nine temperature values in the SMART /
> Health log page (the composite temperature and temperature sensor 1 through
> temperature sensor 8).
> The temperature threshold feature (Feature Identifier 04h) configures the
> asynchronous event request command to complete when the temperature is
> crossed its correspoinding temperature threshold.
>
> This adds infrastructure to provide these temperatures and thresholds via
> thermal zone devices.
>
> The nvme_thermal_zones_register() creates up to nine thermal zone devices
> for valid temperature sensors including composite temperature.
>
> /sys/class/thermal/thermal_zone[0-*]:
>     |---temp: Temperature
>     |---trip_point_0_temp: Over temperature threshold
>     |---trip_point_0_hyst: Under temperature threshold

I misunderstood the under temperature threshold.  It is not hysteresis
for the upper temperature threshold.  It is used to notify cold temperature
that the device may not correctly work.

So we should provide another trip point for under temperature threshold,
but there is no suitable thermal trip type for cold temperature.

I'm going to remove trip_point_0_hyst and not utilize the under temperature
threshold.

WARNING: multiple messages have this Message-ID (diff)
From: akinobu.mita@gmail.com (Akinobu Mita)
Subject: [PATCH 1/2] nvme: add thermal zone infrastructure
Date: Thu, 16 May 2019 23:35:55 +0900	[thread overview]
Message-ID: <CAC5umygg7BPhyoKsBDPAoafXHmJnqE1gEarafJDRCrdUnw-3aA@mail.gmail.com> (raw)
In-Reply-To: <1557933437-4693-2-git-send-email-akinobu.mita@gmail.com>

2019?5?16?(?) 0:17 Akinobu Mita <akinobu.mita at gmail.com>:
>
> The NVMe controller reports up to nine temperature values in the SMART /
> Health log page (the composite temperature and temperature sensor 1 through
> temperature sensor 8).
> The temperature threshold feature (Feature Identifier 04h) configures the
> asynchronous event request command to complete when the temperature is
> crossed its correspoinding temperature threshold.
>
> This adds infrastructure to provide these temperatures and thresholds via
> thermal zone devices.
>
> The nvme_thermal_zones_register() creates up to nine thermal zone devices
> for valid temperature sensors including composite temperature.
>
> /sys/class/thermal/thermal_zone[0-*]:
>     |---temp: Temperature
>     |---trip_point_0_temp: Over temperature threshold
>     |---trip_point_0_hyst: Under temperature threshold

I misunderstood the under temperature threshold.  It is not hysteresis
for the upper temperature threshold.  It is used to notify cold temperature
that the device may not correctly work.

So we should provide another trip point for under temperature threshold,
but there is no suitable thermal trip type for cold temperature.

I'm going to remove trip_point_0_hyst and not utilize the under temperature
threshold.

  parent reply	other threads:[~2019-05-16 14:36 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 15:17 [PATCH 0/2] nvme: add thermal zone devices Akinobu Mita
2019-05-15 15:17 ` Akinobu Mita
2019-05-15 15:17 ` [PATCH 1/2] nvme: add thermal zone infrastructure Akinobu Mita
2019-05-15 15:17   ` Akinobu Mita
2019-05-15 19:15   ` Keith Busch
2019-05-15 19:15     ` Keith Busch
2019-05-16 15:22     ` Akinobu Mita
2019-05-16 15:22       ` Akinobu Mita
2019-05-16 15:26       ` Keith Busch
2019-05-16 15:26         ` Keith Busch
2019-05-16 14:23   ` Minwoo Im
2019-05-16 14:23     ` Minwoo Im
2019-05-16 14:32   ` Minwoo Im
2019-05-16 14:32     ` Minwoo Im
2019-05-16 16:17     ` Akinobu Mita
2019-05-16 16:17       ` Akinobu Mita
2019-05-16 16:48       ` Minwoo Im
2019-05-16 16:48         ` Minwoo Im
2019-05-16 14:35   ` Akinobu Mita [this message]
2019-05-16 14:35     ` Akinobu Mita
2019-05-16 21:22   ` Heitke, Kenneth
2019-05-16 21:22     ` Heitke, Kenneth
2019-05-17 15:01     ` Akinobu Mita
2019-05-17 15:01       ` Akinobu Mita
2019-05-17 15:09       ` Keith Busch
2019-05-17 15:09         ` Keith Busch
2019-05-17 15:36         ` Akinobu Mita
2019-05-17 15:36           ` Akinobu Mita
2019-05-16 21:25   ` Heitke, Kenneth
2019-05-16 21:25     ` Heitke, Kenneth
2019-05-17 15:03     ` Akinobu Mita
2019-05-17 15:03       ` Akinobu Mita
2019-05-16 23:44   ` Chaitanya Kulkarni
2019-05-16 23:44     ` Chaitanya Kulkarni
2019-05-17 15:35     ` Akinobu Mita
2019-05-17 15:35       ` Akinobu Mita
2019-05-15 15:17 ` [PATCH 2/2] nvme-pci: support thermal zone Akinobu Mita
2019-05-15 15:17   ` Akinobu Mita
2019-05-15 17:03   ` Keith Busch
2019-05-15 17:03     ` Keith Busch
2019-05-16 14:30     ` Akinobu Mita
2019-05-16 14:30       ` Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC5umygg7BPhyoKsBDPAoafXHmJnqE1gEarafJDRCrdUnw-3aA@mail.gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=axboe@fb.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.