From: Akinobu Mita <akinobu.mita@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] fault-inject: use correct check for interrupts
Date: Sat, 25 Mar 2017 16:18:50 +0900 [thread overview]
Message-ID: <CAC5umyhuez=F1BQax=tos+5cKpE8rQ5hFc_eQGwP51mNpZ84rw@mail.gmail.com> (raw)
In-Reply-To: <20170321091805.140676-1-dvyukov@google.com>
2017-03-21 18:18 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:
> in_interrupt() also returns true when bh is disabled in task context.
> That's not what fail_task() wants to check.
> Use the new in_task() predicate that does the right thing.
>
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> Cc: akinobu.mita@gmail.com
> Cc: linux-kernel@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
This change looks good to me.
Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] fault-inject: use correct check for interrupts
Date: Sat, 25 Mar 2017 16:18:50 +0900 [thread overview]
Message-ID: <CAC5umyhuez=F1BQax=tos+5cKpE8rQ5hFc_eQGwP51mNpZ84rw@mail.gmail.com> (raw)
In-Reply-To: <20170321091805.140676-1-dvyukov@google.com>
2017-03-21 18:18 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:
> in_interrupt() also returns true when bh is disabled in task context.
> That's not what fail_task() wants to check.
> Use the new in_task() predicate that does the right thing.
>
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> Cc: akinobu.mita@gmail.com
> Cc: linux-kernel@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
This change looks good to me.
Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-25 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 9:18 [PATCH] fault-inject: use correct check for interrupts Dmitry Vyukov
2017-03-21 9:18 ` Dmitry Vyukov
2017-03-25 7:18 ` Akinobu Mita [this message]
2017-03-25 7:18 ` Akinobu Mita
2017-03-28 9:58 ` Dmitry Vyukov
2017-03-28 9:58 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5umyhuez=F1BQax=tos+5cKpE8rQ5hFc_eQGwP51mNpZ84rw@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.