[PATCH] fault-inject: use correct check for interrupts

* [PATCH] fault-inject: use correct check for interrupts
@ 2017-03-21  9:18 ` Dmitry Vyukov
  0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Vyukov @ 2017-03-21  9:18 UTC (permalink / raw)
  To: akinobu.mita, akpm; +Cc: Dmitry Vyukov, linux-kernel, linux-mm

in_interrupt() also returns true when bh is disabled in task context.
That's not what fail_task() wants to check.
Use the new in_task() predicate that does the right thing.

Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Cc: akinobu.mita@gmail.com
Cc: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org

---

Andrew, do you mind taking this to mm?
---
 lib/fault-inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fault-inject.c b/lib/fault-inject.c
index 6a823a53e357..4ff157159a0d 100644
--- a/lib/fault-inject.c
+++ b/lib/fault-inject.c
@@ -56,7 +56,7 @@ static void fail_dump(struct fault_attr *attr)
 
 static bool fail_task(struct fault_attr *attr, struct task_struct *task)
 {
-	return !in_interrupt() && task->make_it_fail;
+	return in_task() && task->make_it_fail;
 }
 
 #define MAX_STACK_TRACE_DEPTH 32
-- 
2.12.1.500.gab5fba24ee-goog

^ permalink raw reply related	[flat|nested] 6+ messages in thread