All of lore.kernel.org
 help / color / mirror / Atom feed
From: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Cousson, Benoit" <b-cousson@ti.com>,
	Paul Walmsley <paul@pwsan.com>, Kevin Hilman <khilman@ti.com>,
	Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
Date: Thu, 5 Jul 2012 17:11:27 +0530	[thread overview]
Message-ID: <CAC83ZvKO22JZ59VLdykEjRNDqK_FmGLtC=1y8OEfP88Ef9jBSA@mail.gmail.com> (raw)
In-Reply-To: <20120705092809.GY1122@atomide.com>

Hi Tony,

On Thu, Jul 5, 2012 at 2:58 PM, Tony Lindgren <tony@atomide.com> wrote:
> * DebBarma, Tarun Kanti <tarun.kanti@ti.com> [120704 21:07]:
>> On Thu, Jun 14, 2012 at 4:28 PM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote:
>> >
>> > Just to let you know that this cleanup is essential for Benoit's OMAP4
>> > hwmod cleanup
>> > and OMAP5 minimal support series.
>>
>> This is a gentle reminder in case you have missed somehow!!
>> Let me know if anything else needs to be done.
>
> Now with the hwmod patch 2/4 pulled into cleanup-part2 from Paul,
> I've also applied patch 1/4 there. Patches 3 and 4 have still some pending
> comments from Kevin it seems?
Yes....

>
> Also at least patch 3 won't apply, so please check Kevin's comments
> and repost patches 3 and 4 on top of cleanup-part2 at commit 74dd9ec62.
Patch 3: Comment was about adding summary in patch 0/x why we have
not removed iclk in OMAP2/3 platform. In other words there was no
specific changes needed on patch 3 as such. BTW, patch 3 is already merged.

Patch 4:
--- [Kevin's comment] ---
>>
>> Comment applies to PATCH 4/4 also.
> You mean removing iclk from clkdev table? That is already done in this patch!!
I meant why can't OMAP2/3 data be removed in PATCH 4/4 also, which only
touches OMAP4.
--- [end] -----------------------
In patch 4 the only change done in the clock table was to correct the
name mis-match
of functional clock names for OMAP4 between clock data and hwmod data.
For OMAP2/3 the names are already matching. As the comment was given in patch 3
where iclk entries got removed for OMAP4, he must have expected similar cleanup
is done for fclk in patch 4. But as I said, only the name mis-match is
corrected.
In summary, there is no specific changes needed in the patch.

I will rebase on top of cleanup-part2 are repost patch 4.
--
Tarun
>
> Regards,
>
> Tony

WARNING: multiple messages have this Message-ID (diff)
From: tarun.kanti@ti.com (DebBarma, Tarun Kanti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
Date: Thu, 5 Jul 2012 17:11:27 +0530	[thread overview]
Message-ID: <CAC83ZvKO22JZ59VLdykEjRNDqK_FmGLtC=1y8OEfP88Ef9jBSA@mail.gmail.com> (raw)
In-Reply-To: <20120705092809.GY1122@atomide.com>

Hi Tony,

On Thu, Jul 5, 2012 at 2:58 PM, Tony Lindgren <tony@atomide.com> wrote:
> * DebBarma, Tarun Kanti <tarun.kanti@ti.com> [120704 21:07]:
>> On Thu, Jun 14, 2012 at 4:28 PM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote:
>> >
>> > Just to let you know that this cleanup is essential for Benoit's OMAP4
>> > hwmod cleanup
>> > and OMAP5 minimal support series.
>>
>> This is a gentle reminder in case you have missed somehow!!
>> Let me know if anything else needs to be done.
>
> Now with the hwmod patch 2/4 pulled into cleanup-part2 from Paul,
> I've also applied patch 1/4 there. Patches 3 and 4 have still some pending
> comments from Kevin it seems?
Yes....

>
> Also at least patch 3 won't apply, so please check Kevin's comments
> and repost patches 3 and 4 on top of cleanup-part2 at commit 74dd9ec62.
Patch 3: Comment was about adding summary in patch 0/x why we have
not removed iclk in OMAP2/3 platform. In other words there was no
specific changes needed on patch 3 as such. BTW, patch 3 is already merged.

Patch 4:
--- [Kevin's comment] ---
>>
>> Comment applies to PATCH 4/4 also.
> You mean removing iclk from clkdev table? That is already done in this patch!!
I meant why can't OMAP2/3 data be removed in PATCH 4/4 also, which only
touches OMAP4.
--- [end] -----------------------
In patch 4 the only change done in the clock table was to correct the
name mis-match
of functional clock names for OMAP4 between clock data and hwmod data.
For OMAP2/3 the names are already matching. As the comment was given in patch 3
where iclk entries got removed for OMAP4, he must have expected similar cleanup
is done for fclk in patch 4. But as I said, only the name mis-match is
corrected.
In summary, there is no specific changes needed in the patch.

I will rebase on top of cleanup-part2 are repost patch 4.
--
Tarun
>
> Regards,
>
> Tony

  reply	other threads:[~2012-07-05 11:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 12:39 [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage Tarun Kanti DebBarma
2012-04-20 12:39 ` Tarun Kanti DebBarma
2012-04-20 12:39 ` [PATCH v2 1/4] ARM: OMAP: dmtimer: use devm_ API and do some cleanup in probe() Tarun Kanti DebBarma
2012-04-20 12:39   ` Tarun Kanti DebBarma
2012-04-20 12:39 ` [PATCH v2 2/4] ARM: OMAP2+: hwmod: add omap_hwmod_get_main_clk() API Tarun Kanti DebBarma
2012-04-20 12:39   ` Tarun Kanti DebBarma
2012-04-20 15:10   ` Cousson, Benoit
2012-04-20 15:10     ` Cousson, Benoit
2012-06-18 16:23   ` Paul Walmsley
2012-06-18 16:23     ` Paul Walmsley
2012-07-04 15:39   ` Paul Walmsley
2012-07-04 15:39     ` Paul Walmsley
2012-04-20 12:39 ` [PATCH v2 3/4] ARM: OMAP2+: dmtimer: cleanup iclk usage Tarun Kanti DebBarma
2012-04-20 12:39   ` Tarun Kanti DebBarma
2012-04-23 17:48   ` Kevin Hilman
2012-04-23 17:48     ` Kevin Hilman
2012-04-23 19:36     ` DebBarma, Tarun Kanti
2012-04-23 19:36       ` DebBarma, Tarun Kanti
2012-04-24  0:34       ` Kevin Hilman
2012-04-24  0:34         ` Kevin Hilman
2012-04-20 12:39 ` [PATCH v2 4/4] ARM: OMAP2+: dmtimer: cleanup fclk usage Tarun Kanti DebBarma
2012-04-20 12:39   ` Tarun Kanti DebBarma
2012-06-14 10:54 ` [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage DebBarma, Tarun Kanti
2012-06-14 10:54   ` DebBarma, Tarun Kanti
2012-06-14 10:58   ` Shilimkar, Santosh
2012-06-14 10:58     ` Shilimkar, Santosh
2012-07-05  4:02     ` DebBarma, Tarun Kanti
2012-07-05  4:02       ` DebBarma, Tarun Kanti
2012-07-05  9:28       ` Tony Lindgren
2012-07-05  9:28         ` Tony Lindgren
2012-07-05 11:41         ` DebBarma, Tarun Kanti [this message]
2012-07-05 11:41           ` DebBarma, Tarun Kanti
2012-07-06  7:09           ` Tony Lindgren
2012-07-06  7:09             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC83ZvKO22JZ59VLdykEjRNDqK_FmGLtC=1y8OEfP88Ef9jBSA@mail.gmail.com' \
    --to=tarun.kanti@ti.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.