From: Jason Wang <jasowang@redhat.com> To: Cornelia Huck <cohuck@redhat.com> Cc: Halil Pasic <pasic@linux.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Paul E. McKenney" <paulmck@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Marc Zyngier <maz@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs() Date: Wed, 13 Apr 2022 10:53:43 +0800 [thread overview] Message-ID: <CACGkMEuUXAUK-8GnBWgij5TOSN0ct_gmxnDQEcovRmTLK6bv4w@mail.gmail.com> (raw) In-Reply-To: <87r1629rio.fsf@redhat.com> On Wed, Apr 13, 2022 at 12:49 AM Cornelia Huck <cohuck@redhat.com> wrote: > > On Tue, Apr 12 2022, Halil Pasic <pasic@linux.ibm.com> wrote: > > > On Mon, 11 Apr 2022 16:27:41 +0200 > > Cornelia Huck <cohuck@redhat.com> wrote: > > >> My main concern is that we would need to synchronize against a single > >> interrupt that covers all kinds of I/O interrupts, not just a single > >> device... > >> > > > > Could we synchronize on struct airq_info's lock member? If we were > > to grab all of these that might be involved... > > Hm, that could possibly narrow the sync down to a subset, which seems > better. For devices still using classic interrupts, per-device sync > would be easy. > > > > > AFAIU for the synchronize implementation we need a lock or a set of locks > > that contain all the possible vring_interrupt() calls with the queuues > > that belong to the given device as a critical section. That way, one > > has the acquire's and release's in place so that the vrign_interrupt() > > either guaranteed to finish before the change of driver_ready is > > guaranteed to be complete, or it is guaranteed to see the change. > > > > In any case, I guess we should first get clear on the first part. I.e. > > when do we want to allow host->guest notifications. > > Also, whether we just care about vring interrupts, or general device > interrupts (not sure if a config change interrupt may also trigger > things we do not want to trigger?) I think only vring interrupts, since the config interrupt hardening is done via 22b7050a024d7 ("virtio: defer config changed notifications") Thanks >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Cornelia Huck <cohuck@redhat.com> Cc: "Paul E. McKenney" <paulmck@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Marc Zyngier <maz@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org>, Halil Pasic <pasic@linux.ibm.com>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs() Date: Wed, 13 Apr 2022 10:53:43 +0800 [thread overview] Message-ID: <CACGkMEuUXAUK-8GnBWgij5TOSN0ct_gmxnDQEcovRmTLK6bv4w@mail.gmail.com> (raw) In-Reply-To: <87r1629rio.fsf@redhat.com> On Wed, Apr 13, 2022 at 12:49 AM Cornelia Huck <cohuck@redhat.com> wrote: > > On Tue, Apr 12 2022, Halil Pasic <pasic@linux.ibm.com> wrote: > > > On Mon, 11 Apr 2022 16:27:41 +0200 > > Cornelia Huck <cohuck@redhat.com> wrote: > > >> My main concern is that we would need to synchronize against a single > >> interrupt that covers all kinds of I/O interrupts, not just a single > >> device... > >> > > > > Could we synchronize on struct airq_info's lock member? If we were > > to grab all of these that might be involved... > > Hm, that could possibly narrow the sync down to a subset, which seems > better. For devices still using classic interrupts, per-device sync > would be easy. > > > > > AFAIU for the synchronize implementation we need a lock or a set of locks > > that contain all the possible vring_interrupt() calls with the queuues > > that belong to the given device as a critical section. That way, one > > has the acquire's and release's in place so that the vrign_interrupt() > > either guaranteed to finish before the change of driver_ready is > > guaranteed to be complete, or it is guaranteed to see the change. > > > > In any case, I guess we should first get clear on the first part. I.e. > > when do we want to allow host->guest notifications. > > Also, whether we just care about vring interrupts, or general device > interrupts (not sure if a config change interrupt may also trigger > things we do not want to trigger?) I think only vring interrupts, since the config interrupt hardening is done via 22b7050a024d7 ("virtio: defer config changed notifications") Thanks > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-04-13 2:54 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-06 8:35 [PATCH V2 0/5] rework on the IRQ hardening of virtio Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 8:35 ` [PATCH V2 1/5] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 11:44 ` Michael S. Tsirkin 2022-04-06 11:44 ` Michael S. Tsirkin 2022-04-07 6:19 ` Jason Wang 2022-04-07 6:19 ` Jason Wang 2022-04-06 8:35 ` [PATCH V2 2/5] virtio: use virtio_reset_device() when possible Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 11:53 ` Michael S. Tsirkin 2022-04-06 11:53 ` Michael S. Tsirkin 2022-04-06 8:35 ` [PATCH V2 3/5] virtio: introduce config op to synchronize vring callbacks Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 11:59 ` Michael S. Tsirkin 2022-04-06 11:59 ` Michael S. Tsirkin 2022-04-07 6:25 ` Jason Wang 2022-04-07 6:25 ` Jason Wang 2022-04-06 8:35 ` [PATCH V2 4/5] virtio-pci: implement synchronize_vqs() Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 12:00 ` Michael S. Tsirkin 2022-04-06 12:00 ` Michael S. Tsirkin 2022-04-06 13:04 ` Cornelia Huck 2022-04-06 13:04 ` Cornelia Huck 2022-04-06 15:31 ` Michael S. Tsirkin 2022-04-06 15:31 ` Michael S. Tsirkin 2022-04-07 6:38 ` Jason Wang 2022-04-07 6:38 ` Jason Wang 2022-04-07 7:52 ` Cornelia Huck 2022-04-07 7:52 ` Cornelia Huck 2022-04-07 8:04 ` Jason Wang 2022-04-07 8:04 ` Jason Wang 2022-04-08 13:03 ` Halil Pasic 2022-04-08 13:03 ` Halil Pasic 2022-04-10 7:51 ` Michael S. Tsirkin 2022-04-10 7:51 ` Michael S. Tsirkin 2022-04-11 8:22 ` Jason Wang 2022-04-11 8:22 ` Jason Wang 2022-04-11 8:56 ` Michael S. Tsirkin 2022-04-11 8:56 ` Michael S. Tsirkin 2022-04-12 2:21 ` Jason Wang 2022-04-12 2:21 ` Jason Wang 2022-04-11 14:27 ` Cornelia Huck 2022-04-11 14:27 ` Cornelia Huck 2022-04-12 0:01 ` Halil Pasic 2022-04-12 0:01 ` Halil Pasic 2022-04-12 2:24 ` Jason Wang 2022-04-12 2:24 ` Jason Wang 2022-04-12 7:55 ` Halil Pasic 2022-04-12 7:55 ` Halil Pasic 2022-04-12 16:48 ` Cornelia Huck 2022-04-12 16:48 ` Cornelia Huck 2022-04-13 2:53 ` Jason Wang [this message] 2022-04-13 2:53 ` Jason Wang 2022-04-13 6:41 ` Cornelia Huck 2022-04-13 6:41 ` Cornelia Huck 2022-04-06 8:35 ` [PATCH V2 5/5] virtio: harden vring IRQ Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 12:04 ` Michael S. Tsirkin 2022-04-06 12:04 ` Michael S. Tsirkin 2022-04-07 6:39 ` Jason Wang 2022-04-07 6:39 ` Jason Wang 2022-04-06 11:36 ` [PATCH V2 0/5] rework on the IRQ hardening of virtio Michael S. Tsirkin 2022-04-06 11:36 ` Michael S. Tsirkin 2022-04-07 6:12 ` Jason Wang 2022-04-07 6:12 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACGkMEuUXAUK-8GnBWgij5TOSN0ct_gmxnDQEcovRmTLK6bv4w@mail.gmail.com \ --to=jasowang@redhat.com \ --cc=cohuck@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=mst@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.