From: Jason Wang <jasowang@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, maz@kernel.org, tglx@linutronix.de, peterz@infradead.org, sgarzare@redhat.com Subject: Re: [PATCH V2 0/5] rework on the IRQ hardening of virtio Date: Thu, 7 Apr 2022 14:12:27 +0800 [thread overview] Message-ID: <ccb6be3f-e397-21cb-3490-637c96483fcb@redhat.com> (raw) In-Reply-To: <20220406073500-mutt-send-email-mst@kernel.org> 在 2022/4/6 下午7:36, Michael S. Tsirkin 写道: > On Wed, Apr 06, 2022 at 04:35:33PM +0800, Jason Wang wrote: >> Hi All: >> >> This is a rework on the IRQ hardening for virtio which is done >> previously by the following commits are reverted: >> >> 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") >> 080cd7c3ac87 ("virtio-pci: harden INTX interrupts") >> >> The reason is that it depends on the IRQF_NO_AUTOEN which may conflict >> with the assumption of the affinity managed IRQ that is used by some >> virtio drivers. And what's more, it is only done for virtio-pci but >> not other transports. >> >> In this rework, I try to implement a general virtio solution which >> borrows the idea of the INTX hardening by introducing a boolean for >> virtqueue callback enabling and toggle it in virtio_device_ready() >> and virtio_reset_device(). Then vring_interrupt() can simply check and >> return early if the driver is not ready. > > All of a sudden all patches are having a wrong mime type. > > It is application/octet-stream; should be text/plain > > Pls fix and repost, thanks! So the patches are generated via git-format-patch and git-send-email in one run. I can see many upstream patches were converted to application/octet-stream if From: tag is different from the sender. Maxime told me they've also noticed the issue and it looks like a issue of mimecast. Thanks > >> Please review. >> >> Changes since v1: >> >> - Use transport specific irq synchronization method when possible >> - Drop the module parameter and enable the hardening unconditonally >> - Tweak the barrier/ordering facilities used in the code >> - Reanme irq_soft_enabled to driver_ready >> - Avoid unnecssary IRQ synchornization (e.g during boot) >> >> Jason Wang (4): >> virtio: use virtio_reset_device() when possible >> virtio: introduce config op to synchronize vring callbacks >> virtio-pci: implement synchronize_vqs() >> virtio: harden vring IRQ >> >> Stefano Garzarella (1): >> virtio: use virtio_device_ready() in virtio_device_restore() >> >> drivers/virtio/virtio.c | 20 ++++++++++++++++---- >> drivers/virtio/virtio_pci_common.c | 14 ++++++++++++++ >> drivers/virtio/virtio_pci_common.h | 2 ++ >> drivers/virtio/virtio_pci_legacy.c | 1 + >> drivers/virtio/virtio_pci_modern.c | 2 ++ >> drivers/virtio/virtio_ring.c | 9 ++++++++- >> include/linux/virtio.h | 2 ++ >> include/linux/virtio_config.h | 24 ++++++++++++++++++++++++ >> 8 files changed, 69 insertions(+), 5 deletions(-) >> >> -- >> 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: peterz@infradead.org, maz@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, tglx@linutronix.de Subject: Re: [PATCH V2 0/5] rework on the IRQ hardening of virtio Date: Thu, 7 Apr 2022 14:12:27 +0800 [thread overview] Message-ID: <ccb6be3f-e397-21cb-3490-637c96483fcb@redhat.com> (raw) In-Reply-To: <20220406073500-mutt-send-email-mst@kernel.org> 在 2022/4/6 下午7:36, Michael S. Tsirkin 写道: > On Wed, Apr 06, 2022 at 04:35:33PM +0800, Jason Wang wrote: >> Hi All: >> >> This is a rework on the IRQ hardening for virtio which is done >> previously by the following commits are reverted: >> >> 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") >> 080cd7c3ac87 ("virtio-pci: harden INTX interrupts") >> >> The reason is that it depends on the IRQF_NO_AUTOEN which may conflict >> with the assumption of the affinity managed IRQ that is used by some >> virtio drivers. And what's more, it is only done for virtio-pci but >> not other transports. >> >> In this rework, I try to implement a general virtio solution which >> borrows the idea of the INTX hardening by introducing a boolean for >> virtqueue callback enabling and toggle it in virtio_device_ready() >> and virtio_reset_device(). Then vring_interrupt() can simply check and >> return early if the driver is not ready. > > All of a sudden all patches are having a wrong mime type. > > It is application/octet-stream; should be text/plain > > Pls fix and repost, thanks! So the patches are generated via git-format-patch and git-send-email in one run. I can see many upstream patches were converted to application/octet-stream if From: tag is different from the sender. Maxime told me they've also noticed the issue and it looks like a issue of mimecast. Thanks > >> Please review. >> >> Changes since v1: >> >> - Use transport specific irq synchronization method when possible >> - Drop the module parameter and enable the hardening unconditonally >> - Tweak the barrier/ordering facilities used in the code >> - Reanme irq_soft_enabled to driver_ready >> - Avoid unnecssary IRQ synchornization (e.g during boot) >> >> Jason Wang (4): >> virtio: use virtio_reset_device() when possible >> virtio: introduce config op to synchronize vring callbacks >> virtio-pci: implement synchronize_vqs() >> virtio: harden vring IRQ >> >> Stefano Garzarella (1): >> virtio: use virtio_device_ready() in virtio_device_restore() >> >> drivers/virtio/virtio.c | 20 ++++++++++++++++---- >> drivers/virtio/virtio_pci_common.c | 14 ++++++++++++++ >> drivers/virtio/virtio_pci_common.h | 2 ++ >> drivers/virtio/virtio_pci_legacy.c | 1 + >> drivers/virtio/virtio_pci_modern.c | 2 ++ >> drivers/virtio/virtio_ring.c | 9 ++++++++- >> include/linux/virtio.h | 2 ++ >> include/linux/virtio_config.h | 24 ++++++++++++++++++++++++ >> 8 files changed, 69 insertions(+), 5 deletions(-) >> >> -- >> 2.25.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-04-07 6:12 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-06 8:35 [PATCH V2 0/5] rework on the IRQ hardening of virtio Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 8:35 ` [PATCH V2 1/5] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 11:44 ` Michael S. Tsirkin 2022-04-06 11:44 ` Michael S. Tsirkin 2022-04-07 6:19 ` Jason Wang 2022-04-07 6:19 ` Jason Wang 2022-04-06 8:35 ` [PATCH V2 2/5] virtio: use virtio_reset_device() when possible Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 11:53 ` Michael S. Tsirkin 2022-04-06 11:53 ` Michael S. Tsirkin 2022-04-06 8:35 ` [PATCH V2 3/5] virtio: introduce config op to synchronize vring callbacks Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 11:59 ` Michael S. Tsirkin 2022-04-06 11:59 ` Michael S. Tsirkin 2022-04-07 6:25 ` Jason Wang 2022-04-07 6:25 ` Jason Wang 2022-04-06 8:35 ` [PATCH V2 4/5] virtio-pci: implement synchronize_vqs() Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 12:00 ` Michael S. Tsirkin 2022-04-06 12:00 ` Michael S. Tsirkin 2022-04-06 13:04 ` Cornelia Huck 2022-04-06 13:04 ` Cornelia Huck 2022-04-06 15:31 ` Michael S. Tsirkin 2022-04-06 15:31 ` Michael S. Tsirkin 2022-04-07 6:38 ` Jason Wang 2022-04-07 6:38 ` Jason Wang 2022-04-07 7:52 ` Cornelia Huck 2022-04-07 7:52 ` Cornelia Huck 2022-04-07 8:04 ` Jason Wang 2022-04-07 8:04 ` Jason Wang 2022-04-08 13:03 ` Halil Pasic 2022-04-08 13:03 ` Halil Pasic 2022-04-10 7:51 ` Michael S. Tsirkin 2022-04-10 7:51 ` Michael S. Tsirkin 2022-04-11 8:22 ` Jason Wang 2022-04-11 8:22 ` Jason Wang 2022-04-11 8:56 ` Michael S. Tsirkin 2022-04-11 8:56 ` Michael S. Tsirkin 2022-04-12 2:21 ` Jason Wang 2022-04-12 2:21 ` Jason Wang 2022-04-11 14:27 ` Cornelia Huck 2022-04-11 14:27 ` Cornelia Huck 2022-04-12 0:01 ` Halil Pasic 2022-04-12 0:01 ` Halil Pasic 2022-04-12 2:24 ` Jason Wang 2022-04-12 2:24 ` Jason Wang 2022-04-12 7:55 ` Halil Pasic 2022-04-12 7:55 ` Halil Pasic 2022-04-12 16:48 ` Cornelia Huck 2022-04-12 16:48 ` Cornelia Huck 2022-04-13 2:53 ` Jason Wang 2022-04-13 2:53 ` Jason Wang 2022-04-13 6:41 ` Cornelia Huck 2022-04-13 6:41 ` Cornelia Huck 2022-04-06 8:35 ` [PATCH V2 5/5] virtio: harden vring IRQ Jason Wang 2022-04-06 8:35 ` Jason Wang 2022-04-06 12:04 ` Michael S. Tsirkin 2022-04-06 12:04 ` Michael S. Tsirkin 2022-04-07 6:39 ` Jason Wang 2022-04-07 6:39 ` Jason Wang 2022-04-06 11:36 ` [PATCH V2 0/5] rework on the IRQ hardening of virtio Michael S. Tsirkin 2022-04-06 11:36 ` Michael S. Tsirkin 2022-04-07 6:12 ` Jason Wang [this message] 2022-04-07 6:12 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ccb6be3f-e397-21cb-3490-637c96483fcb@redhat.com \ --to=jasowang@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=mst@redhat.com \ --cc=peterz@infradead.org \ --cc=sgarzare@redhat.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.