All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajat Jain <rajatja@google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Hans de Goede <hdegoede@redhat.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Benson Leung <bleung@chromium.org>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Mark Gross <markgross@kernel.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	ibm-acpi-devel@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org, gwendal@google.com,
	seanpaul@google.com, marcheu@google.com, rajatxjain@gmail.com
Subject: Re: [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen
Date: Fri, 7 Jan 2022 11:04:46 -0800	[thread overview]
Message-ID: <CACK8Z6HbKR5QktJjK1+QCKoLCJUHK8btQN5Xbij8A66VYzhcHw@mail.gmail.com> (raw)
In-Reply-To: <Ydh7u1kuXSMzwmW0@google.com>

Hi Dmitry, Benson,

On Fri, Jan 7, 2022 at 9:43 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Rajat,
>
> On Tue, Dec 21, 2021 at 04:11:26PM -0800, Rajat Jain wrote:
> > +static int chromeos_privacy_screen_remove(struct acpi_device *adev)
> > +{
> > +     struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev);
>
> Please add an empty line here:
>
> WARNING: Missing a blank line after declarations
> #292: FILE: drivers/platform/chrome/chromeos_privacy_screen.c:129:
> +       struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev);
> +       drm_privacy_screen_unregister(drm_privacy_screen);
>
> > +     drm_privacy_screen_unregister(drm_privacy_screen);
> > +     return 0;
> > +}
> > +
> > +static const struct acpi_device_id chromeos_privacy_screen_device_ids[] = {
> > +     {"GOOG0010", 0}, /* Google's electronic privacy screen for eDP-1 */
> > +     {}
> > +};
> > +MODULE_DEVICE_TABLE(acpi, chromeos_privacy_screen_device_ids);
> > +
> > +static struct acpi_driver chromeos_privacy_screen_driver = {
> > +     .name = "chromeos_privacy_screen_drvr",
>
> Could I buy 2 move vowels? ;)
>
> > +     .class = "ChromeOS",
> > +     .ids = chromeos_privacy_screen_device_ids,
> > +     .ops = {
> > +             .add = chromeos_privacy_screen_add,
> > +             .remove = chromeos_privacy_screen_remove,
> > +     },
> > +};
> > +
> > +module_acpi_driver(chromeos_privacy_screen_driver);
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("ChromeOS ACPI Privacy Screen driver");
> > +MODULE_AUTHOR("Rajat Jain <rajatja@google.com>");
>
> Otherwise
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks! I took care of your comments and posted a v5:
https://patchwork.kernel.org/project/platform-driver-x86/patch/20220107190208.95479-2-rajatja@google.com/

Thanks & Best Regards,

Rajat


>
> Thanks.
>
> --
> Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Rajat Jain <rajatja@google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: gwendal@google.com, marcheu@google.com,
	Thomas Zimmermann <tzimmermann@suse.de>,
	seanpaul@google.com, ibm-acpi-devel@lists.sourceforge.net,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Mark Gross <markgross@kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	dri-devel@lists.freedesktop.org,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	rajatxjain@gmail.com
Subject: Re: [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen
Date: Fri, 7 Jan 2022 11:04:46 -0800	[thread overview]
Message-ID: <CACK8Z6HbKR5QktJjK1+QCKoLCJUHK8btQN5Xbij8A66VYzhcHw@mail.gmail.com> (raw)
In-Reply-To: <Ydh7u1kuXSMzwmW0@google.com>

Hi Dmitry, Benson,

On Fri, Jan 7, 2022 at 9:43 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Rajat,
>
> On Tue, Dec 21, 2021 at 04:11:26PM -0800, Rajat Jain wrote:
> > +static int chromeos_privacy_screen_remove(struct acpi_device *adev)
> > +{
> > +     struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev);
>
> Please add an empty line here:
>
> WARNING: Missing a blank line after declarations
> #292: FILE: drivers/platform/chrome/chromeos_privacy_screen.c:129:
> +       struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev);
> +       drm_privacy_screen_unregister(drm_privacy_screen);
>
> > +     drm_privacy_screen_unregister(drm_privacy_screen);
> > +     return 0;
> > +}
> > +
> > +static const struct acpi_device_id chromeos_privacy_screen_device_ids[] = {
> > +     {"GOOG0010", 0}, /* Google's electronic privacy screen for eDP-1 */
> > +     {}
> > +};
> > +MODULE_DEVICE_TABLE(acpi, chromeos_privacy_screen_device_ids);
> > +
> > +static struct acpi_driver chromeos_privacy_screen_driver = {
> > +     .name = "chromeos_privacy_screen_drvr",
>
> Could I buy 2 move vowels? ;)
>
> > +     .class = "ChromeOS",
> > +     .ids = chromeos_privacy_screen_device_ids,
> > +     .ops = {
> > +             .add = chromeos_privacy_screen_add,
> > +             .remove = chromeos_privacy_screen_remove,
> > +     },
> > +};
> > +
> > +module_acpi_driver(chromeos_privacy_screen_driver);
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("ChromeOS ACPI Privacy Screen driver");
> > +MODULE_AUTHOR("Rajat Jain <rajatja@google.com>");
>
> Otherwise
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks! I took care of your comments and posted a v5:
https://patchwork.kernel.org/project/platform-driver-x86/patch/20220107190208.95479-2-rajatja@google.com/

Thanks & Best Regards,

Rajat


>
> Thanks.
>
> --
> Dmitry

  reply	other threads:[~2022-01-07 19:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22  0:11 [PATCH v4 1/3] drm/privacy_screen: Add drvdata in drm_privacy_screen Rajat Jain
2021-12-22  0:11 ` [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen Rajat Jain
2022-01-07 17:43   ` Dmitry Torokhov
2022-01-07 17:43     ` Dmitry Torokhov
2022-01-07 19:04     ` Rajat Jain [this message]
2022-01-07 19:04       ` Rajat Jain
2021-12-22  0:11 ` [PATCH v4 3/3] drm/privacy_screen_x86: Add entry " Rajat Jain
2021-12-22  0:13   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACK8Z6HbKR5QktJjK1+QCKoLCJUHK8btQN5Xbij8A66VYzhcHw@mail.gmail.com \
    --to=rajatja@google.com \
    --cc=airlied@linux.ie \
    --cc=bleung@chromium.org \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gwendal@google.com \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marcheu@google.com \
    --cc=markgross@kernel.org \
    --cc=mripard@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rajatxjain@gmail.com \
    --cc=seanpaul@google.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.