* [PATCH] ARM: dts: rainier: Update to access sensors via iio-hwmon
@ 2021-03-29 9:42 ` Rashmica Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Rashmica Gupta @ 2021-03-29 9:42 UTC (permalink / raw)
To: linux-aspeed, joel, robh+dt, andrew, devicetree, linux-arm-kernel
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index fefb0b8fd6d5..2dc72de07906 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -173,6 +173,16 @@ i2c2mux3: i2c@3 {
};
};
+ iio-hwmon-dps310 {
+ compatible = "iio-hwmon";
+ io-channels = <&dps 0>;
+ };
+
+ iio-hwmon-si7020 {
+ compatible = "iio-hwmon";
+ io-channels = <&si 1>;
+ };
+
leds {
compatible = "gpio-leds";
@@ -1972,9 +1982,10 @@ &i2c7 {
multi-master;
status = "okay";
- si7021-a20@20 {
+ si:si7021-a20@20 {
compatible = "silabs,si7020";
reg = <0x20>;
+ #io-channel-cells = <1>;
};
tmp275@48 {
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: rainier: Update to access sensors via iio-hwmon
@ 2021-03-29 9:42 ` Rashmica Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Rashmica Gupta @ 2021-03-29 9:42 UTC (permalink / raw)
To: linux-aspeed, joel, robh+dt, andrew, devicetree, linux-arm-kernel
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index fefb0b8fd6d5..2dc72de07906 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -173,6 +173,16 @@ i2c2mux3: i2c@3 {
};
};
+ iio-hwmon-dps310 {
+ compatible = "iio-hwmon";
+ io-channels = <&dps 0>;
+ };
+
+ iio-hwmon-si7020 {
+ compatible = "iio-hwmon";
+ io-channels = <&si 1>;
+ };
+
leds {
compatible = "gpio-leds";
@@ -1972,9 +1982,10 @@ &i2c7 {
multi-master;
status = "okay";
- si7021-a20@20 {
+ si:si7021-a20@20 {
compatible = "silabs,si7020";
reg = <0x20>;
+ #io-channel-cells = <1>;
};
tmp275@48 {
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: rainier: Update to access sensors via iio-hwmon
2021-03-29 9:42 ` Rashmica Gupta
@ 2021-03-31 7:48 ` Joel Stanley
-1 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2021-03-31 7:48 UTC (permalink / raw)
To: Rashmica Gupta
Cc: linux-aspeed, Rob Herring, Andrew Jeffery, devicetree, Linux ARM
On Mon, 29 Mar 2021 at 09:43, Rashmica Gupta <rashmica.g@gmail.com> wrote:
>
Can you add a brief message about why we're adding a iio-hwmon bridge
for these sensors?
> Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index fefb0b8fd6d5..2dc72de07906 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -173,6 +173,16 @@ i2c2mux3: i2c@3 {
> };
> };
>
> + iio-hwmon-dps310 {
> + compatible = "iio-hwmon";
> + io-channels = <&dps 0>;
> + };
> +
> + iio-hwmon-si7020 {
> + compatible = "iio-hwmon";
> + io-channels = <&si 1>;
> + };
> +
> leds {
> compatible = "gpio-leds";
>
> @@ -1972,9 +1982,10 @@ &i2c7 {
> multi-master;
> status = "okay";
>
> - si7021-a20@20 {
> + si:si7021-a20@20 {
That's a very short name. How about we call it humidity (or something else)?
Convention is to put a space after the colon.
> compatible = "silabs,si7020";
> reg = <0x20>;
> + #io-channel-cells = <1>;
> };
>
> tmp275@48 {
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: rainier: Update to access sensors via iio-hwmon
@ 2021-03-31 7:48 ` Joel Stanley
0 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2021-03-31 7:48 UTC (permalink / raw)
To: Rashmica Gupta
Cc: linux-aspeed, Rob Herring, Andrew Jeffery, devicetree, Linux ARM
On Mon, 29 Mar 2021 at 09:43, Rashmica Gupta <rashmica.g@gmail.com> wrote:
>
Can you add a brief message about why we're adding a iio-hwmon bridge
for these sensors?
> Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index fefb0b8fd6d5..2dc72de07906 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -173,6 +173,16 @@ i2c2mux3: i2c@3 {
> };
> };
>
> + iio-hwmon-dps310 {
> + compatible = "iio-hwmon";
> + io-channels = <&dps 0>;
> + };
> +
> + iio-hwmon-si7020 {
> + compatible = "iio-hwmon";
> + io-channels = <&si 1>;
> + };
> +
> leds {
> compatible = "gpio-leds";
>
> @@ -1972,9 +1982,10 @@ &i2c7 {
> multi-master;
> status = "okay";
>
> - si7021-a20@20 {
> + si:si7021-a20@20 {
That's a very short name. How about we call it humidity (or something else)?
Convention is to put a space after the colon.
> compatible = "silabs,si7020";
> reg = <0x20>;
> + #io-channel-cells = <1>;
> };
>
> tmp275@48 {
> --
> 2.26.3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-31 7:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 9:42 [PATCH] ARM: dts: rainier: Update to access sensors via iio-hwmon Rashmica Gupta
2021-03-29 9:42 ` Rashmica Gupta
2021-03-31 7:48 ` Joel Stanley
2021-03-31 7:48 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.