From: Joel Stanley <joel@jms.id.au> To: Andrew Jeffery <andrew@aj.id.au> Cc: Lee Jones <lee.jones@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-clk@vger.kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Jeremy Kerr <jk@ozlabs.org>, Rick Altherr <raltherr@google.com>, Ryan Chen <ryan_chen@aspeedtech.com>, Arnd Bergmann <arnd@arndb.de> Subject: Re: [PATCH v2 3/5] clk: aspeed: Add platform driver and register PLLs Date: Wed, 27 Sep 2017 16:13:30 +1000 [thread overview] Message-ID: <CACPK8Xd8RQ4s1xMsSuxHgQRiHS6vDtxVTAxu8Ba3J3it45MC5g@mail.gmail.com> (raw) In-Reply-To: <1506343255.30138.29.camel@aj.id.au> On Mon, Sep 25, 2017 at 10:40 PM, Andrew Jeffery <andrew@aj.id.au> wrote: > On Thu, 2017-09-21 at 13:56 +0930, Joel Stanley wrote: >> + /* >> + * Memory controller (M-PLL) PLL. This clock is configured by the >> + * bootloader, and is exposed to Linux as a read-only clock rate. >> + */ >> + regmap_read(map, ASPEED_MPLL_PARAM, &val); >> + aspeed_clk_data->hws[ASPEED_CLK_MPLL] = aspeed_calc_pll("mpll", val); > > IIRC the calculation in aspeed_calc_pll() is appropriate for the AST2500, but > not the AST2400. Ah ha. I knew there was a reason why I created an ast2400_calc_pll. I will add it back in in the previous patch so we can use it here. >> + /* Video Engine (ECLK) mux and clock divider */ >> + hw = clk_hw_register_mux(NULL, "eclk_mux", >> + eclk_parents, ARRAY_SIZE(eclk_parents), 0, >> + scu_base + ASPEED_CLK_SELECTION, 2, 2, >> + 0, &aspeed_clk_lock); >> + aspeed_clk_data->hws[ASPEED_CLK_ECLK_MUX] = hw; >> + hw = clk_hw_register_divider_table(NULL, "eclk", "eclk_mux", 0, >> + scu_base + ASPEED_CLK_SELECTION, 20, 3, 0, > > On the AST2500 it looks like this should start at bit 28 for 3 bits, not bit Good catch. Fixed in v3. > 20. Separately, I'm not sure how to interpret the AST2400 datasheet here - > maybe it's similar but with different wording ("clock slow down" rather than > "divisor"?). > >> + div_table, > > This doesn't seem to be correct. There's the problem of 0b000 and 0b001 mapping > the same value of 2 for the AST2500, whose table then increments in steps of 1. > The AST2400 mapping on the otherhand is multiples of 2 starting at 2, with no > inconsistency for 0b000 vs 0b001. Yep, we do use a different table for ast2400 vs ast2500. See ast2400_div_table vs ast2500_div_table. > >> + &aspeed_clk_lock); >> + aspeed_clk_data->hws[ASPEED_CLK_ECLK] = hw; >> + >> + /* P-Bus (BCLK) clock divider */ >> + hw = clk_hw_register_divider_table(NULL, "bclk", "hpll", 0, >> + scu_base + ASPEED_CLK_SELECTION, 0, 2, 0, > > Bit 0 in SCU08 is a 1-bit field "CPU/AHB clock dynamic slow down enable". BCLK > is actually in SCU*D*8, but (perhaps confusingly) documented immediately below > SCU*0*8. Good catch. Fixed in v3. Cheers, Joel
WARNING: multiple messages have this Message-ID (diff)
From: joel@jms.id.au (Joel Stanley) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/5] clk: aspeed: Add platform driver and register PLLs Date: Wed, 27 Sep 2017 16:13:30 +1000 [thread overview] Message-ID: <CACPK8Xd8RQ4s1xMsSuxHgQRiHS6vDtxVTAxu8Ba3J3it45MC5g@mail.gmail.com> (raw) In-Reply-To: <1506343255.30138.29.camel@aj.id.au> On Mon, Sep 25, 2017 at 10:40 PM, Andrew Jeffery <andrew@aj.id.au> wrote: > On Thu, 2017-09-21 at 13:56 +0930, Joel Stanley wrote: >> + /* >> + * Memory controller (M-PLL) PLL. This clock is configured by the >> + * bootloader, and is exposed to Linux as a read-only clock rate. >> + */ >> + regmap_read(map, ASPEED_MPLL_PARAM, &val); >> + aspeed_clk_data->hws[ASPEED_CLK_MPLL] = aspeed_calc_pll("mpll", val); > > IIRC the calculation in aspeed_calc_pll() is appropriate for the AST2500, but > not the AST2400. Ah ha. I knew there was a reason why I created an ast2400_calc_pll. I will add it back in in the previous patch so we can use it here. >> + /* Video Engine (ECLK) mux and clock divider */ >> + hw = clk_hw_register_mux(NULL, "eclk_mux", >> + eclk_parents, ARRAY_SIZE(eclk_parents), 0, >> + scu_base + ASPEED_CLK_SELECTION, 2, 2, >> + 0, &aspeed_clk_lock); >> + aspeed_clk_data->hws[ASPEED_CLK_ECLK_MUX] = hw; >> + hw = clk_hw_register_divider_table(NULL, "eclk", "eclk_mux", 0, >> + scu_base + ASPEED_CLK_SELECTION, 20, 3, 0, > > On the AST2500 it looks like this should start at bit 28 for 3 bits, not bit Good catch. Fixed in v3. > 20. Separately, I'm not sure how to interpret the AST2400 datasheet here - > maybe it's similar but with different wording ("clock slow down" rather than > "divisor"?). > >> + div_table, > > This doesn't seem to be correct. There's the problem of 0b000 and 0b001 mapping > the same value of 2 for the AST2500, whose table then increments in steps of 1. > The AST2400 mapping on the otherhand is multiples of 2 starting at 2, with no > inconsistency for 0b000 vs 0b001. Yep, we do use a different table for ast2400 vs ast2500. See ast2400_div_table vs ast2500_div_table. > >> + &aspeed_clk_lock); >> + aspeed_clk_data->hws[ASPEED_CLK_ECLK] = hw; >> + >> + /* P-Bus (BCLK) clock divider */ >> + hw = clk_hw_register_divider_table(NULL, "bclk", "hpll", 0, >> + scu_base + ASPEED_CLK_SELECTION, 0, 2, 0, > > Bit 0 in SCU08 is a 1-bit field "CPU/AHB clock dynamic slow down enable". BCLK > is actually in SCU*D*8, but (perhaps confusingly) documented immediately below > SCU*0*8. Good catch. Fixed in v3. Cheers, Joel
next prev parent reply other threads:[~2017-09-27 6:13 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-21 4:26 [PATCH v2 0/5] clk: Add Aspeed clock driver Joel Stanley 2017-09-21 4:26 ` Joel Stanley 2017-09-21 4:26 ` [PATCH v2 1/5] clk: Add clock driver for ASPEED BMC SoCs Joel Stanley 2017-09-21 4:26 ` Joel Stanley 2017-09-25 3:40 ` Andrew Jeffery 2017-09-25 3:40 ` Andrew Jeffery 2017-09-27 6:11 ` Joel Stanley 2017-09-27 6:11 ` Joel Stanley 2017-09-21 4:26 ` [PATCH v2 2/5] clk: aspeed: Register core clocks Joel Stanley 2017-09-21 4:26 ` Joel Stanley 2017-09-25 12:02 ` Andrew Jeffery 2017-09-25 12:02 ` Andrew Jeffery 2017-09-27 6:13 ` Joel Stanley 2017-09-27 6:13 ` Joel Stanley 2017-10-02 21:39 ` Stephen Boyd 2017-10-02 21:39 ` Stephen Boyd 2017-09-21 4:26 ` [PATCH v2 3/5] clk: aspeed: Add platform driver and register PLLs Joel Stanley 2017-09-21 4:26 ` Joel Stanley 2017-09-25 12:40 ` Andrew Jeffery 2017-09-25 12:40 ` Andrew Jeffery 2017-09-27 6:13 ` Joel Stanley [this message] 2017-09-27 6:13 ` Joel Stanley 2017-09-27 7:34 ` Andrew Jeffery 2017-09-27 7:34 ` Andrew Jeffery 2017-09-28 4:29 ` Joel Stanley 2017-09-28 4:29 ` Joel Stanley 2017-10-02 21:24 ` Stephen Boyd 2017-10-02 21:24 ` Stephen Boyd 2017-10-03 5:48 ` Joel Stanley 2017-10-03 5:48 ` Joel Stanley 2017-10-04 21:18 ` Stephen Boyd 2017-10-04 21:18 ` Stephen Boyd 2017-10-05 6:22 ` Joel Stanley 2017-10-05 6:22 ` Joel Stanley 2017-09-21 4:26 ` [PATCH v2 4/5] clk: aspeed: Register gated clocks Joel Stanley 2017-09-21 4:26 ` Joel Stanley 2017-10-02 21:37 ` Stephen Boyd 2017-10-02 21:37 ` Stephen Boyd 2017-10-03 5:47 ` Joel Stanley 2017-10-03 5:47 ` Joel Stanley 2017-09-21 4:26 ` [PATCH v2 5/5] clk: aspeed: Add reset controller Joel Stanley 2017-09-21 4:26 ` Joel Stanley 2017-09-25 12:54 ` Andrew Jeffery 2017-09-25 12:54 ` Andrew Jeffery 2017-09-27 6:13 ` Joel Stanley 2017-09-27 6:13 ` Joel Stanley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACPK8Xd8RQ4s1xMsSuxHgQRiHS6vDtxVTAxu8Ba3J3it45MC5g@mail.gmail.com \ --to=joel@jms.id.au \ --cc=andrew@aj.id.au \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=jk@ozlabs.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=raltherr@google.com \ --cc=ryan_chen@aspeedtech.com \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.