* [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
@ 2018-03-04 5:03 Haiyue Wang
2018-03-07 3:56 ` Joel Stanley
0 siblings, 1 reply; 12+ messages in thread
From: Haiyue Wang @ 2018-03-04 5:03 UTC (permalink / raw)
To: joel, andrew, openbmc, linux-kernel; +Cc: Haiyue Wang
The IPMI KCS device part of the LPC interface and is used for
communication with the host processor.
Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
---
Hi Joel & Andrew,
The kcs-bmc-aspeed module has been in:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/char/ipmi/kcs_bmc_aspeed.c
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
I updated the device tree node about kcs-bmc, this is passed on my board.
And the patch is generated by rebasing on:
https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
Please help to review.
BR,
Haiyue
---
arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 8eac57c..f443169 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -267,8 +267,40 @@
ranges = <0x0 0x1e789000 0x1000>;
lpc_bmc: lpc-bmc@0 {
- compatible = "aspeed,ast2500-lpc-bmc";
+ compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
reg = <0x0 0x80>;
+ reg-io-width = <4>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x80>;
+
+ kcs1: kcs1@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <1>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
+ kcs2: kcs2@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <2>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
+ kcs3: kcs3@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <3>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
};
lpc_host: lpc-host@80 {
@@ -294,6 +326,15 @@
status = "disabled";
};
+ kcs4: kcs4@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0xa0>;
+ interrupts = <8>;
+ kcs_chan = <4>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
lhc: lhc@20 {
compatible = "aspeed,ast2500-lhc";
reg = <0x20 0x24 0x48 0x8>;
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
2018-03-04 5:03 [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node Haiyue Wang
@ 2018-03-07 3:56 ` Joel Stanley
0 siblings, 0 replies; 12+ messages in thread
From: Joel Stanley @ 2018-03-07 3:56 UTC (permalink / raw)
To: Haiyue Wang; +Cc: Andrew Jeffery, OpenBMC Maillist, Linux Kernel Mailing List
On Sun, Mar 4, 2018 at 3:33 PM, Haiyue Wang <haiyue.wang@linux.intel.com> wrote:
> The IPMI KCS device part of the LPC interface and is used for
> communication with the host processor.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> ---
> Hi Joel & Andrew,
>
> The kcs-bmc-aspeed module has been in:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/char/ipmi/kcs_bmc_aspeed.c
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
>
> I updated the device tree node about kcs-bmc, this is passed on my board.
>
> And the patch is generated by rebasing on:
> https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
> Please help to review.
Thanks for the patch. I suggest you submit this patch for inclusion in
the upstream kernel. To do this, send it to:
Joel Stanley <joel@jms.id.au>
Andrew Jeffery <andrew@aj.id.au>
linux-arm-kernel@lists.infradead.org
linux-aspeed@lists.ozlabs.org
linux-kernel@vger.kernel.org
And I will consider it for merging.
>From there I can backport it into the dev-4.13 tree.
Cheers,
Joel
>
> BR,
> Haiyue
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 8eac57c..f443169 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -267,8 +267,40 @@
> ranges = <0x0 0x1e789000 0x1000>;
>
> lpc_bmc: lpc-bmc@0 {
> - compatible = "aspeed,ast2500-lpc-bmc";
> + compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
> reg = <0x0 0x80>;
> + reg-io-width = <4>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x80>;
> +
> + kcs1: kcs1@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <1>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs2: kcs2@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <2>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs3: kcs3@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <3>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> };
>
> lpc_host: lpc-host@80 {
> @@ -294,6 +326,15 @@
> status = "disabled";
> };
>
> + kcs4: kcs4@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0xa0>;
> + interrupts = <8>;
> + kcs_chan = <4>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> lhc: lhc@20 {
> compatible = "aspeed,ast2500-lhc";
> reg = <0x20 0x24 0x48 0x8>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
@ 2018-03-07 3:56 ` Joel Stanley
0 siblings, 0 replies; 12+ messages in thread
From: Joel Stanley @ 2018-03-07 3:56 UTC (permalink / raw)
To: Haiyue Wang; +Cc: Andrew Jeffery, OpenBMC Maillist, Linux Kernel Mailing List
On Sun, Mar 4, 2018 at 3:33 PM, Haiyue Wang <haiyue.wang@linux.intel.com> wrote:
> The IPMI KCS device part of the LPC interface and is used for
> communication with the host processor.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> ---
> Hi Joel & Andrew,
>
> The kcs-bmc-aspeed module has been in:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/char/ipmi/kcs_bmc_aspeed.c
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
>
> I updated the device tree node about kcs-bmc, this is passed on my board.
>
> And the patch is generated by rebasing on:
> https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
> Please help to review.
Thanks for the patch. I suggest you submit this patch for inclusion in
the upstream kernel. To do this, send it to:
Joel Stanley <joel@jms.id.au>
Andrew Jeffery <andrew@aj.id.au>
linux-arm-kernel@lists.infradead.org
linux-aspeed@lists.ozlabs.org
linux-kernel@vger.kernel.org
And I will consider it for merging.
From there I can backport it into the dev-4.13 tree.
Cheers,
Joel
>
> BR,
> Haiyue
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 8eac57c..f443169 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -267,8 +267,40 @@
> ranges = <0x0 0x1e789000 0x1000>;
>
> lpc_bmc: lpc-bmc@0 {
> - compatible = "aspeed,ast2500-lpc-bmc";
> + compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
> reg = <0x0 0x80>;
> + reg-io-width = <4>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x80>;
> +
> + kcs1: kcs1@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <1>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs2: kcs2@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <2>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs3: kcs3@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <3>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> };
>
> lpc_host: lpc-host@80 {
> @@ -294,6 +326,15 @@
> status = "disabled";
> };
>
> + kcs4: kcs4@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0xa0>;
> + interrupts = <8>;
> + kcs_chan = <4>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> lhc: lhc@20 {
> compatible = "aspeed,ast2500-lhc";
> reg = <0x20 0x24 0x48 0x8>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
2018-03-07 3:56 ` Joel Stanley
(?)
@ 2018-03-07 4:41 ` Wang, Haiyue
-1 siblings, 0 replies; 12+ messages in thread
From: Wang, Haiyue @ 2018-03-07 4:41 UTC (permalink / raw)
To: Joel Stanley; +Cc: Andrew Jeffery, OpenBMC Maillist, Linux Kernel Mailing List
On 2018-03-07 11:56, Joel Stanley wrote:
>> And the patch is generated by rebasing on:
>> https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
>> Please help to review.
> Thanks for the patch. I suggest you submit this patch for inclusion in
> the upstream kernel. To do this, send it to:
> Joel Stanley<joel@jms.id.au>
> Andrew Jeffery<andrew@aj.id.au>
> linux-arm-kernel@lists.infradead.org
> linux-aspeed@lists.ozlabs.org
> linux-kernel@vger.kernel.org
Got it.
> And I will consider it for merging.
>
> From there I can backport it into the dev-4.13 tree.
>
> Cheers,
>
> Joel
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
@ 2018-03-07 5:04 ` Haiyue Wang
0 siblings, 0 replies; 12+ messages in thread
From: Haiyue Wang @ 2018-03-07 5:04 UTC (permalink / raw)
To: joel, andrew, linux-arm-kernel, linux-aspeed, linux-kernel; +Cc: Haiyue Wang
The IPMI KCS device part of the LPC interface and is used for
communication with the host processor.
Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
---
arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 8eac57c..f443169 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -267,8 +267,40 @@
ranges = <0x0 0x1e789000 0x1000>;
lpc_bmc: lpc-bmc@0 {
- compatible = "aspeed,ast2500-lpc-bmc";
+ compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
reg = <0x0 0x80>;
+ reg-io-width = <4>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x80>;
+
+ kcs1: kcs1@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <1>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
+ kcs2: kcs2@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <2>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
+ kcs3: kcs3@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <3>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
};
lpc_host: lpc-host@80 {
@@ -294,6 +326,15 @@
status = "disabled";
};
+ kcs4: kcs4@0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0xa0>;
+ interrupts = <8>;
+ kcs_chan = <4>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
lhc: lhc@20 {
compatible = "aspeed,ast2500-lhc";
reg = <0x20 0x24 0x48 0x8>;
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
@ 2018-03-07 5:04 ` Haiyue Wang
0 siblings, 0 replies; 12+ messages in thread
From: Haiyue Wang @ 2018-03-07 5:04 UTC (permalink / raw)
To: linux-arm-kernel
The IPMI KCS device part of the LPC interface and is used for
communication with the host processor.
Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
---
arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 8eac57c..f443169 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -267,8 +267,40 @@
ranges = <0x0 0x1e789000 0x1000>;
lpc_bmc: lpc-bmc at 0 {
- compatible = "aspeed,ast2500-lpc-bmc";
+ compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
reg = <0x0 0x80>;
+ reg-io-width = <4>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x80>;
+
+ kcs1: kcs1 at 0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <1>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
+ kcs2: kcs2 at 0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <2>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
+ kcs3: kcs3 at 0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0x80>;
+ interrupts = <8>;
+ kcs_chan = <3>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
};
lpc_host: lpc-host at 80 {
@@ -294,6 +326,15 @@
status = "disabled";
};
+ kcs4: kcs4 at 0 {
+ compatible = "aspeed,ast2500-kcs-bmc";
+ reg = <0x0 0xa0>;
+ interrupts = <8>;
+ kcs_chan = <4>;
+ kcs_addr = <0x0>;
+ status = "disabled";
+ };
+
lhc: lhc at 20 {
compatible = "aspeed,ast2500-lhc";
reg = <0x20 0x24 0x48 0x8>;
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
2018-03-07 5:04 ` Haiyue Wang
@ 2018-03-16 0:47 ` Wang, Haiyue
-1 siblings, 0 replies; 12+ messages in thread
From: Wang, Haiyue @ 2018-03-16 0:47 UTC (permalink / raw)
To: joel, andrew; +Cc: linux-arm-kernel, linux-aspeed, linux-kernel
Hi Joel and Andrew,
Have time to review this patch ? Hope for your comments. :-)
BR,
Haiyue
On 2018-03-07 13:04, Haiyue Wang wrote:
> The IPMI KCS device part of the LPC interface and is used for
> communication with the host processor.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 8eac57c..f443169 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -267,8 +267,40 @@
> ranges = <0x0 0x1e789000 0x1000>;
>
> lpc_bmc: lpc-bmc@0 {
> - compatible = "aspeed,ast2500-lpc-bmc";
> + compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
> reg = <0x0 0x80>;
> + reg-io-width = <4>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x80>;
> +
> + kcs1: kcs1@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <1>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs2: kcs2@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <2>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs3: kcs3@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <3>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> };
>
> lpc_host: lpc-host@80 {
> @@ -294,6 +326,15 @@
> status = "disabled";
> };
>
> + kcs4: kcs4@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0xa0>;
> + interrupts = <8>;
> + kcs_chan = <4>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> lhc: lhc@20 {
> compatible = "aspeed,ast2500-lhc";
> reg = <0x20 0x24 0x48 0x8>;
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
@ 2018-03-16 0:47 ` Wang, Haiyue
0 siblings, 0 replies; 12+ messages in thread
From: Wang, Haiyue @ 2018-03-16 0:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi Joel and Andrew,
Have time to review this patch ? Hope for your comments. :-)
BR,
Haiyue
On 2018-03-07 13:04, Haiyue Wang wrote:
> The IPMI KCS device part of the LPC interface and is used for
> communication with the host processor.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 8eac57c..f443169 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -267,8 +267,40 @@
> ranges = <0x0 0x1e789000 0x1000>;
>
> lpc_bmc: lpc-bmc at 0 {
> - compatible = "aspeed,ast2500-lpc-bmc";
> + compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
> reg = <0x0 0x80>;
> + reg-io-width = <4>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x80>;
> +
> + kcs1: kcs1 at 0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <1>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs2: kcs2 at 0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <2>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs3: kcs3 at 0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <3>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> };
>
> lpc_host: lpc-host at 80 {
> @@ -294,6 +326,15 @@
> status = "disabled";
> };
>
> + kcs4: kcs4 at 0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0xa0>;
> + interrupts = <8>;
> + kcs_chan = <4>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> lhc: lhc at 20 {
> compatible = "aspeed,ast2500-lhc";
> reg = <0x20 0x24 0x48 0x8>;
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
2018-03-16 0:47 ` Wang, Haiyue
@ 2018-05-25 4:34 ` Joel Stanley
-1 siblings, 0 replies; 12+ messages in thread
From: Joel Stanley @ 2018-05-25 4:34 UTC (permalink / raw)
To: Wang, Haiyue, Andrew Jeffery
Cc: Linux ARM, linux-aspeed, Linux Kernel Mailing List
Hello Andrew,
On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.wang@linux.intel.com> wrote:
> Hi Joel and Andrew,
>
> Have time to review this patch ? Hope for your comments. :-)
>
> BR,
> Haiyue
>
>
> On 2018-03-07 13:04, Haiyue Wang wrote:
>>
>> The IPMI KCS device part of the LPC interface and is used for
>> communication with the host processor.
>>
>> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Do you have time to take a look at these? The device tree doesn't make
sense to me.
Cheers,
Joel
>> ---
>> arch/arm/boot/dts/aspeed-g5.dtsi | 43
>> +++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
>> b/arch/arm/boot/dts/aspeed-g5.dtsi
>> index 8eac57c..f443169 100644
>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>> @@ -267,8 +267,40 @@
>> ranges = <0x0 0x1e789000 0x1000>;
>> lpc_bmc: lpc-bmc@0 {
>> - compatible =
>> "aspeed,ast2500-lpc-bmc";
>> + compatible =
>> "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
>> reg = <0x0 0x80>;
>> + reg-io-width = <4>;
>> +
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x80>;
>> +
>> + kcs1: kcs1@0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0x80>;
>> + interrupts = <8>;
>> + kcs_chan = <1>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> +
>> + kcs2: kcs2@0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0x80>;
>> + interrupts = <8>;
>> + kcs_chan = <2>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> +
>> + kcs3: kcs3@0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0x80>;
>> + interrupts = <8>;
>> + kcs_chan = <3>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> };
>> lpc_host: lpc-host@80 {
>> @@ -294,6 +326,15 @@
>> status = "disabled";
>> };
>> + kcs4: kcs4@0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0xa0>;
>> + interrupts = <8>;
>> + kcs_chan = <4>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> +
>> lhc: lhc@20 {
>> compatible =
>> "aspeed,ast2500-lhc";
>> reg = <0x20 0x24 0x48
>> 0x8>;
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
@ 2018-05-25 4:34 ` Joel Stanley
0 siblings, 0 replies; 12+ messages in thread
From: Joel Stanley @ 2018-05-25 4:34 UTC (permalink / raw)
To: linux-arm-kernel
Hello Andrew,
On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.wang@linux.intel.com> wrote:
> Hi Joel and Andrew,
>
> Have time to review this patch ? Hope for your comments. :-)
>
> BR,
> Haiyue
>
>
> On 2018-03-07 13:04, Haiyue Wang wrote:
>>
>> The IPMI KCS device part of the LPC interface and is used for
>> communication with the host processor.
>>
>> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Do you have time to take a look at these? The device tree doesn't make
sense to me.
Cheers,
Joel
>> ---
>> arch/arm/boot/dts/aspeed-g5.dtsi | 43
>> +++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
>> b/arch/arm/boot/dts/aspeed-g5.dtsi
>> index 8eac57c..f443169 100644
>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>> @@ -267,8 +267,40 @@
>> ranges = <0x0 0x1e789000 0x1000>;
>> lpc_bmc: lpc-bmc at 0 {
>> - compatible =
>> "aspeed,ast2500-lpc-bmc";
>> + compatible =
>> "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
>> reg = <0x0 0x80>;
>> + reg-io-width = <4>;
>> +
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x80>;
>> +
>> + kcs1: kcs1 at 0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0x80>;
>> + interrupts = <8>;
>> + kcs_chan = <1>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> +
>> + kcs2: kcs2 at 0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0x80>;
>> + interrupts = <8>;
>> + kcs_chan = <2>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> +
>> + kcs3: kcs3 at 0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0x80>;
>> + interrupts = <8>;
>> + kcs_chan = <3>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> };
>> lpc_host: lpc-host at 80 {
>> @@ -294,6 +326,15 @@
>> status = "disabled";
>> };
>> + kcs4: kcs4 at 0 {
>> + compatible =
>> "aspeed,ast2500-kcs-bmc";
>> + reg = <0x0 0xa0>;
>> + interrupts = <8>;
>> + kcs_chan = <4>;
>> + kcs_addr = <0x0>;
>> + status = "disabled";
>> + };
>> +
>> lhc: lhc at 20 {
>> compatible =
>> "aspeed,ast2500-lhc";
>> reg = <0x20 0x24 0x48
>> 0x8>;
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
2018-05-25 4:34 ` Joel Stanley
@ 2018-05-25 11:33 ` Wang, Haiyue
-1 siblings, 0 replies; 12+ messages in thread
From: Wang, Haiyue @ 2018-05-25 11:33 UTC (permalink / raw)
To: Joel Stanley, Andrew Jeffery
Cc: Linux ARM, linux-aspeed, Linux Kernel Mailing List
Hi Joel & Andrew
This patch is out of date. ;-)
New: https://patchwork.ozlabs.org/patch/893720/
On 2018-05-25 12:34, Joel Stanley wrote:
> Hello Andrew,
>
> On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.wang@linux.intel.com> wrote:
>> Hi Joel and Andrew,
>>
>> Have time to review this patch ? Hope for your comments. :-)
>>
>> BR,
>> Haiyue
>>
>>
>> On 2018-03-07 13:04, Haiyue Wang wrote:
>>> The IPMI KCS device part of the LPC interface and is used for
>>> communication with the host processor.
>>>
>>> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> Do you have time to take a look at these? The device tree doesn't make
> sense to me.
>
> Cheers,
>
> Joel
>
>>> ---
>>> arch/arm/boot/dts/aspeed-g5.dtsi | 43
>>> +++++++++++++++++++++++++++++++++++++++-
>>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> index 8eac57c..f443169 100644
>>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> @@ -267,8 +267,40 @@
>>> ranges = <0x0 0x1e789000 0x1000>;
>>> lpc_bmc: lpc-bmc@0 {
>>> - compatible =
>>> "aspeed,ast2500-lpc-bmc";
>>> + compatible =
>>> "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
>>> reg = <0x0 0x80>;
>>> + reg-io-width = <4>;
>>> +
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x0 0x0 0x80>;
>>> +
>>> + kcs1: kcs1@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <1>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs2: kcs2@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <2>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs3: kcs3@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <3>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> };
>>> lpc_host: lpc-host@80 {
>>> @@ -294,6 +326,15 @@
>>> status = "disabled";
>>> };
>>> + kcs4: kcs4@0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0xa0>;
>>> + interrupts = <8>;
>>> + kcs_chan = <4>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> lhc: lhc@20 {
>>> compatible =
>>> "aspeed,ast2500-lhc";
>>> reg = <0x20 0x24 0x48
>>> 0x8>;
>>
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
@ 2018-05-25 11:33 ` Wang, Haiyue
0 siblings, 0 replies; 12+ messages in thread
From: Wang, Haiyue @ 2018-05-25 11:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi Joel & Andrew
This patch is out of date. ;-)
New: https://patchwork.ozlabs.org/patch/893720/
On 2018-05-25 12:34, Joel Stanley wrote:
> Hello Andrew,
>
> On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.wang@linux.intel.com> wrote:
>> Hi Joel and Andrew,
>>
>> Have time to review this patch ? Hope for your comments. :-)
>>
>> BR,
>> Haiyue
>>
>>
>> On 2018-03-07 13:04, Haiyue Wang wrote:
>>> The IPMI KCS device part of the LPC interface and is used for
>>> communication with the host processor.
>>>
>>> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> Do you have time to take a look at these? The device tree doesn't make
> sense to me.
>
> Cheers,
>
> Joel
>
>>> ---
>>> arch/arm/boot/dts/aspeed-g5.dtsi | 43
>>> +++++++++++++++++++++++++++++++++++++++-
>>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> index 8eac57c..f443169 100644
>>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> @@ -267,8 +267,40 @@
>>> ranges = <0x0 0x1e789000 0x1000>;
>>> lpc_bmc: lpc-bmc at 0 {
>>> - compatible =
>>> "aspeed,ast2500-lpc-bmc";
>>> + compatible =
>>> "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
>>> reg = <0x0 0x80>;
>>> + reg-io-width = <4>;
>>> +
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x0 0x0 0x80>;
>>> +
>>> + kcs1: kcs1 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <1>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs2: kcs2 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <2>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + kcs3: kcs3 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0x80>;
>>> + interrupts = <8>;
>>> + kcs_chan = <3>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> };
>>> lpc_host: lpc-host at 80 {
>>> @@ -294,6 +326,15 @@
>>> status = "disabled";
>>> };
>>> + kcs4: kcs4 at 0 {
>>> + compatible =
>>> "aspeed,ast2500-kcs-bmc";
>>> + reg = <0x0 0xa0>;
>>> + interrupts = <8>;
>>> + kcs_chan = <4>;
>>> + kcs_addr = <0x0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> lhc: lhc at 20 {
>>> compatible =
>>> "aspeed,ast2500-lhc";
>>> reg = <0x20 0x24 0x48
>>> 0x8>;
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-05-25 11:33 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-04 5:03 [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node Haiyue Wang
2018-03-07 3:56 ` Joel Stanley
2018-03-07 3:56 ` Joel Stanley
2018-03-07 4:41 ` Wang, Haiyue
2018-03-07 5:04 Haiyue Wang
2018-03-07 5:04 ` Haiyue Wang
2018-03-16 0:47 ` Wang, Haiyue
2018-03-16 0:47 ` Wang, Haiyue
2018-05-25 4:34 ` Joel Stanley
2018-05-25 4:34 ` Joel Stanley
2018-05-25 11:33 ` Wang, Haiyue
2018-05-25 11:33 ` Wang, Haiyue
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.