All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jeremy Kerr <jk@ozlabs.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 5/8] pinctrl: Add core support for Aspeed SoCs
Date: Tue, 30 Aug 2016 15:34:34 +0930	[thread overview]
Message-ID: <CACPK8XfiygdXaDb0Z4V_+JjDvcrST-98qqZLe6r1p8-iMqTtMg@mail.gmail.com> (raw)
In-Reply-To: <1471919451.5707.89.camel@aj.id.au>

On Tue, Aug 23, 2016 at 12:00 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Mon, 2016-08-22 at 15:45 +0200, Linus Walleij wrote:
>> On Fri, Aug 19, 2016 at 2:44 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
>>
>> >
>> > +++ b/drivers/pinctrl/aspeed/Kconfig
>> > @@ -0,0 +1,8 @@
>> > +config PINCTRL_ASPEED
>> > +       bool
>> > +       depends on (ARCH_ASPEED || COMPILE_TEST) && OF
>> > +       select PINMUX
>> > +       select PINCONF
>> > +       select GENERIC_PINCONF
>> > +       select MFD_SYSCON
>> > +       select REGMAP_MMIO
>> Since this device is spawn from the syscon, should it not be
>> "depends on MFD_SYSCON"?
>>
>> (No big deal, if you think this is right then go with it.)
>
> I think that's a fair point, I will look at rearranging it.

As discussed, lets go with Linus' suggestion.

>>
>> The expression core engine is still a complete mystery
>> for me, I will just trust you that it works as intended.
>
> Gah! However, thanks!

Does what it says on the box. Good work!

Reviewed-by: Joel Stanley <joel@jms.id.au>

  reply	other threads:[~2016-08-30  6:05 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 12:44 [PATCH v2 0/8] aspeed: Add pinctrl and gpio drivers Andrew Jeffery
2016-08-19 12:44 ` [PATCH v2 1/8] MAINTAINERS: Add glob for Aspeed devicetree bindings Andrew Jeffery
     [not found]   ` <20160819124414.24242-2-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-30  6:04     ` Joel Stanley
2016-08-30  6:04       ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 2/8] syscon: dt-bindings: Add documentation for Aspeed system control units Andrew Jeffery
2016-08-23 17:19   ` Rob Herring
2016-08-30  6:04   ` Joel Stanley
     [not found] ` <20160819124414.24242-1-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-19 12:44   ` [PATCH v2 3/8] pinctrl: dt-bindings: Add documentation for Aspeed pin controllers Andrew Jeffery
2016-08-19 12:44     ` Andrew Jeffery
     [not found]     ` <20160819124414.24242-4-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-23 17:23       ` Rob Herring
2016-08-23 17:23         ` Rob Herring
2016-08-24  0:06         ` Andrew Jeffery
2016-08-30  6:05       ` Joel Stanley
2016-08-30  6:05         ` Joel Stanley
2016-08-19 12:44   ` [PATCH v2 6/8] pinctrl: Add pinctrl-aspeed-g4 driver Andrew Jeffery
2016-08-19 12:44     ` Andrew Jeffery
2016-08-30  6:04     ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers Andrew Jeffery
     [not found]   ` <20160819124414.24242-5-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-19 14:36     ` Rob Herring
2016-08-19 14:36       ` Rob Herring
2016-08-22  0:16       ` Andrew Jeffery
2016-08-30  6:04         ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 5/8] pinctrl: Add core support for Aspeed SoCs Andrew Jeffery
     [not found]   ` <20160819124414.24242-6-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-22 13:45     ` Linus Walleij
2016-08-22 13:45       ` Linus Walleij
2016-08-23  2:30       ` Andrew Jeffery
2016-08-30  6:04         ` Joel Stanley [this message]
2016-08-19 12:44 ` [PATCH v2 7/8] pinctrl: Add pinctrl-aspeed-g5 driver Andrew Jeffery
2016-08-30  6:04   ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 8/8] gpio: Add Aspeed driver Andrew Jeffery
2016-08-22 13:48   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPK8XfiygdXaDb0Z4V_+JjDvcrST-98qqZLe6r1p8-iMqTtMg@mail.gmail.com \
    --to=joel@jms.id.au \
    --cc=andrew@aj.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=jk@ozlabs.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.