From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Andrew Jeffery <andrew-zrmu5oMJ5Fs@public.gmane.org>
Cc: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Jeremy Kerr <jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers
Date: Fri, 19 Aug 2016 09:36:42 -0500 [thread overview]
Message-ID: <20160819143641.GA19513@rob-hp-laptop> (raw)
In-Reply-To: <20160819124414.24242-5-andrew-zrmu5oMJ5Fs@public.gmane.org>
On Fri, Aug 19, 2016 at 10:14:10PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery <andrew-zrmu5oMJ5Fs@public.gmane.org>
> ---
>
> Since v1:
>
> Rob: I haven't added your Acked-by here as I've made the following changes and
> wanted to get your input:
>
> * Remove interrupt-controller as an optional property
> * Defer to interrupt-controller bindings document for sub-node properties
>
> I had a discussion with Joel about whether the interrupt-controller capability
> should be optional and the conclusion was that it should always be configured
> by the driver. This makes an optional interrupt-controller property feel
> redundant (and possibly inaccurate if left out) so I've removed it.
I don't follow. What do you mean byt "configured by the driver". If the
block supports interrupts, then it should be marked as an
interrupt-controller. It never should have been optional. The OS can
ignore the interrupt properties if it chooses.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Joel Stanley <joel@jms.id.au>,
Alexandre Courbot <gnurou@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Kerr <jk@ozlabs.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers
Date: Fri, 19 Aug 2016 09:36:42 -0500 [thread overview]
Message-ID: <20160819143641.GA19513@rob-hp-laptop> (raw)
In-Reply-To: <20160819124414.24242-5-andrew@aj.id.au>
On Fri, Aug 19, 2016 at 10:14:10PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
>
> Since v1:
>
> Rob: I haven't added your Acked-by here as I've made the following changes and
> wanted to get your input:
>
> * Remove interrupt-controller as an optional property
> * Defer to interrupt-controller bindings document for sub-node properties
>
> I had a discussion with Joel about whether the interrupt-controller capability
> should be optional and the conclusion was that it should always be configured
> by the driver. This makes an optional interrupt-controller property feel
> redundant (and possibly inaccurate if left out) so I've removed it.
I don't follow. What do you mean byt "configured by the driver". If the
block supports interrupts, then it should be marked as an
interrupt-controller. It never should have been optional. The OS can
ignore the interrupt properties if it chooses.
Rob
next prev parent reply other threads:[~2016-08-19 14:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 12:44 [PATCH v2 0/8] aspeed: Add pinctrl and gpio drivers Andrew Jeffery
2016-08-19 12:44 ` [PATCH v2 1/8] MAINTAINERS: Add glob for Aspeed devicetree bindings Andrew Jeffery
[not found] ` <20160819124414.24242-2-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-30 6:04 ` Joel Stanley
2016-08-30 6:04 ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 2/8] syscon: dt-bindings: Add documentation for Aspeed system control units Andrew Jeffery
2016-08-23 17:19 ` Rob Herring
2016-08-30 6:04 ` Joel Stanley
[not found] ` <20160819124414.24242-1-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-19 12:44 ` [PATCH v2 3/8] pinctrl: dt-bindings: Add documentation for Aspeed pin controllers Andrew Jeffery
2016-08-19 12:44 ` Andrew Jeffery
[not found] ` <20160819124414.24242-4-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-23 17:23 ` Rob Herring
2016-08-23 17:23 ` Rob Herring
2016-08-24 0:06 ` Andrew Jeffery
2016-08-30 6:05 ` Joel Stanley
2016-08-30 6:05 ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 6/8] pinctrl: Add pinctrl-aspeed-g4 driver Andrew Jeffery
2016-08-19 12:44 ` Andrew Jeffery
2016-08-30 6:04 ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers Andrew Jeffery
[not found] ` <20160819124414.24242-5-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-19 14:36 ` Rob Herring [this message]
2016-08-19 14:36 ` Rob Herring
2016-08-22 0:16 ` Andrew Jeffery
2016-08-30 6:04 ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 5/8] pinctrl: Add core support for Aspeed SoCs Andrew Jeffery
[not found] ` <20160819124414.24242-6-andrew-zrmu5oMJ5Fs@public.gmane.org>
2016-08-22 13:45 ` Linus Walleij
2016-08-22 13:45 ` Linus Walleij
2016-08-23 2:30 ` Andrew Jeffery
2016-08-30 6:04 ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 7/8] pinctrl: Add pinctrl-aspeed-g5 driver Andrew Jeffery
2016-08-30 6:04 ` Joel Stanley
2016-08-19 12:44 ` [PATCH v2 8/8] gpio: Add Aspeed driver Andrew Jeffery
2016-08-22 13:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819143641.GA19513@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=andrew-zrmu5oMJ5Fs@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.