From: Linus Walleij <linus.walleij@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs()
Date: Thu, 7 Jan 2016 10:07:51 +0100 [thread overview]
Message-ID: <CACRpkdYG77Q30J4hodKEqR2Cth==XfyqU5wi5gk3wz+YS6qJ8g@mail.gmail.com> (raw)
In-Reply-To: <1452126010-1111-1-git-send-email-linux@roeck-us.net>
On Thu, Jan 7, 2016 at 1:20 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> Commit 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") replaces
> the use of container_of() with gpiochip_get_data(). Unfortunately, the
> data pointer is not yet set by the time xgpio_save_regs() is called,
> causing a system hang.
>
> Fixes: 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> It might make sense to merge this patch with the patch introducing the problem.
Patch applied, thanks for finding and fixing this so quick!
(I hope I haven't created too many of these regressions...)
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs()
Date: Thu, 7 Jan 2016 10:07:51 +0100 [thread overview]
Message-ID: <CACRpkdYG77Q30J4hodKEqR2Cth==XfyqU5wi5gk3wz+YS6qJ8g@mail.gmail.com> (raw)
In-Reply-To: <1452126010-1111-1-git-send-email-linux@roeck-us.net>
On Thu, Jan 7, 2016 at 1:20 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> Commit 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") replaces
> the use of container_of() with gpiochip_get_data(). Unfortunately, the
> data pointer is not yet set by the time xgpio_save_regs() is called,
> causing a system hang.
>
> Fixes: 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> It might make sense to merge this patch with the patch introducing the problem.
Patch applied, thanks for finding and fixing this so quick!
(I hope I haven't created too many of these regressions...)
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-01-07 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 0:20 [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs() Guenter Roeck
2016-01-07 0:20 ` Guenter Roeck
2016-01-07 9:07 ` Linus Walleij [this message]
2016-01-07 9:07 ` Linus Walleij
2016-01-07 9:07 ` Linus Walleij
2016-01-07 14:49 ` Guenter Roeck
2016-01-07 14:49 ` Guenter Roeck
2016-01-07 14:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYG77Q30J4hodKEqR2Cth==XfyqU5wi5gk3wz+YS6qJ8g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.