From: Linus Walleij <linus.walleij@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH 05/10] ARM: realview: remove private barrier implementation
Date: Thu, 10 Dec 2015 10:09:13 +0100 [thread overview]
Message-ID: <CACRpkdYnxC3XhDZFFZMVQQGXtwCQ3kcUGaC99VRc=BuKF6pSow@mail.gmail.com> (raw)
In-Reply-To: <1448469143-447355-6-git-send-email-arnd@arndb.de>
On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The realview barrier implementation tries to avoid calling outer_sync in order
> to not lock up as a result of a bug in the l220 cache controller.
>
> This gets in the way of the multiplatform support, but we can still remove
> it if we make sure that the outer_sync function never gets called, by replacing
> the function pointer with NULL, right after initialization.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
When testing I see that this patch does not compile, but later patches
remove the offending code so it compiles again.
It needs this:
diff --git a/arch/arm/mach-realview/realview_eb.c
b/arch/arm/mach-realview/realview_eb.c
index 4d29535abeba..1a2a89708fb7 100644
--- a/arch/arm/mach-realview/realview_eb.c
+++ b/arch/arm/mach-realview/realview_eb.c
@@ -38,6 +38,7 @@
#include <asm/hardware/cache-l2x0.h>
#include <asm/smp_twd.h>
#include <asm/system_info.h>
+#include <asm/outercache.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h>
diff --git a/arch/arm/mach-realview/realview_pb11mp.c
b/arch/arm/mach-realview/realview_pb11mp.c
index f9817bb5d8fa..5bb460300b6a 100644
--- a/arch/arm/mach-realview/realview_pb11mp.c
+++ b/arch/arm/mach-realview/realview_pb11mp.c
@@ -42,6 +42,7 @@
#include <asm/mach/flash.h>
#include <asm/mach/map.h>
#include <asm/mach/time.h>
+#include <asm/outercache.h>
#include <mach/board-pb11mp.h>
#include <mach/irqs.h>
I've fixed it up in my tree, but I don't know yet if I'm getting anywhere with
this as my PB11MPCore refuse to boot with these patches. I'm trying to
find the problem...
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/10] ARM: realview: remove private barrier implementation
Date: Thu, 10 Dec 2015 10:09:13 +0100 [thread overview]
Message-ID: <CACRpkdYnxC3XhDZFFZMVQQGXtwCQ3kcUGaC99VRc=BuKF6pSow@mail.gmail.com> (raw)
In-Reply-To: <1448469143-447355-6-git-send-email-arnd@arndb.de>
On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The realview barrier implementation tries to avoid calling outer_sync in order
> to not lock up as a result of a bug in the l220 cache controller.
>
> This gets in the way of the multiplatform support, but we can still remove
> it if we make sure that the outer_sync function never gets called, by replacing
> the function pointer with NULL, right after initialization.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
When testing I see that this patch does not compile, but later patches
remove the offending code so it compiles again.
It needs this:
diff --git a/arch/arm/mach-realview/realview_eb.c
b/arch/arm/mach-realview/realview_eb.c
index 4d29535abeba..1a2a89708fb7 100644
--- a/arch/arm/mach-realview/realview_eb.c
+++ b/arch/arm/mach-realview/realview_eb.c
@@ -38,6 +38,7 @@
#include <asm/hardware/cache-l2x0.h>
#include <asm/smp_twd.h>
#include <asm/system_info.h>
+#include <asm/outercache.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h>
diff --git a/arch/arm/mach-realview/realview_pb11mp.c
b/arch/arm/mach-realview/realview_pb11mp.c
index f9817bb5d8fa..5bb460300b6a 100644
--- a/arch/arm/mach-realview/realview_pb11mp.c
+++ b/arch/arm/mach-realview/realview_pb11mp.c
@@ -42,6 +42,7 @@
#include <asm/mach/flash.h>
#include <asm/mach/map.h>
#include <asm/mach/time.h>
+#include <asm/outercache.h>
#include <mach/board-pb11mp.h>
#include <mach/irqs.h>
I've fixed it up in my tree, but I don't know yet if I'm getting anywhere with
this as my PB11MPCore refuse to boot with these patches. I'm trying to
find the problem...
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-12-10 9:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 16:32 [PATCH 00/10] ARM: realview multiplatform Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 01/10] ARM: realview: remove sparsemem hack Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 02/10] ARM: realview: don't map undefined PCI registers Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 03/10] clk/realview: stop using machine headers Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 04/10] ARM: no longer force unbuffered DMA for realview Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 05/10] ARM: realview: remove private barrier implementation Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-12-10 9:09 ` Linus Walleij [this message]
2015-12-10 9:09 ` Linus Walleij
2015-11-25 16:32 ` [PATCH 06/10] ARM: realview: enable multiplatform Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-12-10 10:04 ` Linus Walleij
2015-12-10 10:04 ` Linus Walleij
2015-12-10 10:55 ` Arnd Bergmann
2015-12-10 10:55 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 07/10] ARM: integrator: use explicit core module options Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 08/10] ARM: no longer make CPU targets visible separately Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 09/10] ARM: realview: make all header files local Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-12-10 10:06 ` Linus Walleij
2015-12-10 10:06 ` Linus Walleij
2015-11-25 16:32 ` [PATCH 10/10] ARM: realview: clean up header files Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2015-02-26 16:11 [PATCH 04/10] ARM: no longer force unbuffered DMA for realview Arnd Bergmann
2015-02-26 16:11 ` [PATCH 05/10] ARM: realview: remove private barrier implementation Arnd Bergmann
2015-02-27 12:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYnxC3XhDZFFZMVQQGXtwCQ3kcUGaC99VRc=BuKF6pSow@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.