All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 06/10] ARM: realview: enable multiplatform
Date: Thu, 10 Dec 2015 11:04:31 +0100	[thread overview]
Message-ID: <CACRpkdZwD7=h7oXdWZ6a6j5sXRcY0pKc2xuY6QsVfyNzpaWBMA@mail.gmail.com> (raw)
In-Reply-To: <1448469143-447355-7-git-send-email-arnd@arndb.de>

On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> All obstacles are out of the way by now, so we can finally move realview
> to multiplatform.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Cc: Russell King <linux@arm.linux.org.uk>
(...)

> -obj-y                                  := core.o
>  obj-$(CONFIG_REALVIEW_DT)              += realview-dt.o
> +ifdef $(CONFIG_ATAGS)
> +obj-y                                  := core.o
>  obj-$(CONFIG_MACH_REALVIEW_EB)         += realview_eb.o
>  obj-$(CONFIG_MACH_REALVIEW_PB11MP)     += realview_pb11mp.o
>  obj-$(CONFIG_MACH_REALVIEW_PB1176)     += realview_pb1176.o
>  obj-$(CONFIG_MACH_REALVIEW_PBA8)       += realview_pba8.o
>  obj-$(CONFIG_MACH_REALVIEW_PBX)                += realview_pbx.o
> +endif

This isn't working. Even if CONFIG_ATAGS is set, none of the files
inside this ifdef $(CONFIG_ATAGS) are compiled. Does Kconfig
only support if and not ifdef?

I just removed it to get things to compile. (But sadly it doesn't
boot...)

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] ARM: realview: enable multiplatform
Date: Thu, 10 Dec 2015 11:04:31 +0100	[thread overview]
Message-ID: <CACRpkdZwD7=h7oXdWZ6a6j5sXRcY0pKc2xuY6QsVfyNzpaWBMA@mail.gmail.com> (raw)
In-Reply-To: <1448469143-447355-7-git-send-email-arnd@arndb.de>

On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> All obstacles are out of the way by now, so we can finally move realview
> to multiplatform.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Cc: Russell King <linux@arm.linux.org.uk>
(...)

> -obj-y                                  := core.o
>  obj-$(CONFIG_REALVIEW_DT)              += realview-dt.o
> +ifdef $(CONFIG_ATAGS)
> +obj-y                                  := core.o
>  obj-$(CONFIG_MACH_REALVIEW_EB)         += realview_eb.o
>  obj-$(CONFIG_MACH_REALVIEW_PB11MP)     += realview_pb11mp.o
>  obj-$(CONFIG_MACH_REALVIEW_PB1176)     += realview_pb1176.o
>  obj-$(CONFIG_MACH_REALVIEW_PBA8)       += realview_pba8.o
>  obj-$(CONFIG_MACH_REALVIEW_PBX)                += realview_pbx.o
> +endif

This isn't working. Even if CONFIG_ATAGS is set, none of the files
inside this ifdef $(CONFIG_ATAGS) are compiled. Does Kconfig
only support if and not ifdef?

I just removed it to get things to compile. (But sadly it doesn't
boot...)

Yours,
Linus Walleij

  reply	other threads:[~2015-12-10 10:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 16:32 [PATCH 00/10] ARM: realview multiplatform Arnd Bergmann
2015-11-25 16:32 ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 01/10] ARM: realview: remove sparsemem hack Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 02/10] ARM: realview: don't map undefined PCI registers Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 03/10] clk/realview: stop using machine headers Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 04/10] ARM: no longer force unbuffered DMA for realview Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 05/10] ARM: realview: remove private barrier implementation Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-12-10  9:09   ` Linus Walleij
2015-12-10  9:09     ` Linus Walleij
2015-11-25 16:32 ` [PATCH 06/10] ARM: realview: enable multiplatform Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-12-10 10:04   ` Linus Walleij [this message]
2015-12-10 10:04     ` Linus Walleij
2015-12-10 10:55     ` Arnd Bergmann
2015-12-10 10:55       ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 07/10] ARM: integrator: use explicit core module options Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 08/10] ARM: no longer make CPU targets visible separately Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-11-25 16:32 ` [PATCH 09/10] ARM: realview: make all header files local Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
2015-12-10 10:06   ` Linus Walleij
2015-12-10 10:06     ` Linus Walleij
2015-11-25 16:32 ` [PATCH 10/10] ARM: realview: clean up header files Arnd Bergmann
2015-11-25 16:32   ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2015-02-26 16:11 [PATCH 04/10] ARM: no longer force unbuffered DMA for realview Arnd Bergmann
2015-02-26 16:11 ` [PATCH 06/10] ARM: realview: enable multiplatform Arnd Bergmann
2015-02-27 12:19   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZwD7=h7oXdWZ6a6j5sXRcY0pKc2xuY6QsVfyNzpaWBMA@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.