From: Linus Walleij <linus.walleij@linaro.org>
To: Markuss Broks <markuss.broks@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel
Date: Sun, 8 Aug 2021 00:37:57 +0200 [thread overview]
Message-ID: <CACRpkdYu5fdLvSYPV=fs0ry59abpTWoVVkKpd9cApSbmyssjmw@mail.gmail.com> (raw)
In-Reply-To: <20210807133111.5935-3-markuss.broks@gmail.com>
Hi Markuss,
this is looking really good, the following is just nitty gritty details
I could fix while applying, we're mostly waiting for DT review now.
On Sat, Aug 7, 2021 at 3:31 PM Markuss Broks <markuss.broks@gmail.com> wrote:
> + /*
> + * Exit sleep mode and initialize display - some hammering is
> + * necessary.
> + */
> + mipi_dbi_command(dbi, MIPI_DCS_EXIT_SLEEP_MODE);
> + mipi_dbi_command(dbi, MIPI_DCS_EXIT_SLEEP_MODE);
Check if this hammering is really necessary on s6d27a1, on Widechips
this is just a bug, what happens if you put just one of them?
> + msleep(50);
This should be msleep(120) on s6d27a1 (according to board-codina-mcde.c)
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-08-07 22:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 13:54 [PATCH] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel Markuss Broks
2021-08-03 14:45 ` Sam Ravnborg
2021-08-03 17:24 ` [PATCH v2] " Markuss Broks
2021-08-03 18:11 ` Sam Ravnborg
2021-08-05 13:33 ` [PATCH 0/2] Add support " Markuss Broks
2021-08-05 13:33 ` [PATCH 1/2] drm/panel: Add DT bindings " Markuss Broks
2021-08-05 19:18 ` Sam Ravnborg
2021-08-05 13:33 ` [PATCH 2/2] drm/panel: s6d27a1: Add driver " Markuss Broks
2021-08-05 19:25 ` Sam Ravnborg
2021-08-07 13:31 ` [PATCH 0/2] Add support " Markuss Broks
2021-08-07 13:31 ` [PATCH v2 1/2] drm/panel: Add DT bindings " Markuss Broks
2021-08-07 22:41 ` Linus Walleij
2021-08-07 22:41 ` Linus Walleij
2021-08-13 20:41 ` Rob Herring
2021-08-07 13:31 ` [PATCH v2 2/2] drm/panel: s6d27a1: Add driver " Markuss Broks
2021-08-07 22:37 ` Linus Walleij [this message]
2021-08-07 22:37 ` Linus Walleij
2021-08-13 13:54 ` Linus Walleij
2021-08-13 13:54 ` Linus Walleij
2021-08-05 21:06 ` [PATCH " Linus Walleij
2021-08-05 21:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYu5fdLvSYPV=fs0ry59abpTWoVVkKpd9cApSbmyssjmw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.