All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Markuss Broks <markuss.broks@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	phone-devel@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel
Date: Thu, 5 Aug 2021 23:06:30 +0200	[thread overview]
Message-ID: <CACRpkdZXRtP4Z2UEQz-gwuPFkVhXTth0nFDioO9a+JKOtHXU4w@mail.gmail.com> (raw)
In-Reply-To: <20210805133343.27032-3-markuss.broks@gmail.com>

Hi Markuss,

sorry for reacting so late!

On Thu, Aug 5, 2021 at 3:36 PM Markuss Broks <markuss.broks@gmail.com> wrote:

> +#define s6d27a1_command(ctx, cmd, seq...) \
> +({ \
> +       struct mipi_dbi *dbi = &ctx->dbi; \
> +       int ret; \
> +       ret = mipi_dbi_command(dbi, cmd, seq);  \
> +       if (ret) { \
> +               dev_err(ctx->dev, "failure in writing command %02x\n", cmd); \
> +       } \
> +})

You don't need this wrapper anymore, just call mipi_dbi_command() directly
everywhere you use s6d27a1_command().

Because I merged this patch:
https://cgit.freedesktop.org/drm/drm-misc/commit/include/drm/drm_mipi_dbi.h?id=3f5aa5ac0b0f9704f0c60f5fbbbcdc8c043d6eb6

Yours,
Linus Walleij

  parent reply	other threads:[~2021-08-05 21:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 13:54 [PATCH] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel Markuss Broks
2021-08-03 14:45 ` Sam Ravnborg
2021-08-03 17:24   ` [PATCH v2] " Markuss Broks
2021-08-03 18:11     ` Sam Ravnborg
2021-08-05 13:33       ` [PATCH 0/2] Add support " Markuss Broks
2021-08-05 13:33         ` [PATCH 1/2] drm/panel: Add DT bindings " Markuss Broks
2021-08-05 19:18           ` Sam Ravnborg
2021-08-05 13:33         ` [PATCH 2/2] drm/panel: s6d27a1: Add driver " Markuss Broks
2021-08-05 19:25           ` Sam Ravnborg
2021-08-07 13:31             ` [PATCH 0/2] Add support " Markuss Broks
2021-08-07 13:31               ` [PATCH v2 1/2] drm/panel: Add DT bindings " Markuss Broks
2021-08-07 22:41                 ` Linus Walleij
2021-08-07 22:41                   ` Linus Walleij
2021-08-13 20:41                 ` Rob Herring
2021-08-07 13:31               ` [PATCH v2 2/2] drm/panel: s6d27a1: Add driver " Markuss Broks
2021-08-07 22:37                 ` Linus Walleij
2021-08-07 22:37                   ` Linus Walleij
2021-08-13 13:54                 ` Linus Walleij
2021-08-13 13:54                   ` Linus Walleij
2021-08-05 21:06           ` Linus Walleij [this message]
2021-08-05 21:06             ` [PATCH " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZXRtP4Z2UEQz-gwuPFkVhXTth0nFDioO9a+JKOtHXU4w@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markuss.broks@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.