From: Linus Walleij <linus.walleij@linaro.org>
To: Aman Sharma <amanharitsh123@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Bjorn Helgaas <bhelgaas@google.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Mans Rullgard <mans@mansr.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pci <linux-pci@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 1/5] pci: handled return value of platform_get_irq correctly
Date: Thu, 12 Mar 2020 15:07:58 +0100 [thread overview]
Message-ID: <CACRpkdYv0U0RmT7snp+UejEXecq4wLkhc11DUniUfGYAgyXC=A@mail.gmail.com> (raw)
In-Reply-To: <d12a15f496ca472e100798ac2cd256fbfc1de15d.1583952276.git.amanharitsh123@gmail.com>
On Wed, Mar 11, 2020 at 8:19 PM Aman Sharma <amanharitsh123@gmail.com> wrote:
> Signed-off-by: Aman Sharma <amanharitsh123@gmail.com>
> ---
> drivers/pci/controller/pci-v3-semi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index bd05221f5a22..a5bf945d2eda 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -777,9 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev)
>
> /* Get and request error IRQ resource */
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0) {
> + if (irq < 0) {
Have you considered:
https://lwn.net/Articles/470820/
TL;DR Linus (both of them) are not with you on this.
And that is why the code is written like this.
Do you really have a platform that could return 0 as IRQ
here? In that case, can we fix it?
> dev_err(dev, "unable to obtain PCIv3 error IRQ\n");
> - return -ENODEV;
> + return irq;
That's OK with me.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Aman Sharma <amanharitsh123@gmail.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
linux-pci <linux-pci@vger.kernel.org>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mans Rullgard <mans@mansr.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Andrew Murray <amurray@thegoodpenguin.co.uk>
Subject: Re: [PATCH 1/5] pci: handled return value of platform_get_irq correctly
Date: Thu, 12 Mar 2020 15:07:58 +0100 [thread overview]
Message-ID: <CACRpkdYv0U0RmT7snp+UejEXecq4wLkhc11DUniUfGYAgyXC=A@mail.gmail.com> (raw)
In-Reply-To: <d12a15f496ca472e100798ac2cd256fbfc1de15d.1583952276.git.amanharitsh123@gmail.com>
On Wed, Mar 11, 2020 at 8:19 PM Aman Sharma <amanharitsh123@gmail.com> wrote:
> Signed-off-by: Aman Sharma <amanharitsh123@gmail.com>
> ---
> drivers/pci/controller/pci-v3-semi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index bd05221f5a22..a5bf945d2eda 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -777,9 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev)
>
> /* Get and request error IRQ resource */
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0) {
> + if (irq < 0) {
Have you considered:
https://lwn.net/Articles/470820/
TL;DR Linus (both of them) are not with you on this.
And that is why the code is written like this.
Do you really have a platform that could return 0 as IRQ
here? In that case, can we fix it?
> dev_err(dev, "unable to obtain PCIv3 error IRQ\n");
> - return -ENODEV;
> + return irq;
That's OK with me.
Yours,
Linus Walleij
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Aman Sharma <amanharitsh123@gmail.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
linux-pci <linux-pci@vger.kernel.org>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mans Rullgard <mans@mansr.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Andrew Murray <amurray@thegoodpenguin.co.uk>
Subject: Re: [PATCH 1/5] pci: handled return value of platform_get_irq correctly
Date: Thu, 12 Mar 2020 15:07:58 +0100 [thread overview]
Message-ID: <CACRpkdYv0U0RmT7snp+UejEXecq4wLkhc11DUniUfGYAgyXC=A@mail.gmail.com> (raw)
In-Reply-To: <d12a15f496ca472e100798ac2cd256fbfc1de15d.1583952276.git.amanharitsh123@gmail.com>
On Wed, Mar 11, 2020 at 8:19 PM Aman Sharma <amanharitsh123@gmail.com> wrote:
> Signed-off-by: Aman Sharma <amanharitsh123@gmail.com>
> ---
> drivers/pci/controller/pci-v3-semi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index bd05221f5a22..a5bf945d2eda 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -777,9 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev)
>
> /* Get and request error IRQ resource */
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0) {
> + if (irq < 0) {
Have you considered:
https://lwn.net/Articles/470820/
TL;DR Linus (both of them) are not with you on this.
And that is why the code is written like this.
Do you really have a platform that could return 0 as IRQ
here? In that case, can we fix it?
> dev_err(dev, "unable to obtain PCIv3 error IRQ\n");
> - return -ENODEV;
> + return irq;
That's OK with me.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-12 14:08 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 19:19 [PATCH 0/5] Handled return value of platform_get_irq correctly Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` [PATCH 1/5] pci: handled " Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 20:57 ` Bjorn Helgaas
2020-04-06 21:28 ` Bjorn Helgaas
2020-03-12 14:07 ` Linus Walleij [this message]
2020-03-12 14:07 ` Linus Walleij
2020-03-12 14:07 ` Linus Walleij
2020-03-12 19:02 ` Bjorn Helgaas
2020-03-12 19:02 ` Bjorn Helgaas
2020-03-12 19:02 ` Bjorn Helgaas
2020-03-12 22:45 ` Linus Walleij
2020-03-12 22:45 ` Linus Walleij
2020-03-12 22:45 ` Linus Walleij
2020-03-11 19:19 ` [PATCH 2/5] pci: added check for return value of platform_get_irq Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` [PATCH 3/5] pci: handled return value of platform_get_irq correctly Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` [PATCH 4/5] " Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-12 9:53 ` Marc Gonzalez
2020-03-12 9:53 ` Marc Gonzalez
2020-03-12 9:53 ` Marc Gonzalez
2020-03-12 14:11 ` Bjorn Helgaas
2020-03-12 14:11 ` Bjorn Helgaas
2020-03-12 14:11 ` Bjorn Helgaas
2020-03-12 15:53 ` Marc Gonzalez
2020-03-12 15:53 ` Marc Gonzalez
2020-03-12 15:53 ` Marc Gonzalez
2020-03-13 21:05 ` Thomas Gleixner
2020-03-13 21:05 ` Thomas Gleixner
2020-03-13 21:05 ` Thomas Gleixner
2020-03-13 21:56 ` Bjorn Helgaas
2020-03-13 21:56 ` Bjorn Helgaas
2020-03-13 21:56 ` Bjorn Helgaas
2020-03-17 22:03 ` Bjorn Helgaas
2020-03-17 22:03 ` Bjorn Helgaas
2020-03-17 22:03 ` Bjorn Helgaas
2020-03-18 13:42 ` Thomas Gleixner
2020-03-18 13:42 ` Thomas Gleixner
2020-03-18 13:42 ` Thomas Gleixner
2020-03-18 22:22 ` Bjorn Helgaas
2020-03-18 22:22 ` Bjorn Helgaas
2020-03-18 22:22 ` Bjorn Helgaas
2020-03-19 8:47 ` Thomas Gleixner
2020-03-19 8:47 ` Thomas Gleixner
2020-03-19 8:47 ` Thomas Gleixner
2020-03-19 21:35 ` Bjorn Helgaas
2020-03-19 21:35 ` Bjorn Helgaas
2020-03-19 21:35 ` Bjorn Helgaas
2020-03-11 19:19 ` [PATCH 5/5] pci: added check for return value of platform_get_irq Aman Sharma
2020-03-11 19:19 ` Aman Sharma
2020-03-11 19:19 ` Aman Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYv0U0RmT7snp+UejEXecq4wLkhc11DUniUfGYAgyXC=A@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Zhiqiang.Hou@nxp.com \
--cc=amanharitsh123@gmail.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m.karthikeyan@mobiveil.co.in \
--cc=mans@mansr.com \
--cc=marc.w.gonzalez@free.fr \
--cc=matthias.bgg@gmail.com \
--cc=ryder.lee@mediatek.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.