From: Linus Walleij <linus.walleij@linaro.org> To: Baruch Siach <baruch@tkos.co.il>, Rob Herring <robh@kernel.org> Cc: "Thierry Reding" <thierry.reding@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Lee Jones" <lee.jones@linaro.org>, "Bartosz Golaszewski" <bgolaszewski@baylibre.com>, "Rob Herring" <robh+dt@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>, "Gregory Clement" <gregory.clement@bootlin.com>, "Russell King" <linux@armlinux.org.uk>, "Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>, "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>, "Chris Packham" <chris.packham@alliedtelesis.co.nz>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Ralph Sennhauser" <ralph.sennhauser@gmail.com>, linux-pwm@vger.kernel.org, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, "Linux ARM" <linux-arm-kernel@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org> Subject: Re: [PATCH v7 3/3] dt-bindings: ap806: document gpio marvell,pwm-offset property Date: Tue, 12 Jan 2021 09:49:16 +0100 [thread overview] Message-ID: <CACRpkdZAHpcgzXSJKZyQjBOriALZUoXbw_hBpPa_zxa27=F0hg@mail.gmail.com> (raw) In-Reply-To: <5e1b119a51df19ead32561e87ce2ee1441b67154.1610364681.git.baruch@tkos.co.il> Hi Baruch, this caught my eye: On Mon, Jan 11, 2021 at 12:47 PM Baruch Siach <baruch@tkos.co.il> wrote: > Update the example as well. Add the '#pwm-cells' and 'clocks' properties > for a complete working example. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> (...) > +Optional properties: > + > +- marvell,pwm-offset: offset address of PWM duration control registers inside > + the syscon block (...) > ap_syscon: system-controller@6f4000 { > compatible = "syscon", "simple-mfd"; > @@ -101,6 +106,9 @@ ap_syscon: system-controller@6f4000 { > gpio-controller; > #gpio-cells = <2>; > gpio-ranges = <&ap_pinctrl 0 0 19>; > + marvell,pwm-offset = <0x10c0>; This seems to be one of those cases where we start to encode things related to the hardware variant into the device tree. Is this just documenting ABI that was introduced in the past and we can not do anything about now? In that case it is OK I suppose. For a new binding we would certainly require that the system controller provide a specific tertiary compatible string for this, lest we disguise the not-so-simple system controller as "simple-mfd" so: compatible = "syscon", "simple-mfd", "my-silicon-id"; Then detect the PWM offset by using if(of_device_is_compatibe(np, "my-silicon-id")) in the code rather than parsing any marvell,pwm-offset property. Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org> To: Baruch Siach <baruch@tkos.co.il>, Rob Herring <robh@kernel.org> Cc: "Andrew Lunn" <andrew@lunn.ch>, linux-pwm@vger.kernel.org, "Gregory Clement" <gregory.clement@bootlin.com>, "Chris Packham" <chris.packham@alliedtelesis.co.nz>, "Russell King" <linux@armlinux.org.uk>, "Rob Herring" <robh+dt@kernel.org>, "Bartosz Golaszewski" <bgolaszewski@baylibre.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "Thierry Reding" <thierry.reding@gmail.com>, "Linux ARM" <linux-arm-kernel@lists.infradead.org>, "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Ralph Sennhauser" <ralph.sennhauser@gmail.com>, "Lee Jones" <lee.jones@linaro.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, "Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com> Subject: Re: [PATCH v7 3/3] dt-bindings: ap806: document gpio marvell,pwm-offset property Date: Tue, 12 Jan 2021 09:49:16 +0100 [thread overview] Message-ID: <CACRpkdZAHpcgzXSJKZyQjBOriALZUoXbw_hBpPa_zxa27=F0hg@mail.gmail.com> (raw) In-Reply-To: <5e1b119a51df19ead32561e87ce2ee1441b67154.1610364681.git.baruch@tkos.co.il> Hi Baruch, this caught my eye: On Mon, Jan 11, 2021 at 12:47 PM Baruch Siach <baruch@tkos.co.il> wrote: > Update the example as well. Add the '#pwm-cells' and 'clocks' properties > for a complete working example. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> (...) > +Optional properties: > + > +- marvell,pwm-offset: offset address of PWM duration control registers inside > + the syscon block (...) > ap_syscon: system-controller@6f4000 { > compatible = "syscon", "simple-mfd"; > @@ -101,6 +106,9 @@ ap_syscon: system-controller@6f4000 { > gpio-controller; > #gpio-cells = <2>; > gpio-ranges = <&ap_pinctrl 0 0 19>; > + marvell,pwm-offset = <0x10c0>; This seems to be one of those cases where we start to encode things related to the hardware variant into the device tree. Is this just documenting ABI that was introduced in the past and we can not do anything about now? In that case it is OK I suppose. For a new binding we would certainly require that the system controller provide a specific tertiary compatible string for this, lest we disguise the not-so-simple system controller as "simple-mfd" so: compatible = "syscon", "simple-mfd", "my-silicon-id"; Then detect the PWM offset by using if(of_device_is_compatibe(np, "my-silicon-id")) in the code rather than parsing any marvell,pwm-offset property. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-12 8:50 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-11 11:46 [PATCH v7 0/3] gpio: mvebu: Armada 8K/7K PWM support Baruch Siach 2021-01-11 11:46 ` Baruch Siach 2021-01-11 11:46 ` [PATCH v7 1/3] gpio: mvebu: add pwm support for Armada 8K/7K Baruch Siach 2021-01-11 11:46 ` Baruch Siach 2021-01-22 12:58 ` Bartosz Golaszewski 2021-01-22 12:58 ` Bartosz Golaszewski 2021-01-24 6:17 ` Baruch Siach 2021-01-24 6:17 ` Baruch Siach 2021-01-11 11:46 ` [PATCH v7 2/3] arm64: dts: armada: add pwm offsets for ap/cp gpios Baruch Siach 2021-01-11 11:46 ` Baruch Siach 2021-01-25 9:50 ` Bartosz Golaszewski 2021-01-25 9:50 ` Bartosz Golaszewski 2021-01-29 15:56 ` Gregory CLEMENT 2021-02-02 11:27 ` Bartosz Golaszewski 2021-02-02 11:27 ` Bartosz Golaszewski 2021-01-29 15:55 ` Gregory CLEMENT 2021-01-29 15:55 ` Gregory CLEMENT 2021-01-11 11:46 ` [PATCH v7 3/3] dt-bindings: ap806: document gpio marvell,pwm-offset property Baruch Siach 2021-01-11 11:46 ` [PATCH v7 3/3] dt-bindings: ap806: document gpio marvell, pwm-offset property Baruch Siach 2021-01-12 8:49 ` Linus Walleij [this message] 2021-01-12 8:49 ` [PATCH v7 3/3] dt-bindings: ap806: document gpio marvell,pwm-offset property Linus Walleij 2021-01-12 10:36 ` Russell King - ARM Linux admin 2021-01-12 10:36 ` Russell King - ARM Linux admin 2021-01-18 13:37 ` Linus Walleij 2021-01-18 13:37 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACRpkdZAHpcgzXSJKZyQjBOriALZUoXbw_hBpPa_zxa27=F0hg@mail.gmail.com' \ --to=linus.walleij@linaro.org \ --cc=andrew@lunn.ch \ --cc=baruch@tkos.co.il \ --cc=bgolaszewski@baylibre.com \ --cc=chris.packham@alliedtelesis.co.nz \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=ralph.sennhauser@gmail.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sebastian.hesselbarth@gmail.com \ --cc=thierry.reding@gmail.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.