From: Linus Walleij <linus.walleij@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
tzimmermann@suse.de, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org,
thierry.reding@gmail.com, Chris Morgan <macromorgan@hotmail.com>,
Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [PATCH V5 3/4] drm/panel: Add Magnachip D53E6EA8966 Panel Driver
Date: Thu, 15 Dec 2022 11:37:03 +0100 [thread overview]
Message-ID: <CACRpkdZjX7E7Sm7F5sPCwUmnnw6A9imYwytfSb_R1S_qsdgo0A@mail.gmail.com> (raw)
In-Reply-To: <20221214180611.109651-4-macroalpha82@gmail.com>
Hi Chris,
looks good to me, just very minor nitpicks:
On Wed, Dec 14, 2022 at 7:06 PM Chris Morgan <macroalpha82@gmail.com> wrote:
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Support Magnachip D53E6EA8966 based panels such as the Samsung
> AMS495QA01 panel as found on the Anbernic RG503. Note this driver
> supports only the AMS495QA01 today which receives video signals via DSI,
> however it receives commands via 3-wire SPI.
using DBI.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Is your Kconfig snippet missing:
depends on BACKLIGHT_CLASS_DEVICE
?
> +#include <linux/of_device.h>
> +#include <linux/of_graph.h>
Not needed anymore, right?
With these fixed:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: devicetree@vger.kernel.org,
Chris Morgan <macromorgan@hotmail.com>,
krzysztof.kozlowski+dt@linaro.org, sam@ravnborg.org,
robh+dt@kernel.org, thierry.reding@gmail.com,
dri-devel@lists.freedesktop.org, tzimmermann@suse.de,
Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [PATCH V5 3/4] drm/panel: Add Magnachip D53E6EA8966 Panel Driver
Date: Thu, 15 Dec 2022 11:37:03 +0100 [thread overview]
Message-ID: <CACRpkdZjX7E7Sm7F5sPCwUmnnw6A9imYwytfSb_R1S_qsdgo0A@mail.gmail.com> (raw)
In-Reply-To: <20221214180611.109651-4-macroalpha82@gmail.com>
Hi Chris,
looks good to me, just very minor nitpicks:
On Wed, Dec 14, 2022 at 7:06 PM Chris Morgan <macroalpha82@gmail.com> wrote:
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Support Magnachip D53E6EA8966 based panels such as the Samsung
> AMS495QA01 panel as found on the Anbernic RG503. Note this driver
> supports only the AMS495QA01 today which receives video signals via DSI,
> however it receives commands via 3-wire SPI.
using DBI.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Is your Kconfig snippet missing:
depends on BACKLIGHT_CLASS_DEVICE
?
> +#include <linux/of_device.h>
> +#include <linux/of_graph.h>
Not needed anymore, right?
With these fixed:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-12-15 10:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 18:06 [PATCH V5 0/4] drm/panel: Add Magnachip D53E6EA8966 Panel Controller Chris Morgan
2022-12-14 18:06 ` Chris Morgan
2022-12-14 18:06 ` [PATCH V5 1/4] drm: of: Add drm_of_get_dsi_bus helper function Chris Morgan
2022-12-14 18:06 ` Chris Morgan
2022-12-15 10:30 ` Linus Walleij
2022-12-15 10:30 ` Linus Walleij
2022-12-14 18:06 ` [PATCH V5 2/4] dt-bindings: display: panel: Add Magnachip D53E6EA8966 Chris Morgan
2022-12-14 18:06 ` Chris Morgan
2022-12-14 20:54 ` Rob Herring
2022-12-14 20:54 ` Rob Herring
2022-12-15 8:47 ` Linus Walleij
2022-12-15 8:47 ` Linus Walleij
2022-12-15 14:44 ` Chris Morgan
2022-12-15 14:44 ` Chris Morgan
2022-12-15 16:16 ` Rob Herring
2022-12-15 16:16 ` Rob Herring
2022-12-14 18:06 ` [PATCH V5 3/4] drm/panel: Add Magnachip D53E6EA8966 Panel Driver Chris Morgan
2022-12-14 18:06 ` Chris Morgan
2022-12-15 10:37 ` Linus Walleij [this message]
2022-12-15 10:37 ` Linus Walleij
2022-12-14 18:06 ` [PATCH V4 4/4] arm64: dts: rockchip: add display to RG503 Chris Morgan
2022-12-14 18:06 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZjX7E7Sm7F5sPCwUmnnw6A9imYwytfSb_R1S_qsdgo0A@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maccraft123mc@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.