All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Morgan <macromorgan@hotmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chris Morgan <macroalpha82@gmail.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	tzimmermann@suse.de, mripard@kernel.org,
	maarten.lankhorst@linux.intel.com, heiko@sntech.de,
	krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org,
	thierry.reding@gmail.com,
	Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [PATCH V5 2/4] dt-bindings: display: panel: Add Magnachip D53E6EA8966
Date: Thu, 15 Dec 2022 08:44:56 -0600	[thread overview]
Message-ID: <SN6PR06MB53429788776760E4BDBC55ABA5E19@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <CACRpkdY7UArNJ5ZH8f5rx+9aoV_ii=0aE9PCj-6XHCL7Om0+=Q@mail.gmail.com>

On Thu, Dec 15, 2022 at 09:47:19AM +0100, Linus Walleij wrote:
> On Wed, Dec 14, 2022 at 7:06 PM Chris Morgan <macroalpha82@gmail.com> wrote:
> 
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Add documentation for Magnachip D53E6EA8966 based panels such as the
> > Samsung AMS495QA01 panel.
> >
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> (...)
> >  .../display/panel/magnachip,d53e6ea8966.yaml  | 62 +++++++++++++++++++
> 
> It's fine to keep this as samsung,ams495qa01.
> 

Would the device tree team be okay with that change? The driver name
itself has changed and I fear possible confusion if someone is looking
for docs by driver name.

Otherwise I noticed I had an outdated version of the dt-schema and
missed an error, so I have to resubmit either way to fix it. The
horrors of upgrading your build machine...

Thank you

> Just mention that it uses the magnachip controller in the
> description.
> 
> That Linux implements this with a generic driver that handles
> all (in theory possible) magnachip-based products is a linuxism
> and does not need to be in the bindings.
> 
> Yours,
> Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macromorgan@hotmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	sam@ravnborg.org, Chris Morgan <macroalpha82@gmail.com>,
	robh+dt@kernel.org, thierry.reding@gmail.com,
	dri-devel@lists.freedesktop.org, tzimmermann@suse.de,
	Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [PATCH V5 2/4] dt-bindings: display: panel: Add Magnachip D53E6EA8966
Date: Thu, 15 Dec 2022 08:44:56 -0600	[thread overview]
Message-ID: <SN6PR06MB53429788776760E4BDBC55ABA5E19@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <CACRpkdY7UArNJ5ZH8f5rx+9aoV_ii=0aE9PCj-6XHCL7Om0+=Q@mail.gmail.com>

On Thu, Dec 15, 2022 at 09:47:19AM +0100, Linus Walleij wrote:
> On Wed, Dec 14, 2022 at 7:06 PM Chris Morgan <macroalpha82@gmail.com> wrote:
> 
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Add documentation for Magnachip D53E6EA8966 based panels such as the
> > Samsung AMS495QA01 panel.
> >
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> (...)
> >  .../display/panel/magnachip,d53e6ea8966.yaml  | 62 +++++++++++++++++++
> 
> It's fine to keep this as samsung,ams495qa01.
> 

Would the device tree team be okay with that change? The driver name
itself has changed and I fear possible confusion if someone is looking
for docs by driver name.

Otherwise I noticed I had an outdated version of the dt-schema and
missed an error, so I have to resubmit either way to fix it. The
horrors of upgrading your build machine...

Thank you

> Just mention that it uses the magnachip controller in the
> description.
> 
> That Linux implements this with a generic driver that handles
> all (in theory possible) magnachip-based products is a linuxism
> and does not need to be in the bindings.
> 
> Yours,
> Linus Walleij

  reply	other threads:[~2022-12-15 14:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 18:06 [PATCH V5 0/4] drm/panel: Add Magnachip D53E6EA8966 Panel Controller Chris Morgan
2022-12-14 18:06 ` Chris Morgan
2022-12-14 18:06 ` [PATCH V5 1/4] drm: of: Add drm_of_get_dsi_bus helper function Chris Morgan
2022-12-14 18:06   ` Chris Morgan
2022-12-15 10:30   ` Linus Walleij
2022-12-15 10:30     ` Linus Walleij
2022-12-14 18:06 ` [PATCH V5 2/4] dt-bindings: display: panel: Add Magnachip D53E6EA8966 Chris Morgan
2022-12-14 18:06   ` Chris Morgan
2022-12-14 20:54   ` Rob Herring
2022-12-14 20:54     ` Rob Herring
2022-12-15  8:47   ` Linus Walleij
2022-12-15  8:47     ` Linus Walleij
2022-12-15 14:44     ` Chris Morgan [this message]
2022-12-15 14:44       ` Chris Morgan
2022-12-15 16:16       ` Rob Herring
2022-12-15 16:16         ` Rob Herring
2022-12-14 18:06 ` [PATCH V5 3/4] drm/panel: Add Magnachip D53E6EA8966 Panel Driver Chris Morgan
2022-12-14 18:06   ` Chris Morgan
2022-12-15 10:37   ` Linus Walleij
2022-12-15 10:37     ` Linus Walleij
2022-12-14 18:06 ` [PATCH V4 4/4] arm64: dts: rockchip: add display to RG503 Chris Morgan
2022-12-14 18:06   ` Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR06MB53429788776760E4BDBC55ABA5E19@SN6PR06MB5342.namprd06.prod.outlook.com \
    --to=macromorgan@hotmail.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maccraft123mc@gmail.com \
    --cc=macroalpha82@gmail.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.