All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static
Date: Wed, 2 May 2018 13:46:19 +0200	[thread overview]
Message-ID: <CACRpkdac_qa6-pZ3+OjrWw-w3O8ihj_yQBM3XJQxtiOUpryFRQ@mail.gmail.com> (raw)
In-Reply-To: <20180430130434.1361-1-colin.king@canonical.com>

On Mon, Apr 30, 2018 at 3:04 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> s900_functions, s900_padinfo and s900_pads are local to the source and do
> not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> drivers/pinctrl/actions/pinctrl-s900.c:1445:30: warning: symbol
> 's900_functions' was not declared. Should it be static?
> drivers/pinctrl/actions/pinctrl-s900.c:1664:20: warning: symbol
> 's900_padinfo' was not declared. Should it be static?
> drivers/pinctrl/actions/pinctrl-s900.c:207:31: warning: symbol
> 's900_pads' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied with Manivannan's ACK, I got the same patch from
the 0day build robot, but I prefer human contributors to I pick
this one.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static
Date: Wed, 02 May 2018 11:46:19 +0000	[thread overview]
Message-ID: <CACRpkdac_qa6-pZ3+OjrWw-w3O8ihj_yQBM3XJQxtiOUpryFRQ@mail.gmail.com> (raw)
In-Reply-To: <20180430130434.1361-1-colin.king@canonical.com>

On Mon, Apr 30, 2018 at 3:04 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> s900_functions, s900_padinfo and s900_pads are local to the source and do
> not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> drivers/pinctrl/actions/pinctrl-s900.c:1445:30: warning: symbol
> 's900_functions' was not declared. Should it be static?
> drivers/pinctrl/actions/pinctrl-s900.c:1664:20: warning: symbol
> 's900_padinfo' was not declared. Should it be static?
> drivers/pinctrl/actions/pinctrl-s900.c:207:31: warning: symbol
> 's900_pads' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied with Manivannan's ACK, I got the same patch from
the 0day build robot, but I prefer human contributors to I pick
this one.

Yours,
Linus Walleij

  parent reply	other threads:[~2018-05-02 11:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 13:04 [PATCH][next] pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static Colin King
2018-04-30 13:04 ` Colin King
2018-04-30 13:26 ` Manivannan Sadhasivam
2018-04-30 13:38   ` Manivannan Sadhasivam
2018-05-02 11:46 ` Linus Walleij [this message]
2018-05-02 11:46   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdac_qa6-pZ3+OjrWw-w3O8ihj_yQBM3XJQxtiOUpryFRQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.