* [PATCH 0/2] add support for the SDIO pins on GXBB @ 2016-08-28 16:47 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linux-gpio, linux-amlogic, linus.walleij, khilman, carlo Cc: linux-arm-kernel, Martin Blumenstingl This series adds the pins for the SDIO controller (sd_emmc_a) found on Meson GXBB SoCs. Martin Blumenstingl (2): pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller ARM64: dts: meson-gxbb: add the SDIO pins arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 12 ++++++++++++ drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 19 +++++++++++++++++++ 2 files changed, 31 insertions(+) -- 2.9.3 ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 0/2] add support for the SDIO pins on GXBB @ 2016-08-28 16:47 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linus-amlogic This series adds the pins for the SDIO controller (sd_emmc_a) found on Meson GXBB SoCs. Martin Blumenstingl (2): pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller ARM64: dts: meson-gxbb: add the SDIO pins arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 12 ++++++++++++ drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 19 +++++++++++++++++++ 2 files changed, 31 insertions(+) -- 2.9.3 ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 0/2] add support for the SDIO pins on GXBB @ 2016-08-28 16:47 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linux-arm-kernel This series adds the pins for the SDIO controller (sd_emmc_a) found on Meson GXBB SoCs. Martin Blumenstingl (2): pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller ARM64: dts: meson-gxbb: add the SDIO pins arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 12 ++++++++++++ drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 19 +++++++++++++++++++ 2 files changed, 31 insertions(+) -- 2.9.3 ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller 2016-08-28 16:47 ` Martin Blumenstingl (?) @ 2016-08-28 16:47 ` Martin Blumenstingl -1 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linux-gpio, linux-amlogic, linus.walleij, khilman, carlo Cc: linux-arm-kernel, Martin Blumenstingl sd_emmc_a is used a controller for the SDIO modules. This adds the pin configuration for the SDIO controller. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index 77da6dd..fb479b8 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -163,6 +163,13 @@ static const unsigned int sdcard_d3_pins[] = { PIN(CARD_4, EE_OFF) }; static const unsigned int sdcard_cmd_pins[] = { PIN(CARD_3, EE_OFF) }; static const unsigned int sdcard_clk_pins[] = { PIN(CARD_2, EE_OFF) }; +static const unsigned int sdio_d0_pins[] = { PIN(GPIOX_0, EE_OFF) }; +static const unsigned int sdio_d1_pins[] = { PIN(GPIOX_1, EE_OFF) }; +static const unsigned int sdio_d2_pins[] = { PIN(GPIOX_2, EE_OFF) }; +static const unsigned int sdio_d3_pins[] = { PIN(GPIOX_3, EE_OFF) }; +static const unsigned int sdio_cmd_pins[] = { PIN(GPIOX_4, EE_OFF) }; +static const unsigned int sdio_clk_pins[] = { PIN(GPIOX_5, EE_OFF) }; + static const unsigned int uart_tx_a_pins[] = { PIN(GPIOX_12, EE_OFF) }; static const unsigned int uart_rx_a_pins[] = { PIN(GPIOX_13, EE_OFF) }; static const unsigned int uart_cts_a_pins[] = { PIN(GPIOX_14, EE_OFF) }; @@ -370,6 +377,12 @@ static struct meson_pmx_group meson_gxbb_periphs_groups[] = { GPIO_GROUP(GPIO_TEST_N, EE_OFF), /* Bank X */ + GROUP(sdio_d0, 8, 5), + GROUP(sdio_d1, 8, 4), + GROUP(sdio_d2, 8, 3), + GROUP(sdio_d3, 8, 2), + GROUP(sdio_cmd, 8, 1), + GROUP(sdio_clk, 8, 0), GROUP(uart_tx_a, 4, 13), GROUP(uart_rx_a, 4, 12), GROUP(uart_cts_a, 4, 11), @@ -507,6 +520,11 @@ static const char * const sdcard_groups[] = { "sdcard_cmd", "sdcard_clk", }; +static const char * const sdio_groups[] = { + "sdio_d0", "sdio_d1", "sdio_d2", "sdio_d3", + "sdio_cmd", "sdio_clk", +}; + static const char * const uart_a_groups[] = { "uart_tx_a", "uart_rx_a", "uart_cts_a", "uart_rts_a", }; @@ -600,6 +618,7 @@ static struct meson_pmx_func meson_gxbb_periphs_functions[] = { FUNCTION(gpio_periphs), FUNCTION(emmc), FUNCTION(sdcard), + FUNCTION(sdio), FUNCTION(uart_a), FUNCTION(uart_b), FUNCTION(uart_c), -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-08-28 16:47 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linus-amlogic sd_emmc_a is used a controller for the SDIO modules. This adds the pin configuration for the SDIO controller. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index 77da6dd..fb479b8 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -163,6 +163,13 @@ static const unsigned int sdcard_d3_pins[] = { PIN(CARD_4, EE_OFF) }; static const unsigned int sdcard_cmd_pins[] = { PIN(CARD_3, EE_OFF) }; static const unsigned int sdcard_clk_pins[] = { PIN(CARD_2, EE_OFF) }; +static const unsigned int sdio_d0_pins[] = { PIN(GPIOX_0, EE_OFF) }; +static const unsigned int sdio_d1_pins[] = { PIN(GPIOX_1, EE_OFF) }; +static const unsigned int sdio_d2_pins[] = { PIN(GPIOX_2, EE_OFF) }; +static const unsigned int sdio_d3_pins[] = { PIN(GPIOX_3, EE_OFF) }; +static const unsigned int sdio_cmd_pins[] = { PIN(GPIOX_4, EE_OFF) }; +static const unsigned int sdio_clk_pins[] = { PIN(GPIOX_5, EE_OFF) }; + static const unsigned int uart_tx_a_pins[] = { PIN(GPIOX_12, EE_OFF) }; static const unsigned int uart_rx_a_pins[] = { PIN(GPIOX_13, EE_OFF) }; static const unsigned int uart_cts_a_pins[] = { PIN(GPIOX_14, EE_OFF) }; @@ -370,6 +377,12 @@ static struct meson_pmx_group meson_gxbb_periphs_groups[] = { GPIO_GROUP(GPIO_TEST_N, EE_OFF), /* Bank X */ + GROUP(sdio_d0, 8, 5), + GROUP(sdio_d1, 8, 4), + GROUP(sdio_d2, 8, 3), + GROUP(sdio_d3, 8, 2), + GROUP(sdio_cmd, 8, 1), + GROUP(sdio_clk, 8, 0), GROUP(uart_tx_a, 4, 13), GROUP(uart_rx_a, 4, 12), GROUP(uart_cts_a, 4, 11), @@ -507,6 +520,11 @@ static const char * const sdcard_groups[] = { "sdcard_cmd", "sdcard_clk", }; +static const char * const sdio_groups[] = { + "sdio_d0", "sdio_d1", "sdio_d2", "sdio_d3", + "sdio_cmd", "sdio_clk", +}; + static const char * const uart_a_groups[] = { "uart_tx_a", "uart_rx_a", "uart_cts_a", "uart_rts_a", }; @@ -600,6 +618,7 @@ static struct meson_pmx_func meson_gxbb_periphs_functions[] = { FUNCTION(gpio_periphs), FUNCTION(emmc), FUNCTION(sdcard), + FUNCTION(sdio), FUNCTION(uart_a), FUNCTION(uart_b), FUNCTION(uart_c), -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-08-28 16:47 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linux-arm-kernel sd_emmc_a is used a controller for the SDIO modules. This adds the pin configuration for the SDIO controller. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index 77da6dd..fb479b8 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -163,6 +163,13 @@ static const unsigned int sdcard_d3_pins[] = { PIN(CARD_4, EE_OFF) }; static const unsigned int sdcard_cmd_pins[] = { PIN(CARD_3, EE_OFF) }; static const unsigned int sdcard_clk_pins[] = { PIN(CARD_2, EE_OFF) }; +static const unsigned int sdio_d0_pins[] = { PIN(GPIOX_0, EE_OFF) }; +static const unsigned int sdio_d1_pins[] = { PIN(GPIOX_1, EE_OFF) }; +static const unsigned int sdio_d2_pins[] = { PIN(GPIOX_2, EE_OFF) }; +static const unsigned int sdio_d3_pins[] = { PIN(GPIOX_3, EE_OFF) }; +static const unsigned int sdio_cmd_pins[] = { PIN(GPIOX_4, EE_OFF) }; +static const unsigned int sdio_clk_pins[] = { PIN(GPIOX_5, EE_OFF) }; + static const unsigned int uart_tx_a_pins[] = { PIN(GPIOX_12, EE_OFF) }; static const unsigned int uart_rx_a_pins[] = { PIN(GPIOX_13, EE_OFF) }; static const unsigned int uart_cts_a_pins[] = { PIN(GPIOX_14, EE_OFF) }; @@ -370,6 +377,12 @@ static struct meson_pmx_group meson_gxbb_periphs_groups[] = { GPIO_GROUP(GPIO_TEST_N, EE_OFF), /* Bank X */ + GROUP(sdio_d0, 8, 5), + GROUP(sdio_d1, 8, 4), + GROUP(sdio_d2, 8, 3), + GROUP(sdio_d3, 8, 2), + GROUP(sdio_cmd, 8, 1), + GROUP(sdio_clk, 8, 0), GROUP(uart_tx_a, 4, 13), GROUP(uart_rx_a, 4, 12), GROUP(uart_cts_a, 4, 11), @@ -507,6 +520,11 @@ static const char * const sdcard_groups[] = { "sdcard_cmd", "sdcard_clk", }; +static const char * const sdio_groups[] = { + "sdio_d0", "sdio_d1", "sdio_d2", "sdio_d3", + "sdio_cmd", "sdio_clk", +}; + static const char * const uart_a_groups[] = { "uart_tx_a", "uart_rx_a", "uart_cts_a", "uart_rts_a", }; @@ -600,6 +618,7 @@ static struct meson_pmx_func meson_gxbb_periphs_functions[] = { FUNCTION(gpio_periphs), FUNCTION(emmc), FUNCTION(sdcard), + FUNCTION(sdio), FUNCTION(uart_a), FUNCTION(uart_b), FUNCTION(uart_c), -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller 2016-08-28 16:47 ` Martin Blumenstingl (?) @ 2016-09-07 14:24 ` Linus Walleij -1 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-07 14:24 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-gpio, open list:ARM/Amlogic Meson..., Kevin Hilman, Carlo Caione, linux-arm-kernel On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > sd_emmc_a is used a controller for the SDIO modules. This adds the pin > configuration for the SDIO controller. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> No reply from maintainers, but you obviously know what you're doing so patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-07 14:24 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-07 14:24 UTC (permalink / raw) To: linus-amlogic On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > sd_emmc_a is used a controller for the SDIO modules. This adds the pin > configuration for the SDIO controller. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> No reply from maintainers, but you obviously know what you're doing so patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-07 14:24 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-07 14:24 UTC (permalink / raw) To: linux-arm-kernel On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > sd_emmc_a is used a controller for the SDIO modules. This adds the pin > configuration for the SDIO controller. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> No reply from maintainers, but you obviously know what you're doing so patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller 2016-09-07 14:24 ` Linus Walleij (?) @ 2016-09-07 18:55 ` Martin Blumenstingl -1 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-07 18:55 UTC (permalink / raw) To: Linus Walleij Cc: linux-gpio, open list:ARM/Amlogic Meson..., Kevin Hilman, Carlo Caione, linux-arm-kernel On Wed, Sep 7, 2016 at 4:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > >> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >> configuration for the SDIO controller. >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > No reply from maintainers, but you obviously know what you're doing so > patch applied. I forgot to reply to this one as well (sorry about that): I received a NACK off-list for both patches because the SDIO IRQ pin is missing. Nothing is broken with this patch applied, just one pin is missing. Depending on how you'd like to proceed you can: - either drop the patch from your tree and wait for v2 - leave it in your tree and I'll send a patch on top of this one to add the missing pin Please let me know how you'd like to handle this and sorry again. Regards, Martin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-07 18:55 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-07 18:55 UTC (permalink / raw) To: linus-amlogic On Wed, Sep 7, 2016 at 4:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > >> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >> configuration for the SDIO controller. >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > No reply from maintainers, but you obviously know what you're doing so > patch applied. I forgot to reply to this one as well (sorry about that): I received a NACK off-list for both patches because the SDIO IRQ pin is missing. Nothing is broken with this patch applied, just one pin is missing. Depending on how you'd like to proceed you can: - either drop the patch from your tree and wait for v2 - leave it in your tree and I'll send a patch on top of this one to add the missing pin Please let me know how you'd like to handle this and sorry again. Regards, Martin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-07 18:55 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-07 18:55 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 7, 2016 at 4:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > >> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >> configuration for the SDIO controller. >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > No reply from maintainers, but you obviously know what you're doing so > patch applied. I forgot to reply to this one as well (sorry about that): I received a NACK off-list for both patches because the SDIO IRQ pin is missing. Nothing is broken with this patch applied, just one pin is missing. Depending on how you'd like to proceed you can: - either drop the patch from your tree and wait for v2 - leave it in your tree and I'll send a patch on top of this one to add the missing pin Please let me know how you'd like to handle this and sorry again. Regards, Martin ^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller 2016-09-07 18:55 ` Martin Blumenstingl (?) @ 2016-09-12 12:22 ` Linus Walleij -1 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-12 12:22 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-gpio, open list:ARM/Amlogic Meson..., Kevin Hilman, Carlo Caione, linux-arm-kernel On Wed, Sep 7, 2016 at 8:55 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > On Wed, Sep 7, 2016 at 4:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl >> <martin.blumenstingl@googlemail.com> wrote: >> >>> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >>> configuration for the SDIO controller. >>> >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> >> No reply from maintainers, but you obviously know what you're doing so >> patch applied. > I forgot to reply to this one as well (sorry about that): > I received a NACK off-list for both patches because the SDIO IRQ pin is missing. > > Nothing is broken with this patch applied, just one pin is missing. > Depending on how you'd like to proceed you can: > - either drop the patch from your tree and wait for v2 > - leave it in your tree and I'll send a patch on top of this one to > add the missing pin The latter at this point. Patch the patch. Thanks! Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-12 12:22 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-12 12:22 UTC (permalink / raw) To: linus-amlogic On Wed, Sep 7, 2016 at 8:55 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > On Wed, Sep 7, 2016 at 4:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl >> <martin.blumenstingl@googlemail.com> wrote: >> >>> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >>> configuration for the SDIO controller. >>> >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> >> No reply from maintainers, but you obviously know what you're doing so >> patch applied. > I forgot to reply to this one as well (sorry about that): > I received a NACK off-list for both patches because the SDIO IRQ pin is missing. > > Nothing is broken with this patch applied, just one pin is missing. > Depending on how you'd like to proceed you can: > - either drop the patch from your tree and wait for v2 > - leave it in your tree and I'll send a patch on top of this one to > add the missing pin The latter at this point. Patch the patch. Thanks! Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-12 12:22 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-12 12:22 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 7, 2016 at 8:55 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > On Wed, Sep 7, 2016 at 4:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl >> <martin.blumenstingl@googlemail.com> wrote: >> >>> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >>> configuration for the SDIO controller. >>> >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> >> No reply from maintainers, but you obviously know what you're doing so >> patch applied. > I forgot to reply to this one as well (sorry about that): > I received a NACK off-list for both patches because the SDIO IRQ pin is missing. > > Nothing is broken with this patch applied, just one pin is missing. > Depending on how you'd like to proceed you can: > - either drop the patch from your tree and wait for v2 > - leave it in your tree and I'll send a patch on top of this one to > add the missing pin The latter at this point. Patch the patch. Thanks! Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller 2016-09-07 14:24 ` Linus Walleij (?) @ 2016-09-07 19:07 ` Kevin Hilman -1 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-07 19:07 UTC (permalink / raw) To: Linus Walleij Cc: Martin Blumenstingl, linux-gpio, open list:ARM/Amlogic Meson..., Carlo Caione, linux-arm-kernel Linus Walleij <linus.walleij@linaro.org> writes: > On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > >> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >> configuration for the SDIO controller. >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > No reply from maintainers, but you obviously know what you're doing so > patch applied. Oh, I thought Neil already responded, but I'm not seeing it now. This patch is missing the SDIO IRQ line. Martin can you respin? Sorry for the lag, I'm still catching up after some vacation, Kevin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-07 19:07 ` Kevin Hilman 0 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-07 19:07 UTC (permalink / raw) To: linus-amlogic Linus Walleij <linus.walleij@linaro.org> writes: > On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > >> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >> configuration for the SDIO controller. >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > No reply from maintainers, but you obviously know what you're doing so > patch applied. Oh, I thought Neil already responded, but I'm not seeing it now. This patch is missing the SDIO IRQ line. Martin can you respin? Sorry for the lag, I'm still catching up after some vacation, Kevin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller @ 2016-09-07 19:07 ` Kevin Hilman 0 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-07 19:07 UTC (permalink / raw) To: linux-arm-kernel Linus Walleij <linus.walleij@linaro.org> writes: > On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > >> sd_emmc_a is used a controller for the SDIO modules. This adds the pin >> configuration for the SDIO controller. >> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > No reply from maintainers, but you obviously know what you're doing so > patch applied. Oh, I thought Neil already responded, but I'm not seeing it now. This patch is missing the SDIO IRQ line. Martin can you respin? Sorry for the lag, I'm still catching up after some vacation, Kevin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins 2016-08-28 16:47 ` Martin Blumenstingl (?) @ 2016-08-28 16:47 ` Martin Blumenstingl -1 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linux-gpio, linux-amlogic, linus.walleij, khilman, carlo Cc: linux-arm-kernel, Martin Blumenstingl This can be passed to the sd_emmc_a controller to which the SDIO module is connected (when available). Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index e2dae1a..6864523 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -355,6 +355,18 @@ }; }; + sdio_pins: sdio { + mux { + groups = "sdio_d0", + "sdio_d1", + "sdio_d2", + "sdio_d3", + "sdio_cmd", + "sdio_clk"; + function = "sdio"; + }; + }; + uart_a_pins: uart_a { mux { groups = "uart_tx_a", -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-08-28 16:47 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linus-amlogic This can be passed to the sd_emmc_a controller to which the SDIO module is connected (when available). Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index e2dae1a..6864523 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -355,6 +355,18 @@ }; }; + sdio_pins: sdio { + mux { + groups = "sdio_d0", + "sdio_d1", + "sdio_d2", + "sdio_d3", + "sdio_cmd", + "sdio_clk"; + function = "sdio"; + }; + }; + uart_a_pins: uart_a { mux { groups = "uart_tx_a", -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-08-28 16:47 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-08-28 16:47 UTC (permalink / raw) To: linux-arm-kernel This can be passed to the sd_emmc_a controller to which the SDIO module is connected (when available). Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index e2dae1a..6864523 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -355,6 +355,18 @@ }; }; + sdio_pins: sdio { + mux { + groups = "sdio_d0", + "sdio_d1", + "sdio_d2", + "sdio_d3", + "sdio_cmd", + "sdio_clk"; + function = "sdio"; + }; + }; + uart_a_pins: uart_a { mux { groups = "uart_tx_a", -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins 2016-08-28 16:47 ` Martin Blumenstingl (?) @ 2016-08-28 19:13 ` Rask Ingemann Lambertsen -1 siblings, 0 replies; 48+ messages in thread From: Rask Ingemann Lambertsen @ 2016-08-28 19:13 UTC (permalink / raw) To: Martin Blumenstingl Cc: khilman, linus.walleij, linux-gpio, carlo, linux-amlogic, linux-arm-kernel On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: > uart_a_pins: uart_a { > mux { > groups = "uart_tx_a", You shouldn't use underscores in node names. Use hyphens instead, perhaps. https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html -- Rask Ingemann Lambertsen ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-08-28 19:13 ` Rask Ingemann Lambertsen 0 siblings, 0 replies; 48+ messages in thread From: Rask Ingemann Lambertsen @ 2016-08-28 19:13 UTC (permalink / raw) To: linus-amlogic On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: > uart_a_pins: uart_a { > mux { > groups = "uart_tx_a", You shouldn't use underscores in node names. Use hyphens instead, perhaps. https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html -- Rask Ingemann Lambertsen ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-08-28 19:13 ` Rask Ingemann Lambertsen 0 siblings, 0 replies; 48+ messages in thread From: Rask Ingemann Lambertsen @ 2016-08-28 19:13 UTC (permalink / raw) To: linux-arm-kernel On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: > uart_a_pins: uart_a { > mux { > groups = "uart_tx_a", You shouldn't use underscores in node names. Use hyphens instead, perhaps. https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html -- Rask Ingemann Lambertsen ^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins 2016-08-28 19:13 ` Rask Ingemann Lambertsen (?) @ 2016-09-04 17:55 ` Martin Blumenstingl -1 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-04 17:55 UTC (permalink / raw) To: Rask Ingemann Lambertsen, Rob Herring Cc: linux-gpio, linux-amlogic, linus.walleij, khilman, carlo, linux-arm-kernel On Sun, Aug 28, 2016 at 9:13 PM, Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> wrote: > On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: >> uart_a_pins: uart_a { >> mux { >> groups = "uart_tx_a", > > You shouldn't use underscores in node names. Use hyphens instead, perhaps. > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html The part which you found there is just the context of my patch, not an actual change. However, basically all of the GXBB .dts files are using underscores in the node names. Do "we" have to change this globally? Regarding my patch: I got a NACK from Neil Armstrong off-list: The SDIO IRQ pin is missing in my series. Regards, Martin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-04 17:55 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-04 17:55 UTC (permalink / raw) To: linus-amlogic On Sun, Aug 28, 2016 at 9:13 PM, Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> wrote: > On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: >> uart_a_pins: uart_a { >> mux { >> groups = "uart_tx_a", > > You shouldn't use underscores in node names. Use hyphens instead, perhaps. > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html The part which you found there is just the context of my patch, not an actual change. However, basically all of the GXBB .dts files are using underscores in the node names. Do "we" have to change this globally? Regarding my patch: I got a NACK from Neil Armstrong off-list: The SDIO IRQ pin is missing in my series. Regards, Martin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-04 17:55 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-04 17:55 UTC (permalink / raw) To: linux-arm-kernel On Sun, Aug 28, 2016 at 9:13 PM, Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> wrote: > On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: >> uart_a_pins: uart_a { >> mux { >> groups = "uart_tx_a", > > You shouldn't use underscores in node names. Use hyphens instead, perhaps. > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html The part which you found there is just the context of my patch, not an actual change. However, basically all of the GXBB .dts files are using underscores in the node names. Do "we" have to change this globally? Regarding my patch: I got a NACK from Neil Armstrong off-list: The SDIO IRQ pin is missing in my series. Regards, Martin ^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins 2016-08-28 16:47 ` Martin Blumenstingl (?) @ 2016-09-07 14:23 ` Linus Walleij -1 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-07 14:23 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-gpio, open list:ARM/Amlogic Meson..., Kevin Hilman, Carlo Caione, linux-arm-kernel On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > This can be passed to the sd_emmc_a controller to which the SDIO module > is connected (when available). > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Please merge this through the ARM SoC tree. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-07 14:23 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-07 14:23 UTC (permalink / raw) To: linus-amlogic On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > This can be passed to the sd_emmc_a controller to which the SDIO module > is connected (when available). > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Please merge this through the ARM SoC tree. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-07 14:23 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-07 14:23 UTC (permalink / raw) To: linux-arm-kernel On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > This can be passed to the sd_emmc_a controller to which the SDIO module > is connected (when available). > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Please merge this through the ARM SoC tree. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 0/2] add support for the SDIO pins on GXBB 2016-08-28 16:47 ` Martin Blumenstingl (?) @ 2016-09-11 12:39 ` Martin Blumenstingl -1 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linux-gpio, linux-amlogic, linus.walleij, khilman, carlo Cc: linux-arm-kernel, Martin Blumenstingl This series adds the pins for the SDIO controller (sd_emmc_a) found on Meson GXBB SoCs. Changes since v1: - add the missing SDIO interrupt pin: The initial pinctrl patch was already applied to linux-pinctrl's for-next branch, so patch 1 applies on top of the already existing patch (both can be squashed if needed). The dts patch was not applied anywhere yet, so patch 2 contains a fixed version of the patch (provided by Neil Armstrong - thanks!). Martin Blumenstingl (1): pinctrl: meson-gxbb: add the missing SDIO interrupt pin Neil Armstrong (1): ARM64: dts: meson-gxbb: add the SDIO pins arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++++++ drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 +++- 2 files changed, 22 insertions(+), 1 deletion(-) -- 2.9.3 ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 0/2] add support for the SDIO pins on GXBB @ 2016-09-11 12:39 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linus-amlogic This series adds the pins for the SDIO controller (sd_emmc_a) found on Meson GXBB SoCs. Changes since v1: - add the missing SDIO interrupt pin: The initial pinctrl patch was already applied to linux-pinctrl's for-next branch, so patch 1 applies on top of the already existing patch (both can be squashed if needed). The dts patch was not applied anywhere yet, so patch 2 contains a fixed version of the patch (provided by Neil Armstrong - thanks!). Martin Blumenstingl (1): pinctrl: meson-gxbb: add the missing SDIO interrupt pin Neil Armstrong (1): ARM64: dts: meson-gxbb: add the SDIO pins arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++++++ drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 +++- 2 files changed, 22 insertions(+), 1 deletion(-) -- 2.9.3 ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 0/2] add support for the SDIO pins on GXBB @ 2016-09-11 12:39 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linux-arm-kernel This series adds the pins for the SDIO controller (sd_emmc_a) found on Meson GXBB SoCs. Changes since v1: - add the missing SDIO interrupt pin: The initial pinctrl patch was already applied to linux-pinctrl's for-next branch, so patch 1 applies on top of the already existing patch (both can be squashed if needed). The dts patch was not applied anywhere yet, so patch 2 contains a fixed version of the patch (provided by Neil Armstrong - thanks!). Martin Blumenstingl (1): pinctrl: meson-gxbb: add the missing SDIO interrupt pin Neil Armstrong (1): ARM64: dts: meson-gxbb: add the SDIO pins arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++++++ drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 +++- 2 files changed, 22 insertions(+), 1 deletion(-) -- 2.9.3 ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin 2016-09-11 12:39 ` Martin Blumenstingl (?) @ 2016-09-11 12:39 ` Martin Blumenstingl -1 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linux-gpio, linux-amlogic, linus.walleij, khilman, carlo Cc: linux-arm-kernel, Martin Blumenstingl This adds the SDIO interrupt pin which can be used by sd_emmc_a. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Suggested-by: Neil Armstrong <narmstrong@baylibre.com> Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller") --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index fb479b8..4a27ae0 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -169,6 +169,7 @@ static const unsigned int sdio_d2_pins[] = { PIN(GPIOX_2, EE_OFF) }; static const unsigned int sdio_d3_pins[] = { PIN(GPIOX_3, EE_OFF) }; static const unsigned int sdio_cmd_pins[] = { PIN(GPIOX_4, EE_OFF) }; static const unsigned int sdio_clk_pins[] = { PIN(GPIOX_5, EE_OFF) }; +static const unsigned int sdio_irq_pins[] = { PIN(GPIOX_7, EE_OFF) }; static const unsigned int uart_tx_a_pins[] = { PIN(GPIOX_12, EE_OFF) }; static const unsigned int uart_rx_a_pins[] = { PIN(GPIOX_13, EE_OFF) }; @@ -383,6 +384,7 @@ static struct meson_pmx_group meson_gxbb_periphs_groups[] = { GROUP(sdio_d3, 8, 2), GROUP(sdio_cmd, 8, 1), GROUP(sdio_clk, 8, 0), + GROUP(sdio_irq, 8, 11), GROUP(uart_tx_a, 4, 13), GROUP(uart_rx_a, 4, 12), GROUP(uart_cts_a, 4, 11), @@ -522,7 +524,7 @@ static const char * const sdcard_groups[] = { static const char * const sdio_groups[] = { "sdio_d0", "sdio_d1", "sdio_d2", "sdio_d3", - "sdio_cmd", "sdio_clk", + "sdio_cmd", "sdio_clk", "sdio_irq", }; static const char * const uart_a_groups[] = { -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin @ 2016-09-11 12:39 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linus-amlogic This adds the SDIO interrupt pin which can be used by sd_emmc_a. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Suggested-by: Neil Armstrong <narmstrong@baylibre.com> Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller") --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index fb479b8..4a27ae0 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -169,6 +169,7 @@ static const unsigned int sdio_d2_pins[] = { PIN(GPIOX_2, EE_OFF) }; static const unsigned int sdio_d3_pins[] = { PIN(GPIOX_3, EE_OFF) }; static const unsigned int sdio_cmd_pins[] = { PIN(GPIOX_4, EE_OFF) }; static const unsigned int sdio_clk_pins[] = { PIN(GPIOX_5, EE_OFF) }; +static const unsigned int sdio_irq_pins[] = { PIN(GPIOX_7, EE_OFF) }; static const unsigned int uart_tx_a_pins[] = { PIN(GPIOX_12, EE_OFF) }; static const unsigned int uart_rx_a_pins[] = { PIN(GPIOX_13, EE_OFF) }; @@ -383,6 +384,7 @@ static struct meson_pmx_group meson_gxbb_periphs_groups[] = { GROUP(sdio_d3, 8, 2), GROUP(sdio_cmd, 8, 1), GROUP(sdio_clk, 8, 0), + GROUP(sdio_irq, 8, 11), GROUP(uart_tx_a, 4, 13), GROUP(uart_rx_a, 4, 12), GROUP(uart_cts_a, 4, 11), @@ -522,7 +524,7 @@ static const char * const sdcard_groups[] = { static const char * const sdio_groups[] = { "sdio_d0", "sdio_d1", "sdio_d2", "sdio_d3", - "sdio_cmd", "sdio_clk", + "sdio_cmd", "sdio_clk", "sdio_irq", }; static const char * const uart_a_groups[] = { -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin @ 2016-09-11 12:39 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linux-arm-kernel This adds the SDIO interrupt pin which can be used by sd_emmc_a. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Suggested-by: Neil Armstrong <narmstrong@baylibre.com> Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller") --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index fb479b8..4a27ae0 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -169,6 +169,7 @@ static const unsigned int sdio_d2_pins[] = { PIN(GPIOX_2, EE_OFF) }; static const unsigned int sdio_d3_pins[] = { PIN(GPIOX_3, EE_OFF) }; static const unsigned int sdio_cmd_pins[] = { PIN(GPIOX_4, EE_OFF) }; static const unsigned int sdio_clk_pins[] = { PIN(GPIOX_5, EE_OFF) }; +static const unsigned int sdio_irq_pins[] = { PIN(GPIOX_7, EE_OFF) }; static const unsigned int uart_tx_a_pins[] = { PIN(GPIOX_12, EE_OFF) }; static const unsigned int uart_rx_a_pins[] = { PIN(GPIOX_13, EE_OFF) }; @@ -383,6 +384,7 @@ static struct meson_pmx_group meson_gxbb_periphs_groups[] = { GROUP(sdio_d3, 8, 2), GROUP(sdio_cmd, 8, 1), GROUP(sdio_clk, 8, 0), + GROUP(sdio_irq, 8, 11), GROUP(uart_tx_a, 4, 13), GROUP(uart_rx_a, 4, 12), GROUP(uart_cts_a, 4, 11), @@ -522,7 +524,7 @@ static const char * const sdcard_groups[] = { static const char * const sdio_groups[] = { "sdio_d0", "sdio_d1", "sdio_d2", "sdio_d3", - "sdio_cmd", "sdio_clk", + "sdio_cmd", "sdio_clk", "sdio_irq", }; static const char * const uart_a_groups[] = { -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin 2016-09-11 12:39 ` Martin Blumenstingl (?) @ 2016-09-12 18:07 ` Kevin Hilman -1 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-12 18:07 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-gpio, linux-amlogic, linus.walleij, carlo, linux-arm-kernel Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > This adds the SDIO interrupt pin which can be used by sd_emmc_a. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com> > > Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the > SDIO/sd_emmc_a controller") Acked-by: Kevin Hilman <khilman@baylibre.com> ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin @ 2016-09-12 18:07 ` Kevin Hilman 0 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-12 18:07 UTC (permalink / raw) To: linus-amlogic Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > This adds the SDIO interrupt pin which can be used by sd_emmc_a. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com> > > Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the > SDIO/sd_emmc_a controller") Acked-by: Kevin Hilman <khilman@baylibre.com> ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin @ 2016-09-12 18:07 ` Kevin Hilman 0 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-12 18:07 UTC (permalink / raw) To: linux-arm-kernel Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > This adds the SDIO interrupt pin which can be used by sd_emmc_a. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com> > > Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the > SDIO/sd_emmc_a controller") Acked-by: Kevin Hilman <khilman@baylibre.com> ^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin 2016-09-11 12:39 ` Martin Blumenstingl (?) @ 2016-09-13 11:38 ` Linus Walleij -1 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-13 11:38 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-gpio, open list:ARM/Amlogic Meson..., Kevin Hilman, Carlo Caione, linux-arm-kernel On Sun, Sep 11, 2016 at 2:39 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > This adds the SDIO interrupt pin which can be used by sd_emmc_a. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com> > > Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the > SDIO/sd_emmc_a controller") Patch applied with Kevin's ACK. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin @ 2016-09-13 11:38 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-13 11:38 UTC (permalink / raw) To: linus-amlogic On Sun, Sep 11, 2016 at 2:39 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > This adds the SDIO interrupt pin which can be used by sd_emmc_a. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com> > > Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the > SDIO/sd_emmc_a controller") Patch applied with Kevin's ACK. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin @ 2016-09-13 11:38 ` Linus Walleij 0 siblings, 0 replies; 48+ messages in thread From: Linus Walleij @ 2016-09-13 11:38 UTC (permalink / raw) To: linux-arm-kernel On Sun, Sep 11, 2016 at 2:39 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > This adds the SDIO interrupt pin which can be used by sd_emmc_a. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com> > > Fixes: 29885a656511 ("pinctrl: meson-gxbb: add the pins for the > SDIO/sd_emmc_a controller") Patch applied with Kevin's ACK. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 2/2] ARM64: dts: meson-gxbb: add the SDIO pins 2016-09-11 12:39 ` Martin Blumenstingl (?) @ 2016-09-11 12:39 ` Martin Blumenstingl -1 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linux-gpio, linux-amlogic, linus.walleij, khilman, carlo Cc: linux-arm-kernel, Neil Armstrong From: Neil Armstrong <narmstrong@baylibre.com> This is used to configure the pins of the sd_emmc_a controller to which an SDIO module is connected (when available). Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index c84cacf..fe2a1fc 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -394,6 +394,25 @@ }; }; + sdio_pins: sdio { + mux { + groups = "sdio_d0", + "sdio_d1", + "sdio_d2", + "sdio_d3", + "sdio_cmd", + "sdio_clk"; + function = "sdio"; + }; + }; + + sdio_irq_pins: sdio_irq { + mux { + groups = "sdio_irq"; + function = "sdio"; + }; + }; + uart_a_pins: uart_a { mux { groups = "uart_tx_a", -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH v2 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-11 12:39 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linus-amlogic From: Neil Armstrong <narmstrong@baylibre.com> This is used to configure the pins of the sd_emmc_a controller to which an SDIO module is connected (when available). Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index c84cacf..fe2a1fc 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -394,6 +394,25 @@ }; }; + sdio_pins: sdio { + mux { + groups = "sdio_d0", + "sdio_d1", + "sdio_d2", + "sdio_d3", + "sdio_cmd", + "sdio_clk"; + function = "sdio"; + }; + }; + + sdio_irq_pins: sdio_irq { + mux { + groups = "sdio_irq"; + function = "sdio"; + }; + }; + uart_a_pins: uart_a { mux { groups = "uart_tx_a", -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH v2 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-11 12:39 ` Martin Blumenstingl 0 siblings, 0 replies; 48+ messages in thread From: Martin Blumenstingl @ 2016-09-11 12:39 UTC (permalink / raw) To: linux-arm-kernel From: Neil Armstrong <narmstrong@baylibre.com> This is used to configure the pins of the sd_emmc_a controller to which an SDIO module is connected (when available). Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index c84cacf..fe2a1fc 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -394,6 +394,25 @@ }; }; + sdio_pins: sdio { + mux { + groups = "sdio_d0", + "sdio_d1", + "sdio_d2", + "sdio_d3", + "sdio_cmd", + "sdio_clk"; + function = "sdio"; + }; + }; + + sdio_irq_pins: sdio_irq { + mux { + groups = "sdio_irq"; + function = "sdio"; + }; + }; + uart_a_pins: uart_a { mux { groups = "uart_tx_a", -- 2.9.3 ^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH v2 2/2] ARM64: dts: meson-gxbb: add the SDIO pins 2016-09-11 12:39 ` Martin Blumenstingl (?) @ 2016-09-12 18:13 ` Kevin Hilman -1 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-12 18:13 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-gpio, linux-amlogic, linus.walleij, carlo, linux-arm-kernel, Neil Armstrong Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > From: Neil Armstrong <narmstrong@baylibre.com> > > This is used to configure the pins of the sd_emmc_a controller to > which an SDIO module is connected (when available). > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Applied, Kevin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-12 18:13 ` Kevin Hilman 0 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-12 18:13 UTC (permalink / raw) To: linus-amlogic Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > From: Neil Armstrong <narmstrong@baylibre.com> > > This is used to configure the pins of the sd_emmc_a controller to > which an SDIO module is connected (when available). > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Applied, Kevin ^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH v2 2/2] ARM64: dts: meson-gxbb: add the SDIO pins @ 2016-09-12 18:13 ` Kevin Hilman 0 siblings, 0 replies; 48+ messages in thread From: Kevin Hilman @ 2016-09-12 18:13 UTC (permalink / raw) To: linux-arm-kernel Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > From: Neil Armstrong <narmstrong@baylibre.com> > > This is used to configure the pins of the sd_emmc_a controller to > which an SDIO module is connected (when available). > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Applied, Kevin ^ permalink raw reply [flat|nested] 48+ messages in thread
end of thread, other threads:[~2016-09-13 11:38 UTC | newest] Thread overview: 48+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-08-28 16:47 [PATCH 0/2] add support for the SDIO pins on GXBB Martin Blumenstingl 2016-08-28 16:47 ` Martin Blumenstingl 2016-08-28 16:47 ` Martin Blumenstingl 2016-08-28 16:47 ` [PATCH 1/2] pinctrl: meson-gxbb: add the pins for the SDIO/sd_emmc_a controller Martin Blumenstingl 2016-08-28 16:47 ` Martin Blumenstingl 2016-08-28 16:47 ` Martin Blumenstingl 2016-09-07 14:24 ` Linus Walleij 2016-09-07 14:24 ` Linus Walleij 2016-09-07 14:24 ` Linus Walleij 2016-09-07 18:55 ` Martin Blumenstingl 2016-09-07 18:55 ` Martin Blumenstingl 2016-09-07 18:55 ` Martin Blumenstingl 2016-09-12 12:22 ` Linus Walleij 2016-09-12 12:22 ` Linus Walleij 2016-09-12 12:22 ` Linus Walleij 2016-09-07 19:07 ` Kevin Hilman 2016-09-07 19:07 ` Kevin Hilman 2016-09-07 19:07 ` Kevin Hilman 2016-08-28 16:47 ` [PATCH 2/2] ARM64: dts: meson-gxbb: add the SDIO pins Martin Blumenstingl 2016-08-28 16:47 ` Martin Blumenstingl 2016-08-28 16:47 ` Martin Blumenstingl 2016-08-28 19:13 ` Rask Ingemann Lambertsen 2016-08-28 19:13 ` Rask Ingemann Lambertsen 2016-08-28 19:13 ` Rask Ingemann Lambertsen 2016-09-04 17:55 ` Martin Blumenstingl 2016-09-04 17:55 ` Martin Blumenstingl 2016-09-04 17:55 ` Martin Blumenstingl 2016-09-07 14:23 ` Linus Walleij 2016-09-07 14:23 ` Linus Walleij 2016-09-07 14:23 ` Linus Walleij 2016-09-11 12:39 ` [PATCH v2 0/2] add support for the SDIO pins on GXBB Martin Blumenstingl 2016-09-11 12:39 ` Martin Blumenstingl 2016-09-11 12:39 ` Martin Blumenstingl 2016-09-11 12:39 ` [PATCH v2 1/2] pinctrl: meson-gxbb: add the missing SDIO interrupt pin Martin Blumenstingl 2016-09-11 12:39 ` Martin Blumenstingl 2016-09-11 12:39 ` Martin Blumenstingl 2016-09-12 18:07 ` Kevin Hilman 2016-09-12 18:07 ` Kevin Hilman 2016-09-12 18:07 ` Kevin Hilman 2016-09-13 11:38 ` Linus Walleij 2016-09-13 11:38 ` Linus Walleij 2016-09-13 11:38 ` Linus Walleij 2016-09-11 12:39 ` [PATCH v2 2/2] ARM64: dts: meson-gxbb: add the SDIO pins Martin Blumenstingl 2016-09-11 12:39 ` Martin Blumenstingl 2016-09-11 12:39 ` Martin Blumenstingl 2016-09-12 18:13 ` Kevin Hilman 2016-09-12 18:13 ` Kevin Hilman 2016-09-12 18:13 ` Kevin Hilman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.