* [PATCH] uprobe: fix misleading log entry
@ 2012-07-18 3:08 Jovi Zhang
2012-07-18 9:22 ` Srikar Dronamraju
2012-10-25 14:12 ` Oleg Nesterov
0 siblings, 2 replies; 9+ messages in thread
From: Jovi Zhang @ 2012-07-18 3:08 UTC (permalink / raw)
To: Steven Rostedt, Frédéric Weisbecker, Srikar Dronamraju, LKML
>From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
From: Jovi Zhang <bookjovi@gmail.com>
Date: Wed, 18 Jul 2012 17:51:26 +0800
Subject: [PATCH] uprobe: fix misleading log entry
There don't have any 'r' prefix in uprobe event naming, remove it.
Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
---
kernel/trace/trace_uprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index cf382de..852a584 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
if (argv[0][0] == '-')
is_delete = true;
else if (argv[0][0] != 'p') {
- pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
+ pr_info("Probe definition must be started with 'p' or '-'.\n");
return -EINVAL;
}
--
1.7.9.7
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] uprobe: fix misleading log entry
2012-07-18 3:08 [PATCH] uprobe: fix misleading log entry Jovi Zhang
@ 2012-07-18 9:22 ` Srikar Dronamraju
2012-07-18 11:43 ` Jovi Zhang
2012-10-12 0:06 ` Jovi Zhang
2012-10-25 14:12 ` Oleg Nesterov
1 sibling, 2 replies; 9+ messages in thread
From: Srikar Dronamraju @ 2012-07-18 9:22 UTC (permalink / raw)
To: Jovi Zhang; +Cc: Steven Rostedt, Fr?d?ric Weisbecker, LKML
* Jovi Zhang <bookjovi@gmail.com> [2012-07-18 11:08:42]:
> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com>
> Date: Wed, 18 Jul 2012 17:51:26 +0800
> Subject: [PATCH] uprobe: fix misleading log entry
>
> There don't have any 'r' prefix in uprobe event naming, remove it.
>
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
> ---
> kernel/trace/trace_uprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index cf382de..852a584 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> if (argv[0][0] == '-')
> is_delete = true;
> else if (argv[0][0] != 'p') {
> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> + pr_info("Probe definition must be started with 'p' or '-'.\n");
> return -EINVAL;
> }
>
Yes, uprobes doesnt support return probes. So we should not have
mentioned about r.
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] uprobe: fix misleading log entry
2012-07-18 9:22 ` Srikar Dronamraju
@ 2012-07-18 11:43 ` Jovi Zhang
2012-07-18 15:24 ` Anton Arapov
2012-10-12 0:06 ` Jovi Zhang
1 sibling, 1 reply; 9+ messages in thread
From: Jovi Zhang @ 2012-07-18 11:43 UTC (permalink / raw)
To: Srikar Dronamraju; +Cc: Steven Rostedt, LKML, Frédéric Weisbecker
On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
<srikar@linux.vnet.ibm.com> wrote:
> * Jovi Zhang <bookjovi@gmail.com> [2012-07-18 11:08:42]:
>
>> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
>> From: Jovi Zhang <bookjovi@gmail.com>
>> Date: Wed, 18 Jul 2012 17:51:26 +0800
>> Subject: [PATCH] uprobe: fix misleading log entry
>>
>> There don't have any 'r' prefix in uprobe event naming, remove it.
>>
>> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
>> ---
>> kernel/trace/trace_uprobe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
>> index cf382de..852a584 100644
>> --- a/kernel/trace/trace_uprobe.c
>> +++ b/kernel/trace/trace_uprobe.c
>> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
>> if (argv[0][0] == '-')
>> is_delete = true;
>> else if (argv[0][0] != 'p') {
>> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
>> + pr_info("Probe definition must be started with 'p' or '-'.\n");
>> return -EINVAL;
>> }
>>
>
> Yes, uprobes doesnt support return probes. So we should not have
> mentioned about r.
Hmm, Does this have specific reason? or just not implemented?
>
> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] uprobe: fix misleading log entry
2012-07-18 11:43 ` Jovi Zhang
@ 2012-07-18 15:24 ` Anton Arapov
0 siblings, 0 replies; 9+ messages in thread
From: Anton Arapov @ 2012-07-18 15:24 UTC (permalink / raw)
To: Jovi Zhang
Cc: Srikar Dronamraju, Steven Rostedt, LKML, Frédéric Weisbecker
On Wed, 2012-07-18 at 19:43 +0800, Jovi Zhang wrote:
> On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
> <srikar@linux.vnet.ibm.com> wrote:
> > * Jovi Zhang <bookjovi@gmail.com> [2012-07-18 11:08:42]:
> >
> >> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> >> From: Jovi Zhang <bookjovi@gmail.com>
> >> Date: Wed, 18 Jul 2012 17:51:26 +0800
> >> Subject: [PATCH] uprobe: fix misleading log entry
> >>
> >> There don't have any 'r' prefix in uprobe event naming, remove it.
> >>
> >> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
> >> ---
> >> kernel/trace/trace_uprobe.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> >> index cf382de..852a584 100644
> >> --- a/kernel/trace/trace_uprobe.c
> >> +++ b/kernel/trace/trace_uprobe.c
> >> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> >> if (argv[0][0] == '-')
> >> is_delete = true;
> >> else if (argv[0][0] != 'p') {
> >> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> >> + pr_info("Probe definition must be started with 'p' or '-'.\n");
> >> return -EINVAL;
> >> }
> >>
> >
> > Yes, uprobes doesnt support return probes. So we should not have
> > mentioned about r.
> Hmm, Does this have specific reason? or just not implemented?
It is not implemented. I'm slowly(very) moving towards it. You are
welcome to take a look.
https://github.com/arapov/linux-aa/commits/uretprobes
Anton.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] uprobe: fix misleading log entry
2012-07-18 9:22 ` Srikar Dronamraju
2012-07-18 11:43 ` Jovi Zhang
@ 2012-10-12 0:06 ` Jovi Zhang
2012-10-12 4:50 ` Srikar Dronamraju
1 sibling, 1 reply; 9+ messages in thread
From: Jovi Zhang @ 2012-10-12 0:06 UTC (permalink / raw)
To: Andrew Morton
Cc: Srikar Dronamraju, Steven Rostedt, Frédéric Weisbecker, LKML
On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
<srikar@linux.vnet.ibm.com> wrote:
> * Jovi Zhang <bookjovi@gmail.com> [2012-07-18 11:08:42]:
>
>> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
>> From: Jovi Zhang <bookjovi@gmail.com>
>> Date: Wed, 18 Jul 2012 17:51:26 +0800
>> Subject: [PATCH] uprobe: fix misleading log entry
>>
>> There don't have any 'r' prefix in uprobe event naming, remove it.
>>
>> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
>> ---
>> kernel/trace/trace_uprobe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
>> index cf382de..852a584 100644
>> --- a/kernel/trace/trace_uprobe.c
>> +++ b/kernel/trace/trace_uprobe.c
>> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
>> if (argv[0][0] == '-')
>> is_delete = true;
>> else if (argv[0][0] != 'p') {
>> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
>> + pr_info("Probe definition must be started with 'p' or '-'.\n");
>> return -EINVAL;
>> }
>>
>
> Yes, uprobes doesnt support return probes. So we should not have
> mentioned about r.
>
> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
Hi Andrew,
Is this patch ok to go through your mm tree? mainline still don't merge it.
.jovi
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] uprobe: fix misleading log entry
2012-10-12 0:06 ` Jovi Zhang
@ 2012-10-12 4:50 ` Srikar Dronamraju
0 siblings, 0 replies; 9+ messages in thread
From: Srikar Dronamraju @ 2012-10-12 4:50 UTC (permalink / raw)
To: Jovi Zhang, Ingo Molnar
Cc: Andrew Morton, Steven Rostedt, Fr?d?ric Weisbecker, LKML
> On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
> <srikar@linux.vnet.ibm.com> wrote:
> > * Jovi Zhang <bookjovi@gmail.com> [2012-07-18 11:08:42]:
> >
> >> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> >> From: Jovi Zhang <bookjovi@gmail.com>
> >> Date: Wed, 18 Jul 2012 17:51:26 +0800
> >> Subject: [PATCH] uprobe: fix misleading log entry
> >>
> >> There don't have any 'r' prefix in uprobe event naming, remove it.
> >>
> >> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
> >> ---
> >> kernel/trace/trace_uprobe.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> >> index cf382de..852a584 100644
> >> --- a/kernel/trace/trace_uprobe.c
> >> +++ b/kernel/trace/trace_uprobe.c
> >> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> >> if (argv[0][0] == '-')
> >> is_delete = true;
> >> else if (argv[0][0] != 'p') {
> >> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> >> + pr_info("Probe definition must be started with 'p' or '-'.\n");
> >> return -EINVAL;
> >> }
> >>
> >
> > Yes, uprobes doesnt support return probes. So we should not have
> > mentioned about r.
> >
> > Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> >
>
Ingo/Andrew
Can you please pick this.
--
Thanks and Regards
Srikar
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] uprobe: fix misleading log entry
2012-07-18 3:08 [PATCH] uprobe: fix misleading log entry Jovi Zhang
2012-07-18 9:22 ` Srikar Dronamraju
@ 2012-10-25 14:12 ` Oleg Nesterov
2012-11-19 10:42 ` Steven Rostedt
1 sibling, 1 reply; 9+ messages in thread
From: Oleg Nesterov @ 2012-10-25 14:12 UTC (permalink / raw)
To: Jovi Zhang
Cc: Steven Rostedt, Frédéric Weisbecker, Srikar Dronamraju, LKML
On 07/18, Jovi Zhang wrote:
>
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> if (argv[0][0] == '-')
> is_delete = true;
> else if (argv[0][0] != 'p') {
> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> + pr_info("Probe definition must be started with 'p' or '-'.\n");
> return -EINVAL;
> }
Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
Oleg.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] uprobe: fix misleading log entry
2012-10-25 14:12 ` Oleg Nesterov
@ 2012-11-19 10:42 ` Steven Rostedt
2012-11-19 12:32 ` Oleg Nesterov
0 siblings, 1 reply; 9+ messages in thread
From: Steven Rostedt @ 2012-11-19 10:42 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Jovi Zhang, Frédéric Weisbecker, Srikar Dronamraju, LKML
On Thu, 2012-10-25 at 16:12 +0200, Oleg Nesterov wrote:
> On 07/18, Jovi Zhang wrote:
> >
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> > if (argv[0][0] == '-')
> > is_delete = true;
> > else if (argv[0][0] != 'p') {
> > - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> > + pr_info("Probe definition must be started with 'p' or '-'.\n");
> > return -EINVAL;
> > }
>
> Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
>
> Oleg.
Hmm, this doesn't look like it ever got applied to mainline. Was it
dropped?
-- Steve
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] uprobe: fix misleading log entry
2012-11-19 10:42 ` Steven Rostedt
@ 2012-11-19 12:32 ` Oleg Nesterov
0 siblings, 0 replies; 9+ messages in thread
From: Oleg Nesterov @ 2012-11-19 12:32 UTC (permalink / raw)
To: Steven Rostedt
Cc: Jovi Zhang, Frédéric Weisbecker, Srikar Dronamraju, LKML
On 11/19, Steven Rostedt wrote:
>
> On Thu, 2012-10-25 at 16:12 +0200, Oleg Nesterov wrote:
> > On 07/18, Jovi Zhang wrote:
> > >
> > > --- a/kernel/trace/trace_uprobe.c
> > > +++ b/kernel/trace/trace_uprobe.c
> > > @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> > > if (argv[0][0] == '-')
> > > is_delete = true;
> > > else if (argv[0][0] != 'p') {
> > > - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> > > + pr_info("Probe definition must be started with 'p' or '-'.\n");
> > > return -EINVAL;
> > > }
> >
> > Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
> >
> > Oleg.
>
> Hmm, this doesn't look like it ever got applied to mainline. Was it
> dropped?
I didn't send the pull request yet, will do today.
Oleg.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-11-19 12:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18 3:08 [PATCH] uprobe: fix misleading log entry Jovi Zhang
2012-07-18 9:22 ` Srikar Dronamraju
2012-07-18 11:43 ` Jovi Zhang
2012-07-18 15:24 ` Anton Arapov
2012-10-12 0:06 ` Jovi Zhang
2012-10-12 4:50 ` Srikar Dronamraju
2012-10-25 14:12 ` Oleg Nesterov
2012-11-19 10:42 ` Steven Rostedt
2012-11-19 12:32 ` Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.