From: Roman Yeryomin <email@example.com> To: Michal Kazior <firstname.lastname@example.org> Cc: "Valo, Kalle" <email@example.com>, "Manoharan, Rajkumar" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Rajkumar Manoharan <email@example.com> Subject: Re: ath10k performance, master branch from 20160407 Date: Mon, 16 May 2016 01:59:40 +0300 [thread overview] Message-ID: <CACiydbLrM27V+Jzh-hJ4LhXaKEoiV9Hckw9B96OSXFKHT4Kctg@mail.gmail.com> (raw) In-Reply-To: <CA+BoTQkOLAB5KXo4taFEn_K_uEeLi81shEupVMU7E=97389cpQ@mail.gmail.com> On 9 May 2016 at 15:26, Michal Kazior <firstname.lastname@example.org> wrote: > Hi Roman, > > On 22 April 2016 at 19:05, Roman Yeryomin <email@example.com> wrote: >> On 19 April 2016 at 18:35, Valo, Kalle <firstname.lastname@example.org> wrote: >>> Michal Kazior <email@example.com> writes: >>> >>>> On 19 April 2016 at 09:31, Roman Yeryomin <firstname.lastname@example.org> wrote: >>>>> On 19 April 2016 at 08:28, Michal Kazior <email@example.com> wrote: >>>>> >>>>>> If my hunch is right there's no easy (and proper) fix for that now. >>>>>> >>>>>> One of the patchset patches (ath10k: implement wake_tx_queue) starts >>>>>> to use mac80211 software queuing. This introduces extra induced >>>>>> latency and I'm guessing it results in fill-in-then-drain sequences in >>>>>> some cases which end up being long enough to make fq_codel_drop more >>>>>> work than normal. >>>>>> >>>>>> This is required for other changes and MU-MIMO performance >>>>>> improvements so this patch can't be removed. >>>>> >>>>> But qca988x doesn't support MU-MIMO, AFAIK. >>>> >>>> Correct. >>>> >>>> >>>>> Can this be made chip dependent? >>>> >>>> I guess it could but it'd arguably make the driver more complex and >>>> harder to maintain. What we want is a long-term fix, not a short-term >>>> one. >>> >>> But we should never go backwards and TCP dropping from 750 Mbps to ~550 >>> Mbps is a huge drop, so this is not ok. We have to do something to fix >>> this, be it reverting the wake_tx_queue support, somehow disabling it by >>> default or something. >> >> I would agree with Kalle here. This looks like very serious regression. >> But I'm afraid I can only help with testing here. > > Can you give the following patch a try, please? I didn't get to > reproduce your problem on a real AP135/AP152 board and instead tried > to simulate a slow uni-proc system via KVM and cooling_device in > sysfs. The patch does improve things in this synthetic setup for me. > > http://lists.infradead.org/pipermail/ath10k/2016-May/007526.html > Unfortunately doesn't seem to make any difference at all (really, if there is, it's less than 10Mbps). Please see this thread also: https://lists.openwrt.org/pipermail/openwrt-devel/2016-May/041445.html That is with your and Eric's patch applied. Regards, Roman _______________________________________________ ath10k mailing list firstname.lastname@example.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-05-15 23:00 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-08 14:44 Roman Yeryomin 2016-04-08 15:34 ` Manoharan, Rajkumar 2016-04-08 16:00 ` Roman Yeryomin 2016-04-08 16:41 ` Manoharan, Rajkumar 2016-04-08 17:19 ` Roman Yeryomin 2016-04-09 4:02 ` Manoharan, Rajkumar 2016-04-13 12:44 ` Roman Yeryomin 2016-04-17 9:28 ` Roman Yeryomin 2016-04-17 15:06 ` Manoharan, Rajkumar 2016-04-17 23:03 ` Roman Yeryomin 2016-04-18 13:00 ` Roman Yeryomin 2016-04-19 5:28 ` Michal Kazior 2016-04-19 7:31 ` Roman Yeryomin 2016-04-19 7:43 ` Michal Kazior 2016-04-19 15:35 ` Valo, Kalle 2016-04-22 17:05 ` Roman Yeryomin 2016-05-09 12:26 ` Michal Kazior 2016-05-15 22:59 ` Roman Yeryomin [this message] 2016-05-16 3:57 ` Rajkumar Manoharan 2016-04-22 17:03 ` Roman Yeryomin 2016-04-22 17:02 ` Roman Yeryomin 2016-04-20 9:03 ` Michal Kazior 2016-04-12 10:16 ` Xue Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACiydbLrM27V+Jzh-hJ4LhXaKEoiV9Hckw9B96OSXFKHT4Kctg@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: ath10k performance, master branch from 20160407' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.