From: "Rafał Miłecki" <zajec5@gmail.com>
To: Jon Mason <jon.mason@broadcom.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jon Mason <jonmason@broadcom.com>
Subject: Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT
Date: Tue, 28 Feb 2017 21:43:09 +0100 [thread overview]
Message-ID: <CACna6rw1oeUn=QuD-c+X8uokypSEqXUP3yqmiMEK2wgMD-ENeQ@mail.gmail.com> (raw)
In-Reply-To: <1488313886-17155-2-git-send-email-jon.mason@broadcom.com>
On 28 February 2017 at 21:31, Jon Mason <jon.mason@broadcom.com> wrote:
> @@ -70,10 +70,19 @@
> clocks = <&periph_clk>;
> };
>
> - local-timer@20600 {
> + timer@20600 {
Is there a reason for this rename? I don't really have preference for
any name, it's just we shouldn't keep renaming this depending of
personal preferences.
It also doesn't seem like adjusting to any schema:
bcm63138.dtsi uses local-timer@1e600
bcm-nsp.dtsi uses twd-timer@20600
berlin2cd.dtsi uses local-timer@ad0600
berlin2.dtsi uses local-timer@ad0600
berlin2q.dtsi uses local-timer@ad0600
> compatible = "arm,cortex-a9-twd-timer";
> - reg = <0x20600 0x100>;
> - interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x20600 0x20>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
> + IRQ_TYPE_LEVEL_HIGH)>;
> + clocks = <&periph_clk>;
> + };
The rest looks OK, thanks! :)
--
Rafał
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Jon Mason <jon.mason@broadcom.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Jon Mason <jonmason@broadcom.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT
Date: Tue, 28 Feb 2017 21:43:09 +0100 [thread overview]
Message-ID: <CACna6rw1oeUn=QuD-c+X8uokypSEqXUP3yqmiMEK2wgMD-ENeQ@mail.gmail.com> (raw)
In-Reply-To: <1488313886-17155-2-git-send-email-jon.mason@broadcom.com>
On 28 February 2017 at 21:31, Jon Mason <jon.mason@broadcom.com> wrote:
> @@ -70,10 +70,19 @@
> clocks = <&periph_clk>;
> };
>
> - local-timer@20600 {
> + timer@20600 {
Is there a reason for this rename? I don't really have preference for
any name, it's just we shouldn't keep renaming this depending of
personal preferences.
It also doesn't seem like adjusting to any schema:
bcm63138.dtsi uses local-timer@1e600
bcm-nsp.dtsi uses twd-timer@20600
berlin2cd.dtsi uses local-timer@ad0600
berlin2.dtsi uses local-timer@ad0600
berlin2q.dtsi uses local-timer@ad0600
> compatible = "arm,cortex-a9-twd-timer";
> - reg = <0x20600 0x100>;
> - interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x20600 0x20>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
> + IRQ_TYPE_LEVEL_HIGH)>;
> + clocks = <&periph_clk>;
> + };
The rest looks OK, thanks! :)
--
Rafał
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT
Date: Tue, 28 Feb 2017 21:43:09 +0100 [thread overview]
Message-ID: <CACna6rw1oeUn=QuD-c+X8uokypSEqXUP3yqmiMEK2wgMD-ENeQ@mail.gmail.com> (raw)
In-Reply-To: <1488313886-17155-2-git-send-email-jon.mason@broadcom.com>
On 28 February 2017 at 21:31, Jon Mason <jon.mason@broadcom.com> wrote:
> @@ -70,10 +70,19 @@
> clocks = <&periph_clk>;
> };
>
> - local-timer at 20600 {
> + timer at 20600 {
Is there a reason for this rename? I don't really have preference for
any name, it's just we shouldn't keep renaming this depending of
personal preferences.
It also doesn't seem like adjusting to any schema:
bcm63138.dtsi uses local-timer at 1e600
bcm-nsp.dtsi uses twd-timer at 20600
berlin2cd.dtsi uses local-timer at ad0600
berlin2.dtsi uses local-timer at ad0600
berlin2q.dtsi uses local-timer at ad0600
> compatible = "arm,cortex-a9-twd-timer";
> - reg = <0x20600 0x100>;
> - interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x20600 0x20>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
> + IRQ_TYPE_LEVEL_HIGH)>;
> + clocks = <&periph_clk>;
> + };
The rest looks OK, thanks! :)
--
Rafa?
next prev parent reply other threads:[~2017-02-28 20:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 20:31 [PATCH 0/2] ARM: dts: bcm5301x: Add TWD and I2C Jon Mason
2017-02-28 20:31 ` Jon Mason
2017-02-28 20:31 ` Jon Mason
2017-02-28 20:31 ` [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT Jon Mason
2017-02-28 20:31 ` Jon Mason
2017-02-28 20:31 ` Jon Mason
2017-02-28 20:43 ` Rafał Miłecki [this message]
2017-02-28 20:43 ` Rafał Miłecki
2017-02-28 20:43 ` Rafał Miłecki
2017-02-28 20:46 ` Jon Mason
2017-02-28 20:46 ` Jon Mason
2017-02-28 20:46 ` Jon Mason
2017-02-28 20:48 ` Rafał Miłecki
2017-02-28 20:48 ` Rafał Miłecki
2017-02-28 20:48 ` Rafał Miłecki
2017-03-02 18:54 ` Rafał Miłecki
2017-03-02 18:54 ` Rafał Miłecki
2017-03-02 18:54 ` Rafał Miłecki
2017-03-02 19:00 ` Jon Mason
2017-03-02 19:19 ` Rafał Miłecki
2017-03-02 19:19 ` Rafał Miłecki
2017-03-02 19:19 ` Rafał Miłecki
2017-02-28 20:31 ` [PATCH 2/2] ARM: dts: bcm5301x: Add I2C support to the DT Jon Mason
2017-02-28 20:31 ` Jon Mason
2017-02-28 20:31 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACna6rw1oeUn=QuD-c+X8uokypSEqXUP3yqmiMEK2wgMD-ENeQ@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jon.mason@broadcom.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.