Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

From: "Rafał Miłecki" <zajec5@gmail.com>
To: Viet Nga Dao <vndao@altera.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Nga Chi <ngachi86@gmail.com>
Subject: Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver
Date: Mon, 16 Mar 2015 09:35:00 +0100	[thread overview]
Message-ID: <CACna6rxx9TN1vko0fVPQgJPLZ3ZN17JjPki+q1Y3Ep9e0HppEA@mail.gmail.com> (raw)
In-Reply-To: <1426493782-3791-1-git-send-email-vndao@altera.com>

On 16 March 2015 at 09:16,  <vndao@altera.com> wrote:
> +static struct flash_device flash_devices[] = {
> +       FLASH_ID("epcq16-nonjedec",  2, 0x15),
> +       FLASH_ID("epcq32-nonjedec",  2, 0x16),
> +       FLASH_ID("epcq64-nonjedec",  2, 0x17),
> +       FLASH_ID("epcq128-nonjedec", 2, 0x18),
> +       FLASH_ID("epcq256-nonjedec", 2, 0x19),
> +       FLASH_ID("epcq512-nonjedec", 2, 0x20),

You could probably use EPCQ_OPCODE_ID

> +
> +       FLASH_ID("epcs16-nonjedec",  1, 0x14),
> +       FLASH_ID("epcs64-nonjedec",  1, 0x16),
> +       FLASH_ID("epcs128-nonjedec", 1, 0x18),

And EPCS_OPCODE_ID here.

> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 43bb552..ad0c274 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -683,6 +683,17 @@ static const struct spi_device_id spi_nor_ids[] = {
>         { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>         { "cat25c17", CAT25_INFO( 256, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>         { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> +
> +       /* Altera EPCQ/EPCS Flashes */
> +       { "epcq16-nonjedec",  INFO(0, 0, 0x10000, 32,   0) },
> +       { "epcq32-nonjedec",  INFO(0, 0, 0x10000, 64,   0) },
> +       { "epcq64-nonjedec",  INFO(0, 0, 0x10000, 128,  0) },
> +       { "epcq128-nonjedec", INFO(0, 0, 0x10000, 256,  0) },
> +       { "epcq256-nonjedec", INFO(0, 0, 0x10000, 512,  0) },
> +       { "epcq512-nonjedec", INFO(0, 0, 0x10000, 1024, 0) },
> +       { "epcs16-nonjedec",  INFO(0, 0, 0x10000, 32,   0) },
> +       { "epcs64-nonjedec",  INFO(0, 0, 0x10000, 128,  0) },
> +       { "epcs128-nonjedec", INFO(0, 0, 0x40000, 256,  0) },
>         { },
>  };

But mostly, I just wanted to say I like your integration with spi-nor.
Nice work :)

-- 
Rafał