From: Arnaud Lacombe <lacombar@gmail.com>
To: Anders Kaseorg <andersk@ksplice.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Jan Beulich <jbeulich@novell.com>,
Kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Tim Bird <tim.bird@am.sony.com>
Subject: Re: [PATCH] modpost: Fix modpost's license checking V2
Date: Tue, 12 Jul 2011 14:49:42 -0400 [thread overview]
Message-ID: <CACqU3MUXAOMGQ1nzUrtYPEQAC3U-nuq3YurtNJJLS1hft4ROGA@mail.gmail.com> (raw)
In-Reply-To: <CAFziu1EYYN6imDijo7E_raOfdXfWAMzfJL5OursSBAYk8Wdywg@mail.gmail.com>
Hi,
On Tue, Jul 12, 2011 at 2:35 PM, Anders Kaseorg <andersk@ksplice.com> wrote:
> On Tue, Jul 12, 2011 at 14:15, Arnaud Lacombe <lacombar@gmail.com> wrote:
>> modpost is an host tool, it should not include kernel header. Content
>> of this file is not exported to userland anyway.
>
> My point was more that you might as well reuse the same name and
> probably the same code so that people don’t have to look carefully at
> a new macro to decide whether it’s off-by-one from what they expect.
>
Agree. I was not entirely sure of what you meant, ie. whether
including "include/linux/string.h" or adjusting the name and
definition to match the existing. So I thought it would just be better
to clear any potential misunderstanding :)
- Arnaud
next prev parent reply other threads:[~2011-07-12 18:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 15:00 sorting of exports breaks modpost's GPL checking Jan Beulich
2011-07-05 9:36 ` Alessio Igor Bogani
2011-07-05 9:47 ` Jan Beulich
2011-07-07 1:03 ` Rusty Russell
2011-07-07 8:09 ` Jan Beulich
2011-07-07 12:17 ` Alessio Igor Bogani
2011-07-09 23:13 ` [PATCH] modpost: Fix modpost's license checking Alessio Igor Bogani
2011-07-10 6:08 ` Arnaud Lacombe
2011-07-12 7:00 ` [PATCH] modpost: Fix modpost's license checking V2 Alessio Igor Bogani
2011-07-12 18:02 ` Anders Kaseorg
2011-07-12 18:15 ` Arnaud Lacombe
2011-07-12 18:35 ` Anders Kaseorg
2011-07-12 18:49 ` Arnaud Lacombe [this message]
2011-07-14 6:51 ` [PATCH] modpost: Fix modpost's license checking V3 Alessio Igor Bogani
2011-07-18 23:38 ` Rusty Russell
2011-07-18 23:38 ` Rusty Russell
2011-07-20 15:25 ` Michal Marek
2011-07-21 6:46 ` Rusty Russell
2012-03-24 2:04 ` Frank Rowand
2012-03-24 2:25 ` Frank Rowand
2012-03-24 2:25 ` Frank Rowand
2012-03-27 1:58 ` Frank Rowand
2012-03-27 1:58 ` Frank Rowand
2012-03-27 7:19 ` Alessio Igor Bogani
2012-03-27 22:59 ` Frank Rowand
2012-03-28 8:04 ` Alessio Igor Bogani
2012-03-29 4:37 ` Rusty Russell
2012-03-29 4:37 ` Rusty Russell
2012-04-10 0:59 ` Frank Rowand
2012-04-10 0:59 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACqU3MUXAOMGQ1nzUrtYPEQAC3U-nuq3YurtNJJLS1hft4ROGA@mail.gmail.com \
--to=lacombar@gmail.com \
--cc=abogani@kernel.org \
--cc=andersk@ksplice.com \
--cc=jbeulich@novell.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.