From: Anders Kaseorg <andersk@ksplice.com>
To: Alessio Igor Bogani <abogani@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Jan Beulich <jbeulich@novell.com>,
Kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Tim Bird <tim.bird@am.sony.com>,
Arnaud Lacombe <lacombar@gmail.com>
Subject: Re: [PATCH] modpost: Fix modpost's license checking V2
Date: Tue, 12 Jul 2011 14:02:37 -0400 [thread overview]
Message-ID: <CAFziu1HvspbMj8LRLHd2w9vcVq_mGCL3pCOwLaduKQ4nt8+Utg@mail.gmail.com> (raw)
In-Reply-To: <1310454020-15426-1-git-send-email-abogani@kernel.org>
On Tue, Jul 12, 2011 at 03:00, Alessio Igor Bogani <abogani@kernel.org> wrote:
> +#define SEC_NAME_MATCH(name, str) (strncmp(name, str, strlen(str) - 1) == 0)
Surely you meant strlen() or sizeof() - 1, not strlen() - 1?
> + if (!is_vmlinux(mod->name) && strncmp(symname, "__ksymtab", 9) == 0)
Same strncmp pattern here. BTW, your macro is the strstarts()
function in include/linux/string.h.
Anders
next prev parent reply other threads:[~2011-07-12 18:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 15:00 sorting of exports breaks modpost's GPL checking Jan Beulich
2011-07-05 9:36 ` Alessio Igor Bogani
2011-07-05 9:47 ` Jan Beulich
2011-07-07 1:03 ` Rusty Russell
2011-07-07 8:09 ` Jan Beulich
2011-07-07 12:17 ` Alessio Igor Bogani
2011-07-09 23:13 ` [PATCH] modpost: Fix modpost's license checking Alessio Igor Bogani
2011-07-10 6:08 ` Arnaud Lacombe
2011-07-12 7:00 ` [PATCH] modpost: Fix modpost's license checking V2 Alessio Igor Bogani
2011-07-12 18:02 ` Anders Kaseorg [this message]
2011-07-12 18:15 ` Arnaud Lacombe
2011-07-12 18:35 ` Anders Kaseorg
2011-07-12 18:49 ` Arnaud Lacombe
2011-07-14 6:51 ` [PATCH] modpost: Fix modpost's license checking V3 Alessio Igor Bogani
2011-07-18 23:38 ` Rusty Russell
2011-07-18 23:38 ` Rusty Russell
2011-07-20 15:25 ` Michal Marek
2011-07-21 6:46 ` Rusty Russell
2012-03-24 2:04 ` Frank Rowand
2012-03-24 2:25 ` Frank Rowand
2012-03-24 2:25 ` Frank Rowand
2012-03-27 1:58 ` Frank Rowand
2012-03-27 1:58 ` Frank Rowand
2012-03-27 7:19 ` Alessio Igor Bogani
2012-03-27 22:59 ` Frank Rowand
2012-03-28 8:04 ` Alessio Igor Bogani
2012-03-29 4:37 ` Rusty Russell
2012-03-29 4:37 ` Rusty Russell
2012-04-10 0:59 ` Frank Rowand
2012-04-10 0:59 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFziu1HvspbMj8LRLHd2w9vcVq_mGCL3pCOwLaduKQ4nt8+Utg@mail.gmail.com \
--to=andersk@ksplice.com \
--cc=abogani@kernel.org \
--cc=jbeulich@novell.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.