All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frank.rowand@am.sony.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Rowand, Frank" <Frank_Rowand@sonyusa.com>,
	Alessio Igor Bogani <abogani@kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Jan Beulich <jbeulich@novell.com>,
	Kbuild <linux-kbuild@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Bird, Tim" <Tim.Bird@am.sony.com>,
	Anders Kaseorg <andersk@ksplice.com>,
	Arnaud Lacombe <lacombar@gmail.com>
Subject: Re: [PATCH] modpost: Fix modpost's license checking V3
Date: Fri, 23 Mar 2012 19:25:51 -0700	[thread overview]
Message-ID: <4F6D30AF.8000204@am.sony.com> (raw)
In-Reply-To: <4F6D2BC5.9070200@am.sony.com>

On 03/23/12 19:04, Frank Rowand wrote:
> On 07/13/11 23:51, Alessio Igor Bogani wrote:
>> The commit f02e8a6 sorts symbols placing each of them in its own elf section.
>> The sorting and merging into the canonical sections are done by the linker.
>> Unfortunately modpost to generate Module.symvers file parses vmlinux
> 
> Yet another unfortunately: modpost parses vmlinux.o instead of vmlinux (vmlinux
> does not yet exist at this point of the build).  vmlinux.o also does not have
> the many sections sorted and merged into the canonical sections.  As a result,
> the Module.symvers created my modpost incorrectly reports the license of all

                             ^^^ s/my/by/

> exports as "(unknown)".
> 
> Can you fix this also please?
> 
> 
>> (already linked) and all modules object files (which aren't linked yet).
>> These aren't sanitized by the linker yet. That breaks modpost that can't
>> detect license properly for modules. This patch makes modpost aware of
>> the new exported symbols structure.
>>
>> Thanks to Arnaud Lacombe <lacombar@gmail.com> and Anders Kaseorg
>> <andersk@ksplice.com> for providing useful suggestions about code.
>>
>> This work was supported by a hardware donation from the CE Linux Forum.
>>
>> Reported-by: Jan Beulich <jbeulich@novell.com>
>> Signed-off-by: Alessio Igor Bogani <abogani@kernel.org>
>> ---
>>  scripts/mod/modpost.c |   29 ++++++++++++++++++++++++++++-
>>  1 files changed, 28 insertions(+), 1 deletions(-)
> 
> < snip >
> 
> -Frank Rowand
> .
> 



WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frank.rowand@am.sony.com>
Cc: "Rowand, Frank" <Frank_Rowand@sonyusa.com>,
	Alessio Igor Bogani <abogani@kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Jan Beulich <jbeulich@novell.com>,
	Kbuild <linux-kbuild@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Bird, Tim" <Tim.Bird@am.sony.com>,
	Anders Kaseorg <andersk@ksplice.com>,
	Arnaud Lacombe <lacombar@gmail.com>
Subject: Re: [PATCH] modpost: Fix modpost's license checking V3
Date: Fri, 23 Mar 2012 19:25:51 -0700	[thread overview]
Message-ID: <4F6D30AF.8000204@am.sony.com> (raw)
In-Reply-To: <4F6D2BC5.9070200@am.sony.com>

On 03/23/12 19:04, Frank Rowand wrote:
> On 07/13/11 23:51, Alessio Igor Bogani wrote:
>> The commit f02e8a6 sorts symbols placing each of them in its own elf section.
>> The sorting and merging into the canonical sections are done by the linker.
>> Unfortunately modpost to generate Module.symvers file parses vmlinux
> 
> Yet another unfortunately: modpost parses vmlinux.o instead of vmlinux (vmlinux
> does not yet exist at this point of the build).  vmlinux.o also does not have
> the many sections sorted and merged into the canonical sections.  As a result,
> the Module.symvers created my modpost incorrectly reports the license of all

                             ^^^ s/my/by/

> exports as "(unknown)".
> 
> Can you fix this also please?
> 
> 
>> (already linked) and all modules object files (which aren't linked yet).
>> These aren't sanitized by the linker yet. That breaks modpost that can't
>> detect license properly for modules. This patch makes modpost aware of
>> the new exported symbols structure.
>>
>> Thanks to Arnaud Lacombe <lacombar@gmail.com> and Anders Kaseorg
>> <andersk@ksplice.com> for providing useful suggestions about code.
>>
>> This work was supported by a hardware donation from the CE Linux Forum.
>>
>> Reported-by: Jan Beulich <jbeulich@novell.com>
>> Signed-off-by: Alessio Igor Bogani <abogani@kernel.org>
>> ---
>>  scripts/mod/modpost.c |   29 ++++++++++++++++++++++++++++-
>>  1 files changed, 28 insertions(+), 1 deletions(-)
> 
> < snip >
> 
> -Frank Rowand
> .
> 



  reply	other threads:[~2012-03-24  2:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 15:00 sorting of exports breaks modpost's GPL checking Jan Beulich
2011-07-05  9:36 ` Alessio Igor Bogani
2011-07-05  9:47   ` Jan Beulich
2011-07-07  1:03     ` Rusty Russell
2011-07-07  8:09       ` Jan Beulich
2011-07-07 12:17         ` Alessio Igor Bogani
2011-07-09 23:13           ` [PATCH] modpost: Fix modpost's license checking Alessio Igor Bogani
2011-07-10  6:08             ` Arnaud Lacombe
2011-07-12  7:00               ` [PATCH] modpost: Fix modpost's license checking V2 Alessio Igor Bogani
2011-07-12 18:02                 ` Anders Kaseorg
2011-07-12 18:15                   ` Arnaud Lacombe
2011-07-12 18:35                     ` Anders Kaseorg
2011-07-12 18:49                       ` Arnaud Lacombe
2011-07-14  6:51                         ` [PATCH] modpost: Fix modpost's license checking V3 Alessio Igor Bogani
2011-07-18 23:38                           ` Rusty Russell
2011-07-18 23:38                             ` Rusty Russell
2011-07-20 15:25                           ` Michal Marek
2011-07-21  6:46                             ` Rusty Russell
2012-03-24  2:04                           ` Frank Rowand
2012-03-24  2:25                             ` Frank Rowand [this message]
2012-03-24  2:25                               ` Frank Rowand
2012-03-27  1:58                             ` Frank Rowand
2012-03-27  1:58                               ` Frank Rowand
2012-03-27  7:19                               ` Alessio Igor Bogani
2012-03-27 22:59                                 ` Frank Rowand
2012-03-28  8:04                                   ` Alessio Igor Bogani
2012-03-29  4:37                               ` Rusty Russell
2012-03-29  4:37                                 ` Rusty Russell
2012-04-10  0:59                                 ` Frank Rowand
2012-04-10  0:59                                   ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6D30AF.8000204@am.sony.com \
    --to=frank.rowand@am.sony.com \
    --cc=Frank_Rowand@sonyusa.com \
    --cc=Tim.Bird@am.sony.com \
    --cc=abogani@kernel.org \
    --cc=andersk@ksplice.com \
    --cc=jbeulich@novell.com \
    --cc=lacombar@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.