* [PATCH v4] Staging: pi433: Fix line over 80 characters issue
@ 2019-03-03 10:01 Debleena Sen
2019-03-03 10:06 ` [Outreachy kernel] " Julia Lawall
2019-03-05 7:40 ` Greg KH
0 siblings, 2 replies; 8+ messages in thread
From: Debleena Sen @ 2019-03-03 10:01 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Debleena Sen
Break the line and match the indentation to remove the
checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
drivers/staging/pi433/rf69.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e19b9ce..0c189a7 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
{
switch (flag) {
case mode_switch_completed:
- return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_MODE_READY);
+ return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+ MASK_IRQFLAGS1_MODE_READY);
case ready_to_receive:
return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RX_READY);
case ready_to_send:
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-03 10:01 [PATCH v4] Staging: pi433: Fix line over 80 characters issue Debleena Sen
@ 2019-03-03 10:06 ` Julia Lawall
2019-03-05 7:40 ` Greg KH
1 sibling, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2019-03-03 10:06 UTC (permalink / raw)
To: Debleena Sen; +Cc: gregkh, outreachy-kernel
On Sun, 3 Mar 2019, Debleena Sen wrote:
> Break the line and match the indentation to remove the
> checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/pi433/rf69.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index e19b9ce..0c189a7 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
> {
> switch (flag) {
> case mode_switch_completed:
> - return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_MODE_READY);
> + return (rf69_read_reg(spi, REG_IRQFLAGS1) &
> + MASK_IRQFLAGS1_MODE_READY);
> case ready_to_receive:
> return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RX_READY);
> case ready_to_send:
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551607296-33723-1-git-send-email-idebleenasen%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-03 10:01 [PATCH v4] Staging: pi433: Fix line over 80 characters issue Debleena Sen
2019-03-03 10:06 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-05 7:40 ` Greg KH
2019-03-05 14:00 ` Debleena Sen
2019-03-05 16:24 ` Debleena Sen
1 sibling, 2 replies; 8+ messages in thread
From: Greg KH @ 2019-03-05 7:40 UTC (permalink / raw)
To: Debleena Sen; +Cc: outreachy-kernel
On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> Break the line and match the indentation to remove the
> checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> ---
> drivers/staging/pi433/rf69.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What changed from the previous versions? That information always goes
below the --- line please.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-05 7:40 ` Greg KH
@ 2019-03-05 14:00 ` Debleena Sen
2019-03-05 16:24 ` Debleena Sen
1 sibling, 0 replies; 8+ messages in thread
From: Debleena Sen @ 2019-03-05 14:00 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Tue, 5 Mar 2019, 13:10 Greg KH, <gregkh@linuxfoundation.org> wrote:
> On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > Break the line and match the indentation to remove the
> > checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > ---
> > drivers/staging/pi433/rf69.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> What changed from the previous versions? That information always goes
> below the --- line please.
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>
Will do.
Thnaks,
Debleena
[-- Attachment #2: Type: text/html, Size: 1220 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-05 7:40 ` Greg KH
2019-03-05 14:00 ` Debleena Sen
@ 2019-03-05 16:24 ` Debleena Sen
2019-03-06 9:15 ` Greg KH
1 sibling, 1 reply; 8+ messages in thread
From: Debleena Sen @ 2019-03-05 16:24 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > Break the line and match the indentation to remove the
> > checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > ---
> > drivers/staging/pi433/rf69.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> What changed from the previous versions? That information always goes
> below the --- line please.
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>
I'm not able to find the commit.
I tried using "git reset --mixed e19b9ce" but it shows an error:
error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
commit
fatal: could not parse object 'e19b9ce'
How can I recover it so that I can add the changes?
Thank you,
Debleena
[-- Attachment #2: Type: text/html, Size: 1593 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-05 16:24 ` Debleena Sen
@ 2019-03-06 9:15 ` Greg KH
2019-03-06 9:33 ` [Outreachy kernel] " Julia Lawall
[not found] ` <CACw+u4EWiZyqyYmuyK_5vMq+x5B-iB7-Z1JyeiT8_amOMyd3pQ@mail.gmail.com>
0 siblings, 2 replies; 8+ messages in thread
From: Greg KH @ 2019-03-06 9:15 UTC (permalink / raw)
To: Debleena Sen; +Cc: outreachy-kernel
On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote:
> On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > > Break the line and match the indentation to remove the
> > > checkpatch.pl warning:
> > > WARNING: line over 80 characters
> > >
> > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > > ---
> > > drivers/staging/pi433/rf69.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > What changed from the previous versions? That information always goes
> > below the --- line please.
> >
> > Please fix up and resend.
> >
> > thanks,
> >
> > greg k-h
> >
>
> I'm not able to find the commit.
>
> I tried using "git reset --mixed e19b9ce" but it shows an error:
>
> error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
> commit
> fatal: could not parse object 'e19b9ce'
>
> How can I recover it so that I can add the changes?
I have no idea what you are trying to do here, sorry. Why are you
running 'git reset'?
confused,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-06 9:15 ` Greg KH
@ 2019-03-06 9:33 ` Julia Lawall
[not found] ` <CACw+u4EWiZyqyYmuyK_5vMq+x5B-iB7-Z1JyeiT8_amOMyd3pQ@mail.gmail.com>
1 sibling, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2019-03-06 9:33 UTC (permalink / raw)
To: Greg KH; +Cc: Debleena Sen, outreachy-kernel
On Wed, 6 Mar 2019, Greg KH wrote:
> On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote:
> > On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > > > Break the line and match the indentation to remove the
> > > > checkpatch.pl warning:
> > > > WARNING: line over 80 characters
> > > >
> > > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > > > ---
> > > > drivers/staging/pi433/rf69.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > What changed from the previous versions? That information always goes
> > > below the --- line please.
> > >
> > > Please fix up and resend.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > I'm not able to find the commit.
> >
> > I tried using "git reset --mixed e19b9ce" but it shows an error:
> >
> > error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
> > commit
> > fatal: could not parse object 'e19b9ce'
> >
> > How can I recover it so that I can add the changes?
>
> I have no idea what you are trying to do here, sorry. Why are you
> running 'git reset'?
If you get confused with git, just undo the whole thing and start over.
julia
>
> confused,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306091544.GE7927%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Fwd: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
[not found] ` <CACw+u4EWiZyqyYmuyK_5vMq+x5B-iB7-Z1JyeiT8_amOMyd3pQ@mail.gmail.com>
@ 2019-03-06 9:46 ` Debleena Sen
0 siblings, 0 replies; 8+ messages in thread
From: Debleena Sen @ 2019-03-06 9:46 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2105 bytes --]
---------- Forwarded message ---------
From: Debleena Sen <idebleenasen@gmail.com>
Date: Wed, Mar 6, 2019 at 3:10 PM
Subject: Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
To: Greg KH <gregkh@linuxfoundation.org>
On Wed, Mar 6, 2019 at 2:45 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote:
> > On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org>
> wrote:
> >
> > > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > > > Break the line and match the indentation to remove the
> > > > checkpatch.pl warning:
> > > > WARNING: line over 80 characters
> > > >
> > > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > > > ---
> > > > drivers/staging/pi433/rf69.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > What changed from the previous versions? That information always goes
> > > below the --- line please.
> > >
> > > Please fix up and resend.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > I'm not able to find the commit.
> >
> > I tried using "git reset --mixed e19b9ce" but it shows an error:
> >
> > error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
> > commit
> > fatal: could not parse object 'e19b9ce'
> >
> > How can I recover it so that I can add the changes?
>
> I have no idea what you are trying to do here, sorry. Why are you
> running 'git reset'?
>
> confused,
>
> greg k-h
>
In the tutorial it was written to edit a commit we need to use git reset
--mixed <file ID>
So I thought to use that.
It was my first patch probably. I already told you in another mail that
there were like 16 warnings of the same type and same styling issue in
pi433/rf69.c
So in this patch I had fixed only one warning. Yesterday I sent another
patch in which I've fixed the other 15 warnings.
In the tutorial, it was written to edit a commit we need to use git reset
--mixed <file ID>
So I thought to use that to add the version change log.
But when I tried it, this error popped.
I'm sorry. I think I've messed up.
[-- Attachment #2: Type: text/html, Size: 3497 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-06 9:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-03 10:01 [PATCH v4] Staging: pi433: Fix line over 80 characters issue Debleena Sen
2019-03-03 10:06 ` [Outreachy kernel] " Julia Lawall
2019-03-05 7:40 ` Greg KH
2019-03-05 14:00 ` Debleena Sen
2019-03-05 16:24 ` Debleena Sen
2019-03-06 9:15 ` Greg KH
2019-03-06 9:33 ` [Outreachy kernel] " Julia Lawall
[not found] ` <CACw+u4EWiZyqyYmuyK_5vMq+x5B-iB7-Z1JyeiT8_amOMyd3pQ@mail.gmail.com>
2019-03-06 9:46 ` Fwd: " Debleena Sen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.