[U-Boot] [PATCH v2 1/8] sf: spansion: Update the name for S25FL256S flash

[U-Boot] [PATCH v2 1/8] sf: spansion: Update the name for S25FL256S flash

[Jagannadha Sutradharudu Teki]

As the per the ID tabl the flash is under Uniform 64-kB sector
architecture, hence updated with proper name.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
	- none

 drivers/mtd/spi/spansion.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index 307b852..2218e2f 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -108,7 +108,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.idcode2 = 0x4d01,
 		.pages_per_sector = 256,
 		.nr_sectors = 512,
-		.name = "S25FL256S",
+		.name = "S25FL256S_64K",
 	},
 };
 
-- 
1.8.3

[U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[Jagannadha Sutradharudu Teki]

This commit is based on the patch from Xie Xiaobo <X.Xie@freescale.com>
with commit head title as "sf: spansion: Add support for S25FL128S".
pulled the same code changes into current u-boot tree with little update
on the name field.

http://patchwork.ozlabs.org/patch/218145/

SPANSION recommend S25FL128S supersedes S25FL129P, and the two flash
memory have the same device ID and Memory architecture. So they can
use the same config parameters.

Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none

 drivers/mtd/spi/spansion.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index 2218e2f..dad4fbb 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -101,7 +101,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.idcode2 = 0x4d01,
 		.pages_per_sector = 256,
 		.nr_sectors = 256,
-		.name = "S25FL129P_64K",
+		.name = "S25FL129P_64K/S25FL128S_64K",
 	},
 	{
 		.idcode1 = 0x0219,
-- 
1.8.3

[U-Boot] [PATCH v2 3/8] sf: winbond: Add support for W25Q80BW

[Jagannadha Sutradharudu Teki]

Add support for Winbond W25Q80BW SPI flash.

This patch corrected the flash name, nr_blocks and
also commit message header from below patch.
"sf: winbond: add W25Q32"
(sha1: c969abc47033d6f810d3c9dbdb994ea9d691d038)

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none

 drivers/mtd/spi/winbond.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index cb57ce0..a7cd51f 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -84,8 +84,8 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 	},
 	{
 		.id			= 0x5014,
-		.nr_blocks		= 128,
-		.name			= "W25Q80",
+		.nr_blocks		= 16,
+		.name			= "W25Q80BW",
 	},
 	{
 		.id			= 0x6016,
-- 
1.8.3

[U-Boot] [PATCH v2 4/8] sf: winbond: Correct the nr_blocks used for W25Q32DW

[Jagannadha Sutradharudu Teki]

This patch corrected the nr_blocks used for W25Q32DW SPI flash.

nr_blcoks are incorrectly assigned on below patch
"sf: winbond: add W25Q32DW"
(sha1: 772ba15474f73adc942e817cc072b6e9750836cc)

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none

 drivers/mtd/spi/winbond.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index a7cd51f..8457808 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -89,7 +89,7 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 	},
 	{
 		.id			= 0x6016,
-		.nr_blocks		= 512,
+		.nr_blocks		= 64,
 		.name			= "W25Q32DW",
 	},
 	{
-- 
1.8.3

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Jagannadha Sutradharudu Teki]

Use the exact names for W25Q 0x40XX ID's flash parts, as the same
sizes of flashes comes with different ID's. so-that the distinguishes
becomes easy with this change.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none

 drivers/mtd/spi/winbond.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index 8457808..3c0ca88 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 	{
 		.id			= 0x4014,
 		.nr_blocks		= 16,
-		.name			= "W25Q80BL",
+		.name			= "W25Q80BL/W25Q80BV",
 	},
 	{
 		.id			= 0x4015,
 		.nr_blocks		= 32,
-		.name			= "W25Q16",
+		.name			= "W25Q16CL/W25Q16DV",
 	},
 	{
 		.id			= 0x4016,
 		.nr_blocks		= 64,
-		.name			= "W25Q32",
+		.name			= "W25Q32BV",
 	},
 	{
 		.id			= 0x4017,
 		.nr_blocks		= 128,
-		.name			= "W25Q64",
+		.name			= "W25Q64CV",
 	},
 	{
 		.id			= 0x4018,
 		.nr_blocks		= 256,
-		.name			= "W25Q128",
+		.name			= "W25Q128BV",
 	},
 	{
 		.id			= 0x4019,
-- 
1.8.3

[U-Boot] [PATCH v2 6/8] sf: winbond: Add support for W25Q128FW

[Jagannadha Sutradharudu Teki]

Add support for Winbond W25Q128FW SPI flash.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none

 drivers/mtd/spi/winbond.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index 3c0ca88..e07480b 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -97,6 +97,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 		.nr_blocks		= 128,
 		.name			= "W25Q64DW",
 	},
+	{
+		.id			= 0x6018,
+		.nr_blocks		= 256,
+		.name			= "W25Q128FW",
+	},
 };
 
 struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
-- 
1.8.3

[U-Boot] [PATCH v2 7/8] sf: winbond: Add support for W25Q16DW

[Jagannadha Sutradharudu Teki]

Add support for Winbond W25Q16DW SPI flash.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none

 drivers/mtd/spi/winbond.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index e07480b..9fb4910 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -88,6 +88,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 		.name			= "W25Q80BW",
 	},
 	{
+		.id			= 0x6015,
+		.nr_blocks		= 32,
+		.name			= "W25Q16DW",
+	},
+	{
 		.id			= 0x6016,
 		.nr_blocks		= 64,
 		.name			= "W25Q32DW",
-- 
1.8.3

[U-Boot] [PATCH v2 8/8] sf: winbond: Add support for W25QXXXFV

[Jagannadha Sutradharudu Teki]

Add support for Winbond W25QXXXFV SPI flash.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none
	
 drivers/mtd/spi/winbond.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index 9fb4910..c399bf1 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -65,17 +65,17 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 	{
 		.id			= 0x4016,
 		.nr_blocks		= 64,
-		.name			= "W25Q32BV",
+		.name			= "W25Q32BV/W25Q32FV_SPI",
 	},
 	{
 		.id			= 0x4017,
 		.nr_blocks		= 128,
-		.name			= "W25Q64CV",
+		.name			= "W25Q64CV/W25Q64FV_SPI",
 	},
 	{
 		.id			= 0x4018,
 		.nr_blocks		= 256,
-		.name			= "W25Q128BV",
+		.name			= "W25Q128BV/W25Q128FV_SPI",
 	},
 	{
 		.id			= 0x4019,
@@ -95,17 +95,17 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 	{
 		.id			= 0x6016,
 		.nr_blocks		= 64,
-		.name			= "W25Q32DW",
+		.name			= "W25Q32DW/W25Q32FV_QPI",
 	},
 	{
 		.id			= 0x6017,
 		.nr_blocks		= 128,
-		.name			= "W25Q64DW",
+		.name			= "W25Q64DW/W25Q64FV_QPI",
 	},
 	{
 		.id			= 0x6018,
 		.nr_blocks		= 256,
-		.name			= "W25Q128FW",
+		.name			= "W25Q128FW/W25Q128FV_QPI",
 	},
 };
 
-- 
1.8.3

[U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[Jagan Teki]

On Thu, May 30, 2013 at 7:19 PM, Jagannadha Sutradharudu Teki
<jagannadha.sutradharudu-teki@xilinx.com> wrote:
> This commit is based on the patch from Xie Xiaobo <X.Xie@freescale.com>
> with commit head title as "sf: spansion: Add support for S25FL128S".
> pulled the same code changes into current u-boot tree with little update
> on the name field.
>
> http://patchwork.ozlabs.org/patch/218145/
>
> SPANSION recommend S25FL128S supersedes S25FL129P, and the two flash
> memory have the same device ID and Memory architecture. So they can
> use the same config parameters.
>
> Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> Changes for v2:
>         - none
>
>  drivers/mtd/spi/spansion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
> index 2218e2f..dad4fbb 100644
> --- a/drivers/mtd/spi/spansion.c
> +++ b/drivers/mtd/spi/spansion.c
> @@ -101,7 +101,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
>                 .idcode2 = 0x4d01,
>                 .pages_per_sector = 256,
>                 .nr_sectors = 256,
> -               .name = "S25FL129P_64K",
> +               .name = "S25FL129P_64K/S25FL128S_64K",

Any comments on this notation, as the ID's are same for these parts upto 5bytes.
if you need to differ then we should read the 6th byte.

If i.e the case increase the byte count on probe function for this, due to extra
over head only for this, i just noted like this. does it make sense?

Request comments.

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Jagan Teki]

Hi,

On Thu, May 30, 2013 at 7:19 PM, Jagannadha Sutradharudu Teki
<jagannadha.sutradharudu-teki@xilinx.com> wrote:
> Use the exact names for W25Q 0x40XX ID's flash parts, as the same
> sizes of flashes comes with different ID's. so-that the distinguishes
> becomes easy with this change.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> Changes for v2:
>         - none
>
>  drivers/mtd/spi/winbond.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
> index 8457808..3c0ca88 100644
> --- a/drivers/mtd/spi/winbond.c
> +++ b/drivers/mtd/spi/winbond.c
> @@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>         {
>                 .id                     = 0x4014,
>                 .nr_blocks              = 16,
> -               .name                   = "W25Q80BL",
> +               .name                   = "W25Q80BL/W25Q80BV",
>         },
>         {
>                 .id                     = 0x4015,
>                 .nr_blocks              = 32,
> -               .name                   = "W25Q16",
> +               .name                   = "W25Q16CL/W25Q16DV",

The id codes were same for these two parts, I think there is no way to
detect the separately.
Any idea?

Thanks,
Jagan.

>         },
>         {
>                 .id                     = 0x4016,
>                 .nr_blocks              = 64,
> -               .name                   = "W25Q32",
> +               .name                   = "W25Q32BV",
>         },
>         {
>                 .id                     = 0x4017,
>                 .nr_blocks              = 128,
> -               .name                   = "W25Q64",
> +               .name                   = "W25Q64CV",
>         },
>         {
>                 .id                     = 0x4018,
>                 .nr_blocks              = 256,
> -               .name                   = "W25Q128",
> +               .name                   = "W25Q128BV",
>         },
>         {
>                 .id                     = 0x4019,
> --
> 1.8.3
>
>

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Jagan Teki]

Hi Syed,

On Mon, Jun 3, 2013 at 12:53 AM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> Hi,
>
> On Thu, May 30, 2013 at 7:19 PM, Jagannadha Sutradharudu Teki
> <jagannadha.sutradharudu-teki@xilinx.com> wrote:
>> Use the exact names for W25Q 0x40XX ID's flash parts, as the same
>> sizes of flashes comes with different ID's. so-that the distinguishes
>> becomes easy with this change.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>> ---
>> Changes for v2:
>>         - none
>>
>>  drivers/mtd/spi/winbond.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
>> index 8457808..3c0ca88 100644
>> --- a/drivers/mtd/spi/winbond.c
>> +++ b/drivers/mtd/spi/winbond.c
>> @@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>>         {
>>                 .id                     = 0x4014,
>>                 .nr_blocks              = 16,
>> -               .name                   = "W25Q80BL",
>> +               .name                   = "W25Q80BL/W25Q80BV",
>>         },
>>         {
>>                 .id                     = 0x4015,
>>                 .nr_blocks              = 32,
>> -               .name                   = "W25Q16",
>> +               .name                   = "W25Q16CL/W25Q16DV",
>
> The id codes were same for these two parts, I think there is no way to
> detect the separately.
> Any idea?

Any comments on this.

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Syed Hussain]

Copying Mike, Technical Marketing Director

-----Original Message-----
From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
Sent: Monday, June 03, 2013 11:03 PM
To: US30 Syed Hussain
Cc: u-boot at lists.denx.de; Michal Simek; Tom Rini; Simon Glass; Jagannadha Sutradharudu Teki
Subject: Re: [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

Hi Syed,

On Mon, Jun 3, 2013 at 12:53 AM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> Hi,
>
> On Thu, May 30, 2013 at 7:19 PM, Jagannadha Sutradharudu Teki
> <jagannadha.sutradharudu-teki@xilinx.com> wrote:
>> Use the exact names for W25Q 0x40XX ID's flash parts, as the same
>> sizes of flashes comes with different ID's. so-that the distinguishes
>> becomes easy with this change.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>> ---
>> Changes for v2:
>>         - none
>>
>>  drivers/mtd/spi/winbond.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
>> index 8457808..3c0ca88 100644
>> --- a/drivers/mtd/spi/winbond.c
>> +++ b/drivers/mtd/spi/winbond.c
>> @@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>>         {
>>                 .id                     = 0x4014,
>>                 .nr_blocks              = 16,
>> -               .name                   = "W25Q80BL",
>> +               .name                   = "W25Q80BL/W25Q80BV",
>>         },
>>         {
>>                 .id                     = 0x4015,
>>                 .nr_blocks              = 32,
>> -               .name                   = "W25Q16",
>> +               .name                   = "W25Q16CL/W25Q16DV",
>
> The id codes were same for these two parts, I think there is no way to
> detect the separately.
> Any idea?

Any comments on this.

--
Thanks,
Jagan.

The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email irrelevant to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[MCHEN4 at winbond.com]

Jagan,

So far, our major customer request is to have the same ID for backward compatibility. Therefore the IDs are the same for W25Q16C and W25Q16D. As for the 2.5V parts (W25Q80BL/W25Q16CL), they are the same die as the 3V (W25Q80BV/W25Q16CV), so the IDs are the same as well.

The differences between the pairs are not that significant. We consider them as drop-in compatible.

Best Regards,
Mike Chen

Technical Marketing
Winbond Electronics Corp. America
(408)544-2667

-----Original Message-----
From: US30 Syed Hussain
Sent: Tuesday, June 04, 2013 10:12 AM
To: Jagan Teki; US20 Hui (Mike) Chen
Cc: u-boot at lists.denx.de; Michal Simek; Tom Rini; Simon Glass; Jagannadha Sutradharudu Teki
Subject: RE: [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

Copying Mike, Technical Marketing Director

-----Original Message-----
From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
Sent: Monday, June 03, 2013 11:03 PM
To: US30 Syed Hussain
Cc: u-boot at lists.denx.de; Michal Simek; Tom Rini; Simon Glass; Jagannadha Sutradharudu Teki
Subject: Re: [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

Hi Syed,

On Mon, Jun 3, 2013 at 12:53 AM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> Hi,
>
> On Thu, May 30, 2013 at 7:19 PM, Jagannadha Sutradharudu Teki
> <jagannadha.sutradharudu-teki@xilinx.com> wrote:
>> Use the exact names for W25Q 0x40XX ID's flash parts, as the same
>> sizes of flashes comes with different ID's. so-that the distinguishes
>> becomes easy with this change.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>> ---
>> Changes for v2:
>>         - none
>>
>>  drivers/mtd/spi/winbond.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
>> index 8457808..3c0ca88 100644
>> --- a/drivers/mtd/spi/winbond.c
>> +++ b/drivers/mtd/spi/winbond.c
>> @@ -55,27 +55,27 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>>         {
>>                 .id                     = 0x4014,
>>                 .nr_blocks              = 16,
>> -               .name                   = "W25Q80BL",
>> +               .name                   = "W25Q80BL/W25Q80BV",
>>         },
>>         {
>>                 .id                     = 0x4015,
>>                 .nr_blocks              = 32,
>> -               .name                   = "W25Q16",
>> +               .name                   = "W25Q16CL/W25Q16DV",
>
> The id codes were same for these two parts, I think there is no way to
> detect the separately.
> Any idea?

Any comments on this.

--
Thanks,
Jagan.

The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email irrelevant to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Jagan Teki]

On Tue, Jun 4, 2013 at 10:49 PM, MCHEN4 at winbond.com <MCHEN4@winbond.com> wrote:
> Jagan,
>
> So far, our major customer request is to have the same ID for backward compatibility. Therefore the IDs are the same for W25Q16C and W25Q16D. As for the 2.5V parts (W25Q80BL/W25Q16CL), they are the same die as the 3V (W25Q80BV/W25Q16CV), so the IDs are the same as well.
>
> The differences between the pairs are not that significant. We consider them as drop-in compatible.

Ok, thanks for your response.

And are your ok with below representation for common id's parts ?
+               .name                   = "W25Q80BL/W25Q80BV",
+               .name                   = "W25Q16CL/W25Q16DV",
+               .name                   = "W25Q32BV/W25Q32FV_SPI",
+               .name                   = "W25Q64CV/W25Q64FV_SPI",
+               .name                   = "W25Q128BV/W25Q128FV_SPI",
+               .name                   = "W25Q32DW/W25Q32FV_QPI",
+               .name                   = "W25Q64DW/W25Q64FV_QPI",
+               .name                   = "W25Q128FW/W25Q128FV_QPI",

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[MCHEN4 at winbond.com]

Jagan,

Yes, it is OK. Of course, the 3V QPI IDs of W25Q32FV/64FV/128FV are identical to that of the 1.8V devices (W25Q32DW/64DW/128FW). It may not be a good idea but it's too late for us to change.

Best Regards,
Mike Chen

Technical Marketing
Winbond Electronics Corp. America
(408)544-2667


-----Original Message-----
From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
Sent: Tuesday, June 04, 2013 10:26 AM
To: US20 Hui (Mike) Chen
Cc: US30 Syed Hussain; u-boot at lists.denx.de; Michal Simek; Tom Rini; Simon Glass; Jagannadha Sutradharudu Teki
Subject: Re: [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

On Tue, Jun 4, 2013 at 10:49 PM, MCHEN4 at winbond.com <MCHEN4@winbond.com> wrote:
> Jagan,
>
> So far, our major customer request is to have the same ID for backward compatibility. Therefore the IDs are the same for W25Q16C and W25Q16D. As for the 2.5V parts (W25Q80BL/W25Q16CL), they are the same die as the 3V (W25Q80BV/W25Q16CV), so the IDs are the same as well.
>
> The differences between the pairs are not that significant. We consider them as drop-in compatible.

Ok, thanks for your response.

And are your ok with below representation for common id's parts ?
+               .name                   = "W25Q80BL/W25Q80BV",
+               .name                   = "W25Q16CL/W25Q16DV",
+               .name                   = "W25Q32BV/W25Q32FV_SPI",
+               .name                   = "W25Q64CV/W25Q64FV_SPI",
+               .name                   = "W25Q128BV/W25Q128FV_SPI",
+               .name                   = "W25Q32DW/W25Q32FV_QPI",
+               .name                   = "W25Q64DW/W25Q64FV_QPI",
+               .name                   = "W25Q128FW/W25Q128FV_QPI",

--
Thanks,
Jagan.

The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email irrelevant to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Michal Simek]

move this discussion back to mailing list.

On 06/05/2013 05:56 PM, Jagan Teki wrote:
>>>> And are your ok with below representation for common id's parts ?
>>>> +               .name                   = "W25Q80BL/W25Q80BV",
>>>> +               .name                   = "W25Q16CL/W25Q16DV",
>>>> +               .name                   = "W25Q32BV/W25Q32FV_SPI",
>>>> +               .name                   = "W25Q64CV/W25Q64FV_SPI",
>>>> +               .name                   = "W25Q128BV/W25Q128FV_SPI",
>>>> +               .name                   = "W25Q32DW/W25Q32FV_QPI",
>>>> +               .name                   = "W25Q64DW/W25Q64FV_QPI",
>>>> +               .name                   = "W25Q128FW/W25Q128FV_QPI",
>>>
>>> Any comments on above representation of part names, as the id's to
>>> these pairs are common.
>>> This will enhance u-boot sf to support all parts from winbond, but
>>> seems like different view of names.
>>>
>>
>> what's the difference between that parts?
> 
> parts were diff in terms of voltages and sone SPI and QPI configurations.
> but from the manufacture defeat, pair of parts were same ID's

ok.

>> Does software care if it is W25G80BL or BV?
>> Or software behaviour is the same and there is only difference in voltage
>> or so.
> 
> SW is same even if it 1.8 or 3.3 v.
> The only reason for giving the pair of names to support all different parts

You are supporting them but you are just not list them.

>> I don't care about it so much but it is increase u-boot size.
> Why does u-boot size increase, is it because of  below representation
> on name filed
>       = "W25Q80BL/W25Q80BV"

Just because of longer names which go probably to rodata section.

It is not a problem for me at all.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130606/18ddcec5/attachment.pgp>

[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Jagan Teki]

On Thu, Jun 6, 2013 at 11:02 AM, Michal Simek <monstr@monstr.eu> wrote:
> move this discussion back to mailing list.
>
> On 06/05/2013 05:56 PM, Jagan Teki wrote:
>>>>> And are your ok with below representation for common id's parts ?
>>>>> +               .name                   = "W25Q80BL/W25Q80BV",
>>>>> +               .name                   = "W25Q16CL/W25Q16DV",
>>>>> +               .name                   = "W25Q32BV/W25Q32FV_SPI",
>>>>> +               .name                   = "W25Q64CV/W25Q64FV_SPI",
>>>>> +               .name                   = "W25Q128BV/W25Q128FV_SPI",
>>>>> +               .name                   = "W25Q32DW/W25Q32FV_QPI",
>>>>> +               .name                   = "W25Q64DW/W25Q64FV_QPI",
>>>>> +               .name                   = "W25Q128FW/W25Q128FV_QPI",
>>>>
>>>> Any comments on above representation of part names, as the id's to
>>>> these pairs are common.
>>>> This will enhance u-boot sf to support all parts from winbond, but
>>>> seems like different view of names.
>>>>
>>>
>>> what's the difference between that parts?
>>
>> parts were diff in terms of voltages and sone SPI and QPI configurations.
>> but from the manufacture defeat, pair of parts were same ID's
>
> ok.
>
>>> Does software care if it is W25G80BL or BV?
>>> Or software behaviour is the same and there is only difference in voltage
>>> or so.
>>
>> SW is same even if it 1.8 or 3.3 v.
>> The only reason for giving the pair of names to support all different parts
>
> You are supporting them but you are just not list them.
>
>>> I don't care about it so much but it is increase u-boot size.
>> Why does u-boot size increase, is it because of  below representation
>> on name filed
>>       = "W25Q80BL/W25Q80BV"
>
> Just because of longer names which go probably to rodata section.
>
> It is not a problem for me at all.

OK, I can go ahead to applied these.
Let me know for any more concerns.

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 1/8] sf: spansion: Update the name for S25FL256S flash

[Jagan Teki]

On 30-05-2013 19:19, Jagannadha Sutradharudu Teki wrote:
> As the per the ID tabl the flash is under Uniform 64-kB sector
> architecture, hence updated with proper name.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> Changes for v2:
> 	- none
>
>   drivers/mtd/spi/spansion.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
> index 307b852..2218e2f 100644
> --- a/drivers/mtd/spi/spansion.c
> +++ b/drivers/mtd/spi/spansion.c
> @@ -108,7 +108,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
>   		.idcode2 = 0x4d01,
>   		.pages_per_sector = 256,
>   		.nr_sectors = 512,
> -		.name = "S25FL256S",
> +		.name = "S25FL256S_64K",
>   	},
>   };
>
>

Applied to u-boot-spi/master

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 3/8] sf: winbond: Add support for W25Q80BW

[Jagan Teki]

On 30-05-2013 19:19, Jagannadha Sutradharudu Teki wrote:
> Add support for Winbond W25Q80BW SPI flash.
>
> This patch corrected the flash name, nr_blocks and
> also commit message header from below patch.
> "sf: winbond: add W25Q32"
> (sha1: c969abc47033d6f810d3c9dbdb994ea9d691d038)
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> Changes for v2:
>          - none
>
>   drivers/mtd/spi/winbond.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
> index cb57ce0..a7cd51f 100644
> --- a/drivers/mtd/spi/winbond.c
> +++ b/drivers/mtd/spi/winbond.c
> @@ -84,8 +84,8 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>   	},
>   	{
>   		.id			= 0x5014,
> -		.nr_blocks		= 128,
> -		.name			= "W25Q80",
> +		.nr_blocks		= 16,
> +		.name			= "W25Q80BW",
>   	},
>   	{
>   		.id			= 0x6016,
>

Applied to u-boot-spi/master

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 4/8] sf: winbond: Correct the nr_blocks used for W25Q32DW

[Jagan Teki]

On 30-05-2013 19:19, Jagannadha Sutradharudu Teki wrote:
> This patch corrected the nr_blocks used for W25Q32DW SPI flash.
>
> nr_blcoks are incorrectly assigned on below patch
> "sf: winbond: add W25Q32DW"
> (sha1: 772ba15474f73adc942e817cc072b6e9750836cc)
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> Changes for v2:
>          - none
>
>   drivers/mtd/spi/winbond.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
> index a7cd51f..8457808 100644
> --- a/drivers/mtd/spi/winbond.c
> +++ b/drivers/mtd/spi/winbond.c
> @@ -89,7 +89,7 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>   	},
>   	{
>   		.id			= 0x6016,
> -		.nr_blocks		= 512,
> +		.nr_blocks		= 64,
>   		.name			= "W25Q32DW",
>   	},
>   	{
>

Applied to u-boot-spi/master

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[Baudouin, Charles]

I think the correct thing to do here is to set the flash up for uniform sector size of 64Kbytes.

CR3V[3] = 1

If I can get the code to work I will send up the updates for uboot.



Charles Baudouin
Research and Development Manager
Domo Tactical Communications
E: Charles.Baudouin at domotactical.com
T: +44 1489 884 430
M: +44 7973 146 671

DTC - Website<http://www.domotactical.com/>
DTC - Linkedin<https://www.linkedin.com/company/domo-tactical-communications-dtc-ltd>
DTC - Twitter<https://twitter.com/DomoBroadcast>
DTC - YouTube<https://www.youtube.com/channel/UC0nBUhsZ9iakjODp9nYRDSw/featured>

Domo Tactical Communications (DTC) LTD trading as DTC, Fusion 2, 1100 Parkway, Whiteley, Hampshire, PO15 7AB, United Kingdom. +44 (0) 1489 566750. www.domotactical.com<http://www.domotactical.com>

Registered office Fusion 2, 1100 Parkway, Solent Business Park, Whiteley, Hampshire, PO15 7AB. Registered in England and Wales, company number 1456922.

Please consider the environment before printing this email.

This e-mail and any files transmitted with it ("E-mail") is intended solely for the addressee(s) and may contain information that is proprietary, privileged, company confidential and/or exempt from disclosure under applicable law. If you are not the intended addressee(s), any disclosure, reproduction, copying, distribution or other use of the E-mail is strictly prohibited. It may also contain data subject to the International Traffic in Arms Regulations or United States Export Administration Regulations, particularly if this E-mail has been transmitted from a United States location, and cannot be disseminated, distributed or copied to foreign nationals, residing in the United States or abroad, without the prior approval of the U.S. Department of State or appropriate export licensing authority. If you have received this E-mail in error, please delete it and destroy all copies of this E-mail and notify the sender immediately via telephone call or return e-mail.

Neither the company nor any subsidiary or affiliate or associated company nor any individual sending this E-mail accepts any liability in respect of the content (including errors and omissions) nor shall this e-mail be deemed to enter the company or any subsidiary or affiliate or associated company into a contract or to create any legally binding obligations unless expressly agreed to in writing under separate cover and timeliness of the E-mail which arise as a result of transmission. If verification is required, please request a hard copy version from the sender.